[Mesa-dev] Fwd: [Mesa-users] Issues with removal of classic OSMesa

[Michel Dänzer]

On 2021-02-02 5:55 p.m., Michel Dänzer wrote:
> On 2021-02-02 6:44 a.m., Dave Airlie wrote:
>> On Mon, 1 Feb 2021 at 16:50, Dave Airlie <airlied at gmail.com> wrote:
>>>
>>> On Thu, 7 Jan 2021 at 21:11, Andreas Fänger <a.faenger at e-sign.com> 
>>> wrote:
>>>>
>>>>>> don’t know why the current softpipe/swrast implementation 
>>>>>> shouldn’t be conformant.
>>>>
>>>>> Interesting I hadn't known we had a correct impl in mesa, the 
>>>>> features.txt has said "softpipe and llvmpipe advertise 16x 
>>>>> anisotropy but simply ignore the setting"
>>>>> so I never dug any deeper. I'll consider a port of this to llvmpipe 
>>>>> at some point, making it efficient might be tricky.
>>>>
>>>> It seems that features.txt hasn't been updated regarding this 
>>>> functionality; softpipe has "real" anisotropy since 2011.
>>>>
>>>>> I'll consider a port of this to llvmpipe at some point, making it 
>>>>> efficient might be tricky.
>>>> That would be great. As anisotropic filtering is often an option 
>>>> which can be set by a user, I guess most people turn it off to get 
>>>> higher framerates. But in our use case, high quality renderings are 
>>>> required, so we accept the longer render times to get the best 
>>>> quality; hopefully a llvmpipe port would be faster than the old 
>>>> swrast implementation (we are only using the fixed rendering 
>>>> pipeline/no shaders in conjunction with the OpenMP patch for 
>>>> speeding up GL_POLYGON_SMOOTH_HINT)
>>>>
>>>> Andreas
>>>
>>> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8804
>>>
>>> Is my first pass at writing the code for this I've no idea if this is
>>> anyway correct, but I'm just letting everyone know I've started
>>> working on it, and mipmap_tunnel doesn't look immediately wrong.
>>
>> Olay the code in the MR above seems to work in most cases now and
>> seems to operate like softpipe.
>>
>> However I'm seeing a trace failure
>> https://tracie.freedesktop.org/dashboard/imagediff/mesa/mesa/7033860/humus/Portals.trace/ 
>>
> 
> The floor at the bottom left of the Actual image definitely looks odd, 
> there's a hard line between the rock patterns.

Not to mention the wall tiles having different sizes, with a hard line 
as well.

Definitely looks like a bug to me, which wouldn't be noticeable with 
special test textures made up of different solid colours per mip level.


-- 
Earthling Michel Dänzer               |               https://redhat.com
Libre software enthusiast             |             Mesa and X developer