<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 23, 2016 at 1:05 AM, Brian Paul <span dir="ltr"><<a href="mailto:brianp@vmware.com" target="_blank">brianp@vmware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 02/22/2016 03:58 PM, Thomas Hindoe Paaboel Andersen wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Before the luminance stride was based on the size of GL_FLOAT<br>
which is just the type constant (0x1406). Change it to use the<br>
size of GLfloat.<br>
---<br>
src/mesa/main/readpix.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c<br>
index 470182a..882d863 100644<br>
--- a/src/mesa/main/readpix.c<br>
+++ b/src/mesa/main/readpix.c<br>
@@ -582,7 +582,7 @@ read_rgba_pixels( struct gl_context *ctx,<br>
void *luminance;<br>
uint32_t luminance_format;<br>
<br>
- luminance_stride = width * sizeof(GL_FLOAT);<br>
+ luminance_stride = width * sizeof(GLfloat);<br>
if (format == GL_LUMINANCE_ALPHA)<br>
luminance_stride *= 2;<br>
luminance_bytes = height * luminance_stride;<br>
<br>
</blockquote>
<br></span>
Thanks.<br>
<br>
Reviewed-by: Brian Paul <<a href="mailto:brianp@vmware.com" target="_blank">brianp@vmware.com</a>><br>
<br>
Need me to push this for you?<span class="HOEnZb"><font color="#888888"></font></span><br></blockquote></div><br></div><div class="gmail_extra">Yes, please push it. Thanks for the fast review.<br></div></div>