<div dir="ltr">On 13 March 2016 at 17:09, Varad Gautam <span dir="ltr"><<a href="mailto:varadgautam@gmail.com" target="_blank">varadgautam@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">- Do not reorder instructions reading packed sources (fixes piglit<br>
regressions with draw-vertices and draw-vertices-user).<br>
---<br>
Eric, Rhys, with this bit we should be good to go.<br>
<br>
 src/gallium/drivers/vc4/vc4_opt_vpm.c | 3 ++-<br>
 1 file changed, 2 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/gallium/drivers/vc4/vc4_opt_vpm.c b/src/gallium/drivers/vc4/vc4_opt_vpm.c<br>
index a4ee6af..d15b0c1 100644<br>
--- a/src/gallium/drivers/vc4/vc4_opt_vpm.c<br>
+++ b/src/gallium/drivers/vc4/vc4_opt_vpm.c<br>
@@ -77,7 +77,8 @@ qir_opt_vpm(struct vc4_compile *c)<br>
                         continue;<br>
<br>
<span class="">                 for (int j = 0; j < qir_get_op_nsrc(inst->op); j++) {<br>
</span>-                        if (inst->src[j].file != QFILE_TEMP)<br>
<span class="">+                        if (inst->src[j].file != QFILE_TEMP ||<br>
</span>+                            inst->src[j].pack)<br>
<div class=""><div class="h5">                                 continue;<br>
<br>
                         uint32_t temp = inst->src[j].index;<br>
</div></div><span class=""><font color="#888888">--<br>
2.6.2<br>
<br>
</font></span></blockquote></div><br><div><div>No piglit regressions, so this gets my<br><br>Tested-by: Rhys Kidd <<a href="mailto:rhyskidd@gmail.com">rhyskidd@gmail.com</a>><br><br></div>This
 applies to the squashed set of [0], [1], and [2] plus this patch. Given
 I believe you do not yet have Mesa commit access, perhaps ask Eric if he'd 
commit that set for you.<br><br></div>Thanks for your contribution Varad!<br><br>[0] <a href="https://patchwork.freedesktop.org/patch/76069/">https://patchwork.freedesktop.org/patch/76069/</a><br>[1] <a href="https://patchwork.freedesktop.org/patch/76070/">https://patchwork.freedesktop.org/patch/76070/</a><br>[2] <a href="https://patchwork.freedesktop.org/patch/76528/">https://patchwork.freedesktop.org/patch/76528/</a><br></div></div>