<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez <span dir="ltr"><<a href="mailto:siglesias@igalia.com" target="_blank">siglesias@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Connor Abbott <<a href="mailto:connor.w.abbott@intel.com">connor.w.abbott@intel.com</a>><br>
<br>
---<br>
src/compiler/nir/nir.h | 4 ++++<br>
1 file changed, 4 insertions(+)<br>
<br>
diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h<br>
index d493186..d2fd23d 100644<br>
--- a/src/compiler/nir/nir.h<br>
+++ b/src/compiler/nir/nir.h<br>
@@ -99,6 +99,7 @@ union nir_constant_data {<br>
int i[16];<br>
float f[16];<br>
bool b[16];<br>
+ double d[16];<br></blockquote><div><br></div><div>See comment below.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
};<br>
<br>
typedef struct nir_constant {<br>
@@ -1177,8 +1178,11 @@ nir_tex_instr_src_index(nir_tex_instr *instr, nir_tex_src_type type)<br>
typedef struct {<br>
union {<br>
float f[4];<br>
+ double d[4];<br>
int32_t i[4];<br>
uint32_t u[4];<br>
+ int64_t l[4];<br>
+ uint64_t ul[4];<br></blockquote><div><br></div><div>I really don't like l and ul. Let's just add bit-size suffixes. If you don't want the churn, feel free to leave the u, i, and f in place for now. It's a union so they'll effectively be aliases for u32, i32, and f32. We should eventually use only the sized versions but that can be a follow-on.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
};<br>
} nir_const_value;<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.7.0<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>