<p dir="ltr"><br>
On Mar 19, 2016 8:44 AM, "Pierre Moreau" <<a href="mailto:pierre.morrow@free.fr">pierre.morrow@free.fr</a>> wrote:<br>
><br>
> On 06:34 PM - Mar 18 2016, Vinson Lee wrote:<br>
> > Fix clang build error.<br>
> ><br>
> > CXX codegen/nv50_ir_lowering_nvc0.lo<br>
> > codegen/nv50_ir_lowering_nvc0.cpp:1783:42: error: invalid suffix 'd' on floating constant<br>
> > Value *zero = bld.loadImm(NULL, 0.0d);<br>
> > ^<br>
> ><br>
> > Fixes: c1e4a6bfbf01 ("nv50,nvc0: handle SQRT lowering inside the driver")<br>
> > Signed-off-by: Vinson Lee <<a href="mailto:vlee@freedesktop.org">vlee@freedesktop.org</a>><br>
> > ---<br>
> > src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 2 +-<br>
> > 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> ><br>
> > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp<br>
> > index d0936d8..01364b3 100644<br>
> > --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp<br>
> > +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp<br>
> > @@ -1780,7 +1780,7 @@ NVC0LoweringPass::handleSQRT(Instruction *i)<br>
> > {<br>
> > if (i->dType == TYPE_F64) {<br>
> > Value *pred = bld.getSSA(1, FILE_PREDICATE);<br>
> > - Value *zero = bld.loadImm(NULL, 0.0d);<br>
> > + Value *zero = bld.loadImm(NULL, 0);<br>
><br>
> Shouldn't it rather be: `Value *zero = bld.loadImm(NULL, 0.0);` as you want a<br>
> double, not an int?</p>
<p dir="ltr">Errrr, right, yes it should be.</p>
<p dir="ltr">><br>
> > Value *dst = bld.getSSA(8);<br>
> > bld.mkOp1(OP_RSQ, i->dType, dst, i->getSrc(0));<br>
> > bld.mkCmp(OP_SET, CC_LE, i->dType, pred, i->dType, i->getSrc(0), zero);<br>
> > --<br>
> > 2.7.3<br>
> ><br>
> > _______________________________________________<br>
> > mesa-dev mailing list<br>
> > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> > <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
><br>
> _______________________________________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
><br>
</p>