<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [llvmpipe] SIGFPE pthread_barrier_destroy.c:40"
href="https://bugs.freedesktop.org/show_bug.cgi?id=94088#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [llvmpipe] SIGFPE pthread_barrier_destroy.c:40"
href="https://bugs.freedesktop.org/show_bug.cgi?id=94088">bug 94088</a>
from <span class="vcard"><a class="email" href="mailto:sroland@vmware.com" title="Roland Scheidegger <sroland@vmware.com>"> <span class="fn">Roland Scheidegger</span></a>
</span></b>
<pre>(In reply to Steve Langasek from <a href="show_bug.cgi?id=94088#c2">comment #2</a>)
<span class="quote">> Hello,
>
> The patch for this bug is incomplete. In between the calls to
> pipe_barrier_init() and pipe_barrier_destroy() are calls to
> pipe_barrier_wait(), which is implemented on top of pthread_barrier_wait().
>
> Since pipe_barrier_init() has not been called, the calls to
> pthread_barrier_wait() have undefined behavior, as per
> <<a href="http://pubs.opengroup.org/onlinepubs/009695399/functions/">http://pubs.opengroup.org/onlinepubs/009695399/functions/</a>
> pthread_barrier_wait.html>,
> <<a href="http://linux.die.net/man/3/pthread_barrier_wait">http://linux.die.net/man/3/pthread_barrier_wait</a>>.
>
> The applied commit is sufficient to fix the immediate SIGFPE problem with
> glibc, but the API is still being used incorrectly and could result in
> future crashes on other implementations.</span >
I can't see how this could possibly happen. Unless I'm missing something,
pipe_barrier_wait() is only called in the thread main function, which will
never get called if we don't have any threads to begin with.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>