<p dir="ltr"><br>
On Mar 23, 2016 2:59 AM, "Samuel Iglesias Gonsálvez" <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>> wrote:<br>
><br>
><br>
><br>
> On 22/03/16 16:17, Samuel Iglesias Gonsálvez wrote:<br>
> > On 21/03/16 23:49, Jason Ekstrand wrote:<br>
> >> On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez <<br>
> >> <a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>> wrote:<br>
> >><br>
> >>> From: Connor Abbott <<a href="mailto:connor.w.abbott@intel.com">connor.w.abbott@intel.com</a>><br>
> >>><br>
> >>> ---<br>
> >>> src/compiler/nir/nir_print.c | 5 ++++-<br>
> >>> 1 file changed, 4 insertions(+), 1 deletion(-)<br>
> >>><br>
> >>> diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c<br>
> >>> index 30a8233..0b3f954 100644<br>
> >>> --- a/src/compiler/nir/nir_print.c<br>
> >>> +++ b/src/compiler/nir/nir_print.c<br>
> >>> @@ -719,7 +719,10 @@ print_load_const_instr(nir_load_const_instr *instr,<br>
> >>> print_state *state)<br>
> >>> * and then print the float in a comment for readability.<br>
> >>> */<br>
> >>><br>
> >>> - fprintf(fp, "0x%08x /* %f */", instr->value.u32[i],<br>
> >>> instr->value.f32[i]);<br>
> >>> + if (instr->def.bit_size == 64)<br>
> >>> + fprintf(fp, "%f", instr->value.f64[i]);<br>
> >>><br>
> >><br>
> >> Let's print out the 64-bit integer here as well. 64-bit integer support<br>
> >> may happen.<br>
> >><br>
> ><br>
> > OK, I will do the change.<br>
> ><br>
> > Sam<br>
> ><br>
><br>
> Looking at this patch and the other two nir/print patches, it makes<br>
> sense to squash them altogether in one patch. Is it OK for you?</p>
<p dir="ltr">Yup. Sounds good</p>
<p dir="ltr">> Sam<br>
><br>
> >><br>
> >>> + else<br>
> >>> + fprintf(fp, "0x%08x /* %f */", instr->value.u32[i],<br>
> >>> instr->value.f32[i]);<br>
> >>> }<br>
> >>><br>
> >>> fprintf(fp, ")");<br>
> >>> --<br>
> >>> 2.5.0<br>
> >>><br>
> >>> _______________________________________________<br>
> >>> mesa-dev mailing list<br>
> >>> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> >>> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
> >>><br>
> >><br>
</p>