<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Patch for pb_reference to explicitly handle NULL src"
href="https://bugs.freedesktop.org/show_bug.cgi?id=94711">94711</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Patch for pb_reference to explicitly handle NULL src
</td>
</tr>
<tr>
<th>Product</th>
<td>Mesa
</td>
</tr>
<tr>
<th>Version</th>
<td>11.1
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Other
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>Other
</td>
</tr>
<tr>
<th>Assignee</th>
<td>mesa-dev@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>john@feith.com
</td>
</tr>
<tr>
<th>QA Contact</th>
<td>mesa-dev@lists.freedesktop.org
</td>
</tr></table>
<p>
<div>
<pre>Created <span class=""><a href="attachment.cgi?id=122572" name="attach_122572" title="Patch for problem.">attachment 122572</a> <a href="attachment.cgi?id=122572&action=edit" title="Patch for problem.">[details]</a></span>
Patch for problem.
Noticed while looking at a crash that pb_reference is called in several
places with src set to NULL which is interesting since pb_reference then
calls pipe_reference with &src->reference. The existing code works since
struct pb_buffer looks like:
struct pb_buffer {
struct pipe_reference reference;
...
meaning &src->reference with src = NULL happens to equal NULL. The
attached patch explicitly handles src = NULL which is less fragile and
clearly communicates that being passed NULL is valid.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>