<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Apr 12, 2016 at 3:51 PM, Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On Apr 12, 2016 3:41 PM, "Matt Turner" <<a href="mailto:mattst88@gmail.com" target="_blank">mattst88@gmail.com</a>> wrote: > > On Tue, Apr 12, 2016 at 3:10 PM, Mark Janes <<a href="mailto:mark.a.janes@intel.com" target="_blank">mark.a.janes@intel.com</a>> wrote: > > Fixes intermittent Vulkan CTS failures within the test groups: > > dEQP-VK.api.object_management.multithreaded_per_thread_device > > dEQP-VK.api.object_management.multithreaded_per_thread_resources > > dEQP-VK.api.object_management.multithreaded_shared_resources > > > > Signed-off-by: Mark Janes <<a href="mailto:mark.a.janes@intel.com" target="_blank">mark.a.janes@intel.com</a>> > > Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=94904" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=94904</a> > > Have you seen <a href="https://gnupg.org/documentation/manuals/gcrypt/Multi_002dThreading.html#Multi_002dThreading" target="_blank">https://gnupg.org/documentation/manuals/gcrypt/Multi_002dThreading.html#Multi_002dThreading</a> > ? > > I feel pretty uncertain that the patch as it is would be sufficient in > general, but maybe it's okay since we're just using libgcrypt for > SHA1? Ugh... It should be *mostly* safe as mesa only uses gcrypt for it's sha1 implementation. However, if something uses GL and uses libgcrypt for something else, we may have a large, hard-to-debug problem. Not sure how dire we think it is. Would it be better to remove the gcrypt implementation in light of this? </blockquote></div>I think this patch is certainly *better* than what we had before. In light of the issues, we may want to remove gcrypt support but that can be a separate patch. Mark, do you mind pushing it to mesa master? </div></div>