<div dir="ltr"> <div class="gmail_extra"> <div class="gmail_quote">On Tue, Apr 19, 2016 at 3:38 PM, Chad Versace <<a href="mailto:chad.versace@intel.com" target="_blank">chad.versace@intel.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Sat 16 Apr 2016, Jason Ekstrand wrote: > --- > src/intel/isl/isl_format.c | 34 ++++++++++++++++------------------ > 1 file changed, 16 insertions(+), 18 deletions(-) > > diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c > index 32bd701..b0450d9 100644 > --- a/src/intel/isl/isl_format.c > +++ b/src/intel/isl/isl_format.c > @@ -25,32 +25,30 @@ > > #include "isl.h" > > -bool > -isl_format_has_uint_channel(enum isl_format fmt) > +static inline bool > +isl_format_has_channel_of_type(enum isl_format fmt, enum isl_base_type type) I think the 'of' in the function name sounds awkward, a little Java-ish. 'isl_format_has_channel_type' sounds better. With or without the change, patch 7 is Reviewed-by: Chad Versace <<a href="mailto:chad.versace@intel.com">chad.versace@intel.com</a>> </blockquote></div>Done </div></div>