<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:jamey@minilop.net" title="Jamey Sharp <jamey@minilop.net>"> <span class="fn">Jamey Sharp</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Divinity: Original Sin Enhanced Edition(Native) crash on start"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=93551">bug 93551</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">OS</td>
           <td>Linux (All)
           </td>
           <td>All
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">CC</td>
           <td>
                
           </td>
           <td>jamey@minilop.net
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Component</td>
           <td>Drivers/Gallium/radeonsi
           </td>
           <td>Mesa core
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">QA Contact</td>
           <td>dri-devel@lists.freedesktop.org
           </td>
           <td>mesa-dev@lists.freedesktop.org
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Hardware</td>
           <td>x86-64 (AMD64)
           </td>
           <td>All
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Assignee</td>
           <td>dri-devel@lists.freedesktop.org
           </td>
           <td>mesa-dev@lists.freedesktop.org
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Divinity: Original Sin Enhanced Edition(Native) crash on start"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=93551#c10">Comment # 10</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Divinity: Original Sin Enhanced Edition(Native) crash on start"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=93551">bug 93551</a>
              from <span class="vcard"><a class="email" href="mailto:jamey@minilop.net" title="Jamey Sharp <jamey@minilop.net>"> <span class="fn">Jamey Sharp</span></a>
</span></b>
        <pre>(In reply to smidjar2.reg from <a href="show_bug.cgi?id=93551#c6">comment #6</a>)
<span class="quote">> I disassembled ApplyConstants() where the game crashes when using OpenGL
> override to 4.2.</span >

I spent a while poking at this crash in gdb, and I was definitely seeing the
same segfault at the same instruction and call-stack.

I've sent a (one-line!) patch to mesa-dev that fixes this segfault on startup:

<a href="https://lists.freedesktop.org/archives/mesa-dev/2016-April/114614.html">https://lists.freedesktop.org/archives/mesa-dev/2016-April/114614.html</a>

And a Piglit patch that tests for the non-conforming behavior that led to this
crash:

<a href="https://lists.freedesktop.org/archives/mesa-dev/2016-April/114613.html">https://lists.freedesktop.org/archives/mesa-dev/2016-April/114613.html</a>

Thanks to Karol Herbst's mesa-dev post, linked from <a href="show_bug.cgi?id=93551#c7">comment #7</a>, for pointing me
in the right direction to find this Mesa bug.

Granted, the game developers ought to check for errors returned from
glLinkProgram and fail more gracefully than a segfault, but I doubt we're going
to get them to do *that*...

I can now play this game somewhat successfully on i965 with
MESA_GL_VERSION_OVERRIDE=4.2. There are still plenty of rendering bugs I
haven't dug into yet, but I played for an hour without crashes, at least!

I don't have (or particularly want) a commit bit on Mesa or Piglit, so now we
need somebody to review and hopefully merge these patches.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the QA Contact for the bug.</li>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>