<div dir="ltr"><div>fine by me<br><br></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 27, 2016 at 11:00 AM, Alejandro Piñeiro <span dir="ltr"><<a href="mailto:apinheiro@igalia.com" target="_blank">apinheiro@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The test was failing to build with "undefined reference to `roundf'" errors,<br>
so Make check on mesa was failing.<br>
---<br>
<br>
The previouos change on the same Makefile.am had the same intention (fixing<br>
make check using -lm), so I guess that the problem is on my environment. Having<br>
said so, I checked on the rest of the Makefile.am of the project, and they place<br>
the -lm at the end, or at least after the mesa .la<br>
<br>
src/intel/isl/Makefile.am | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/isl/Makefile.am b/src/intel/isl/Makefile.am<br>
index 806934e..1427e7b 100644<br>
--- a/src/intel/isl/Makefile.am<br>
+++ b/src/intel/isl/Makefile.am<br>
@@ -110,9 +110,9 @@ check_PROGRAMS = $(TESTS)<br>
<br>
# Link tests to <a href="http://lib965_compiler.la" rel="noreferrer" target="_blank">lib965_compiler.la</a> for brw_get_device_info().<br>
tests_ldadd = \<br>
- -lm \<br>
<a href="http://libisl.la" rel="noreferrer" target="_blank">libisl.la</a> \<br>
- $(top_builddir)/src/mesa/drivers/dri/i965/<a href="http://libi965_compiler.la" rel="noreferrer" target="_blank">libi965_compiler.la</a><br>
+ $(top_builddir)/src/mesa/drivers/dri/i965/<a href="http://libi965_compiler.la" rel="noreferrer" target="_blank">libi965_compiler.la</a> \<br>
+ -lm<br>
<br>
tests_isl_surf_get_image_offset_test_SOURCES = \<br>
tests/isl_surf_get_image_offset_test.c<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.5.0<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>