<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Apr 29, 2016 at 9:59 PM, Thomas H.P. Andersen <span dir="ltr"><<a href="mailto:phomes@gmail.com" target="_blank">phomes@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Fri, Apr 29, 2016 at 8:39 PM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Apr 29, 2016 at 11:31 AM, Thomas Hindoe Paaboel Andersen <span dir="ltr"><<a href="mailto:phomes@gmail.com" target="_blank">phomes@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Parenthesis are needed here as ! takes precedence over the &. The<br>
check had the opposite effect than intended.<br>
---<br>
Not tested as I do not own the neccesary hardware.<br>
<br>
 src/compiler/nir/nir_opt_dead_cf.c | 4 ++--<br>
 1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/compiler/nir/nir_opt_dead_cf.c b/src/compiler/nir/nir_opt_dead_cf.c<br>
index 2e04c17..7450b1c 100644<br>
--- a/src/compiler/nir/nir_opt_dead_cf.c<br>
+++ b/src/compiler/nir/nir_opt_dead_cf.c<br>
@@ -155,8 +155,8 @@ cf_node_has_side_effects(nir_cf_node *node)<br>
             continue;<br>
<br>
          nir_intrinsic_instr *intrin = nir_instr_as_intrinsic(instr);<br>
-         if (!nir_intrinsic_infos[intrin->intrinsic].flags &<br>
-             NIR_INTRINSIC_CAN_ELIMINATE)<br>
+         if (!(nir_intrinsic_infos[intrin->intrinsic].flags &<br>
+             NIR_INTRINSIC_CAN_ELIMINATE))<br></blockquote><div><br></div></span><div>Good catch!  All three patches are<br><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>><br></div></div></div></div></blockquote><div><br></div></span><div>Thanks Jason! Can I ask you to push it? I do not have commit access.</div></div></div></div></blockquote><div><br></div><div>Pushed!<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
             return true;<br>
       }<br>
    }<span><font color="#888888"><br>
<span><font color="#888888">--<br>
2.7.4<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></font></span></blockquote></div><br></div></div>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div></div>