<div dir="ltr">I just finished crawling through this code and I'm pretty sure we do mostly the right thing for ES. I'll be even more sure after my series lands. <div> Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div></div><div class="gmail_extra"> <div class="gmail_quote">On Thu, May 12, 2016 at 6:31 PM, Kenneth Graunke <<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This enables: - GL_OES_sample_shading - GL_OES_sample_variables - GL_OES_shader_multisample_interpolation We pass all the CTS tests, and all but 8 of the dEQP-GLES31 tests. Half of the failing dEQP tests appear to be broken tests; the other four still need investigating but cover an obscure corner case. Otherwise, the functionality is in great shape, and actually in better shape than the ARB_sample_shading support we've shipped for years (we fixed a number of bugs when enabling this). So it makes sense to enable it for our users in the Mesa 12.0 release. Signed-off-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 8d98788..7f44c1d 100644 --- a/src/mesa/drivers/dri/i965/intel_extensions.c +++ b/src/mesa/drivers/dri/i965/intel_extensions.c @@ -308,6 +308,7 @@ intelInitExtensions(struct gl_context *ctx) ctx->Extensions.EXT_framebuffer_multisample_blit_scaled = true; ctx->Extensions.EXT_transform_feedback = true; ctx->Extensions.OES_depth_texture_cube_map = true; + ctx->Extensions.OES_sample_variables = true; ctx->Extensions.ARB_timer_query = brw->intelScreen->hw_has_timestamp; -- 2.8.2 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>