<p dir="ltr">Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></p>
<p dir="ltr">Marek </p>
<div class="gmail_quote">On May 20, 2016 7:51 PM, "Rob Herring" <<a href="mailto:robh@kernel.org">robh@kernel.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">transfer_inline_write cannot be NULL and the virgl renderer doesn't support<br>
inline writes for textures, so add the default version.<br>
<br>
This fixes a crash in st_TexSubImage since commit fb9fe352ea41 ("st/mesa:<br>
use transfer_inline_write for memcpy TexSubImage path").<br>
<br>
Cc: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>><br>
Cc: Dave Airlie <<a href="mailto:airlied@redhat.com">airlied@redhat.com</a>><br>
Signed-off-by: Rob Herring <<a href="mailto:robh@kernel.org">robh@kernel.org</a>><br>
---<br>
src/gallium/drivers/virgl/virgl_texture.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/gallium/drivers/virgl/virgl_texture.c b/src/gallium/drivers/virgl/virgl_texture.c<br>
index f395f1f..34db056 100644<br>
--- a/src/gallium/drivers/virgl/virgl_texture.c<br>
+++ b/src/gallium/drivers/virgl/virgl_texture.c<br>
@@ -304,7 +304,7 @@ static const struct u_resource_vtbl virgl_texture_vtbl =<br>
virgl_texture_transfer_map, /* transfer_map */<br>
NULL, /* transfer_flush_region */<br>
virgl_texture_transfer_unmap, /* transfer_unmap */<br>
- NULL /* transfer_inline_write */<br>
+ u_default_transfer_inline_write /* transfer_inline_write */<br>
};<br>
<br>
struct pipe_resource *<br>
--<br>
2.7.4<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>