<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 23, 2016 at 3:51 PM, Kenneth Graunke <span dir="ltr"><<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Friday, May 20, 2016 4:53:19 PM PDT Jason Ekstrand wrote:<br>
> Bay Trail and Haswell added a bunch of new vertex formats. There was also<br>
> the addition of 64-bit passthrough formats for BDW+.<br>
> ---<br>
> src/mesa/drivers/dri/i965/brw_surface_formats.c | 32 +++++++++++<br>
+-------------<br>
> 1 file changed, 16 insertions(+), 16 deletions(-)<br>
<br>
</span>I don't think we actually use this column for anything.<br>
<br>
All the other SFIXED formats should be marked 75 as well.<br>
(You've missed some more of them.)<br></blockquote><div><br></div><div>I was also missing B10G10R10A2_UNORM which was aparently added on BYT,HSW+ which I've added locally.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> diff --git a/src/mesa/drivers/dri/i965/brw_surface_formats.c b/src/mesa/<br>
<div class="HOEnZb"><div class="h5">drivers/dri/i965/brw_surface_formats.c<br>
> index 16667b9..750f37a 100644<br>
> --- a/src/mesa/drivers/dri/i965/brw_surface_formats.c<br>
> +++ b/src/mesa/drivers/dri/i965/brw_surface_formats.c<br>
> @@ -274,26 +274,26 @@ const struct brw_surface_format_info surface_formats[]<br>
= {<br>
> SF(80, 80, x, x, x, x, x, x, x, x, EAC_SIGNED_R11)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, EAC_SIGNED_RG11)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ETC2_SRGB8)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, R16G16B16_UINT)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, R16G16B16_SINT)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, R32_SFIXED)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, R10G10B10A2_SNORM)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, R10G10B10A2_USCALED)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, R10G10B10A2_SSCALED)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, R10G10B10A2_SINT)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, B10G10R10A2_SNORM)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, B10G10R10A2_USCALED)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, B10G10R10A2_SSCALED)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, B10G10R10A2_UINT)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, B10G10R10A2_SINT)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, R64G64B64A64_PASSTHRU)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, R64G64B64_PASSTHRU)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, R16G16B16_UINT)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, R16G16B16_SINT)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, R32_SFIXED)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, R10G10B10A2_SNORM)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, R10G10B10A2_USCALED)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, R10G10B10A2_SSCALED)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, R10G10B10A2_SINT)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, B10G10R10A2_SNORM)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, B10G10R10A2_USCALED)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, B10G10R10A2_SSCALED)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, B10G10R10A2_UINT)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, B10G10R10A2_SINT)<br>
> + SF( x, x, x, x, x, x, 80, x, x, x, R64G64B64A64_PASSTHRU)<br>
> + SF( x, x, x, x, x, x, 80, x, x, x, R64G64B64_PASSTHRU)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ETC2_RGB8_PTA)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ETC2_SRGB8_PTA)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ETC2_EAC_RGBA8)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ETC2_EAC_SRGB8_A8)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, R8G8B8_UINT)<br>
> - SF( x, x, x, x, x, x, x, x, x, x, R8G8B8_SINT)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, R8G8B8_UINT)<br>
> + SF( x, x, x, x, x, x, 75, x, x, x, R8G8B8_SINT)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ASTC_LDR_2D_4x4_FLT16)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ASTC_LDR_2D_5x4_FLT16)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ASTC_LDR_2D_5x5_FLT16)<br>
><br>
<br>
</div></div></blockquote></div><br></div></div>