Really it's a workaround to fix bad vectorization in the Intel compiler, but it doesn't it doesn't hurt for other compilers, even if the performance difference is marginal if at all, and could only help. If it was problematic otherwise I'd guard it with an #ifdef _INTEL_COMPILER. I can update the patch with a comment explaining why it's there in case other developers stumble on it and think "wtf". <div class="gmail_quote">On Jun 28, 2016 6:38 PM, "Roland Scheidegger" <<a href="mailto:sroland@vmware.com">sroland@vmware.com</a>> wrote: <blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="elided-text">Am 28.06.2016 um 22:45 schrieb Chuck Atkins: > This aligns the 4-element color float array to 16 byte boundaries. This > should allow compiler vectorizers to generate better optimizations. > Also fixes broken vectorization generated by Intel compiler. > > Reported-by: Tim Rowley <<a href="mailto:timothy.o.rowley@intel.com">timothy.o.rowley@intel.com</a>> > Signed-off-by: Chuck Atkins <<a href="mailto:chuck.atkins@kitware.com">chuck.atkins@kitware.com</a>> > --- > src/gallium/include/pipe/p_state.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h > index 1543e90..95f140f 100644 > --- a/src/gallium/include/pipe/p_state.h > +++ b/src/gallium/include/pipe/p_state.h > @@ -326,7 +326,7 @@ struct pipe_blend_state > > struct pipe_blend_color > { > - float color[4]; > + PIPE_ALIGN_VAR(16) float color[4]; > }; > </div>I'm wondering if that's really needed. I have a difficult time to imagine setting blend color is performance critical. And driver internal you can obviously still align pipe_blend_color structs yourself. But OTOH, why not... Acked-by: Roland Scheidegger <<a href="mailto:sroland@vmware.com">sroland@vmware.com</a>> </blockquote></div>