<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jun 28, 2016 at 10:27 PM, Pohjolainen, Topi <span dir="ltr"><<a href="mailto:topi.pohjolainen@intel.com" target="_blank">topi.pohjolainen@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Tue, Jun 28, 2016 at 09:22:49AM +0300, Pohjolainen, Topi wrote:<br>
> On Thu, Jun 23, 2016 at 02:00:30PM -0700, Jason Ekstrand wrote:<br>
> > ---<br>
> >  src/mesa/drivers/dri/i965/brw_wm_surface_state.c  | 11 ++++++-----<br>
> >  src/mesa/drivers/dri/i965/gen7_wm_surface_state.c |  9 +++++----<br>
> >  src/mesa/drivers/dri/i965/gen8_surface_state.c    |  9 +++++----<br>
> >  3 files changed, 16 insertions(+), 13 deletions(-)<br>
> ><br>
> > diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c<br>
> > index 944d64d..29b8976 100644<br>
> > --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c<br>
> > +++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c<br>
> > @@ -496,6 +496,7 @@ gen4_emit_buffer_surface_state(struct brw_context *brw,<br>
> >                                 unsigned pitch,<br>
> >                                 bool rw)<br>
> >  {<br>
> > +   unsigned elements = buffer_size / pitch;<br>
><br>
> Could be const as well as in the two other occurences further down.<br></span></blockquote><div><br></div><div>If you don't mind, I'd rather not bother since that comment only applies to functions that get deleted by the next patch.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
<br>
</span>Otherwise patches 31-34 are also:<br>
<br>
Reviewed-by: Topi Pohjolainen <<a href="mailto:topi.pohjolainen@intel.com" target="_blank">topi.pohjolainen@intel.com</a>><br>
</blockquote></div><br></div></div>