<div dir="ltr"><div><div>Thanks for fixing this! Both are<br><br></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div>Cc: "12.0" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 13, 2016 at 5:32 PM, Nanley Chery <span dir="ltr"><<a href="mailto:nanleychery@gmail.com" target="_blank">nanleychery@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Set limits that are consistent with ISL's assertions in<br>
isl_genX(buffer_fill_state_s)() and Anvil's format-DescriptorType<br>
mapping in anv_isl_format_for_descriptor_type().<br>
<br>
Fixes the following new crucible tests:<br>
* stress.limits.buffer-update.range.uniform<br>
* stress.limits.buffer-update.range.storage<br>
<br>
These tests are in this patch: <a href="https://patchwork.freedesktop.org/patch/98726/" rel="noreferrer" target="_blank">https://patchwork.freedesktop.org/patch/98726/</a><br>
<br>
Signed-off-by: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>><br>
---<br>
src/intel/vulkan/anv_device.c | 8 ++++++--<br>
1 file changed, 6 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c<br>
index dd941b6..f181eb7 100644<br>
--- a/src/intel/vulkan/anv_device.c<br>
+++ b/src/intel/vulkan/anv_device.c<br>
@@ -438,6 +438,10 @@ void anv_GetPhysicalDeviceProperties(<br>
<br>
const float time_stamp_base = devinfo->gen >= 9 ? 83.333 : 80.0;<br>
<br>
+ /* See assertions made when programming the buffer surface state. */<br>
+ const uint32_t max_raw_buffer_sz = devinfo->gen >= 7 ?<br>
+ (1ul << 30) : (1ul << 27);<br>
+<br>
VkSampleCountFlags sample_counts =<br>
isl_device_get_sample_counts(&pdevice->isl_dev);<br>
<br>
@@ -448,8 +452,8 @@ void anv_GetPhysicalDeviceProperties(<br>
.maxImageDimensionCube = (1 << 14),<br>
.maxImageArrayLayers = (1 << 11),<br>
.maxTexelBufferElements = 128 * 1024 * 1024,<br>
- .maxUniformBufferRange = UINT32_MAX,<br>
- .maxStorageBufferRange = UINT32_MAX,<br>
+ .maxUniformBufferRange = (1ul << 27),<br>
+ .maxStorageBufferRange = max_raw_buffer_sz,<br>
.maxPushConstantsSize = MAX_PUSH_CONSTANTS_SIZE,<br>
.maxMemoryAllocationCount = UINT32_MAX,<br>
.maxSamplerAllocationCount = 64 * 1024,<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.9.0<br>
<br>
</font></span></blockquote></div><br></div>