<p dir="ltr">Adding Dylan</p>
<div class="gmail_extra"><br><div class="gmail_quote">On Jul 14, 2016 10:24 PM, "Samuel Iglesias Gonsálvez" <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
On 14/07/16 18:34, Eric Engestrom wrote:<br>
> On Thu, Jul 14, 2016 at 04:01:13PM +0100, Eric Engestrom wrote:<br>
>> Oh right, there's already check for the Mako version, but the minimum is<br>
>> currently set to 0.3.4 (<a href="http://configure.ac:92" rel="noreferrer" target="_blank">configure.ac:92</a>).<br>
>><br>
>> Emil, you were the one to mention 0.8.0; is that the actual minimum, or<br>
>> just a known working version?<br>
><br>
> OK, so I did a bit of digging, and the version check was introduced by<br>
> Samuel Iglesias Gonsalvez a couple years ago (2b37bea0) at 0.7.3, and<br>
> he later lowered it to 0.3.4 (6d43a4c3), but I can't find any discussion<br>
> regarding this change: it seems there was none on the mailing list [0].<br>
><br>
> Adding Samuel so he can enlighten us :)<br>
><br>
> [0] <a href="https://lists.freedesktop.org/archives/mesa-dev/2015-January/074366.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/archives/mesa-dev/2015-January/074366.html</a><br>
><br>
<br>
There was a discussion in the mailing list. Just after I pushed this<br>
patch to master [0] setting it to 0.7.3 (because that was the version I<br>
had back then), Dave Airlie mentioned that RHEL6 only ships mako 0.3.4<br>
[1] and asked if we really need a later version or not. We did some<br>
tests [2][3] and finally this patch [4] was pushed upstream.<br>
<br>
I don't know if we need some feature from mako 0.8.0 to generate<br>
isl_format_layout because this file was added later than my change,<br>
probably Emil knows it.<br>
<br>
Sam<br>
<br>
[0] <a href="https://lists.freedesktop.org/archives/mesa-dev/2015-January/074000.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/archives/mesa-dev/2015-January/074000.html</a><br>
[1] <a href="https://lists.freedesktop.org/archives/mesa-dev/2015-January/074283.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/archives/mesa-dev/2015-January/074283.html</a><br>
[2] <a href="https://lists.freedesktop.org/archives/mesa-dev/2015-January/074287.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/archives/mesa-dev/2015-January/074287.html</a><br>
[3] <a href="https://lists.freedesktop.org/archives/mesa-dev/2015-January/074332.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/archives/mesa-dev/2015-January/074332.html</a><br>
[4] <a href="https://lists.freedesktop.org/archives/mesa-dev/2015-January/074366.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/archives/mesa-dev/2015-January/074366.html</a><br>
<br>
<br>_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
<br></blockquote></div></div>