<p dir="ltr"></p>
<p dir="ltr">On Jul 18, 2016 10:11 PM, "Chris Forbes" <<a href="mailto:chrisf@ijw.co.nz">chrisf@ijw.co.nz</a>> wrote:<br>
><br>
> I remember arguing about this when it got added -- tradeoff was payload size/register pressure vs needing to call out to this unit, if centroid barycentric coords weren't required for anything else? It does seem fairly pointless, though.<br>
><br>
> For the series:-<br>
><br>
> Reviewed-by: Chris Forbes <<a href="mailto:chrisforbes@google.com">chrisforbes@google.com</a>></p>
<p dir="ltr">I'd like to chip in before you get too excited and push. I'll take a proper look tomorrow.</p>
<p dir="ltr">> On Tue, Jul 19, 2016 at 8:26 AM, Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> wrote:<br>
>><br>
>> We no longer use this message.  As far as I can tell, it's fairly<br>
>> useless - the equivalent information is provided in the payload.<br>
>><br>
>> Signed-off-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>><br>
>> ---<br>
>>  src/mesa/drivers/dri/i965/brw_defines.h        | 1 -<br>
>>  src/mesa/drivers/dri/i965/brw_fs.cpp           | 2 --<br>
>>  src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 5 -----<br>
>>  src/mesa/drivers/dri/i965/brw_shader.cpp       | 2 --<br>
>>  4 files changed, 10 deletions(-)<br>
>><br>
>> diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h<br>
>> index b5a259e..2814fa7 100644<br>
>> --- a/src/mesa/drivers/dri/i965/brw_defines.h<br>
>> +++ b/src/mesa/drivers/dri/i965/brw_defines.h<br>
>> @@ -1120,7 +1120,6 @@ enum opcode {<br>
>>     FS_OPCODE_UNPACK_HALF_2x16_SPLIT_X,<br>
>>     FS_OPCODE_UNPACK_HALF_2x16_SPLIT_Y,<br>
>>     FS_OPCODE_PLACEHOLDER_HALT,<br>
>> -   FS_OPCODE_INTERPOLATE_AT_CENTROID,<br>
>>     FS_OPCODE_INTERPOLATE_AT_SAMPLE,<br>
>>     FS_OPCODE_INTERPOLATE_AT_SHARED_OFFSET,<br>
>>     FS_OPCODE_INTERPOLATE_AT_PER_SLOT_OFFSET,<br>
>> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp<br>
>> index 06007fe..120d6dd 100644<br>
>> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp<br>
>> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp<br>
>> @@ -250,7 +250,6 @@ fs_inst::is_send_from_grf() const<br>
>>     switch (opcode) {<br>
>>     case FS_OPCODE_VARYING_PULL_CONSTANT_LOAD_GEN7:<br>
>>     case SHADER_OPCODE_SHADER_TIME_ADD:<br>
>> -   case FS_OPCODE_INTERPOLATE_AT_CENTROID:<br>
>>     case FS_OPCODE_INTERPOLATE_AT_SAMPLE:<br>
>>     case FS_OPCODE_INTERPOLATE_AT_SHARED_OFFSET:<br>
>>     case FS_OPCODE_INTERPOLATE_AT_PER_SLOT_OFFSET:<br>
>> @@ -4785,7 +4784,6 @@ get_lowered_simd_width(const struct brw_device_info *devinfo,<br>
>>     case FS_OPCODE_PACK_HALF_2x16_SPLIT:<br>
>>     case FS_OPCODE_UNPACK_HALF_2x16_SPLIT_X:<br>
>>     case FS_OPCODE_UNPACK_HALF_2x16_SPLIT_Y:<br>
>> -   case FS_OPCODE_INTERPOLATE_AT_CENTROID:<br>
>>     case FS_OPCODE_INTERPOLATE_AT_SAMPLE:<br>
>>     case FS_OPCODE_INTERPOLATE_AT_SHARED_OFFSET:<br>
>>     case FS_OPCODE_INTERPOLATE_AT_PER_SLOT_OFFSET:<br>
>> diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp<br>
>> index 1e9c7da..a390184 100644<br>
>> --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp<br>
>> +++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp<br>
>> @@ -2054,11 +2054,6 @@ fs_generator::generate_code(const cfg_t *cfg, int dispatch_width)<br>
>>           }<br>
>>           break;<br>
>><br>
>> -      case FS_OPCODE_INTERPOLATE_AT_CENTROID:<br>
>> -         generate_pixel_interpolator_query(inst, dst, src[0], src[1],<br>
>> -                                           GEN7_PIXEL_INTERPOLATOR_LOC_CENTROID);<br>
>> -         break;<br>
>> -<br>
>>        case FS_OPCODE_INTERPOLATE_AT_SAMPLE:<br>
>>           generate_pixel_interpolator_query(inst, dst, src[0], src[1],<br>
>>                                             GEN7_PIXEL_INTERPOLATOR_LOC_SAMPLE);<br>
>> diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp<br>
>> index f3b5487..559e44c 100644<br>
>> --- a/src/mesa/drivers/dri/i965/brw_shader.cpp<br>
>> +++ b/src/mesa/drivers/dri/i965/brw_shader.cpp<br>
>> @@ -367,8 +367,6 @@ brw_instruction_name(const struct brw_device_info *devinfo, enum opcode op)<br>
>>     case FS_OPCODE_PLACEHOLDER_HALT:<br>
>>        return "placeholder_halt";<br>
>><br>
>> -   case FS_OPCODE_INTERPOLATE_AT_CENTROID:<br>
>> -      return "interp_centroid";<br>
>>     case FS_OPCODE_INTERPOLATE_AT_SAMPLE:<br>
>>        return "interp_sample";<br>
>>     case FS_OPCODE_INTERPOLATE_AT_SHARED_OFFSET:<br>
>> --<br>
>> 2.9.0<br>
>><br>
>> _______________________________________________<br>
>> mesa-dev mailing list<br>
>> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
>> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
></p>