<div dir="ltr">Hi Emil,<div><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 18, 2016 at 4:44 PM, Emil Velikov <span dir="ltr"><<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Nayan,<br>
<br>
A couple of suggestions, which I hope will be less controversial than<br>
the "s/.f/.0f/" from earlier ;-)<br>
<span class=""><br>
On 14 July 2016 at 21:58, Nayan Deshmukh <<a href="mailto:nayan26deshmukh@gmail.com">nayan26deshmukh@gmail.com</a>> wrote:<br>
> HIGH_QUALITY_SCALING_L2 to HIGH_QUALTIY_SCALING_L9<br>
> uses lanczos filter with number representing the size<br>
> of the sinc window.<br>
><br>
> Signed-off-by: Nayan Deshmukh <<a href="mailto:nayan26deshmukh@gmail.com">nayan26deshmukh@gmail.com</a>><br>
> ---<br>
>  src/gallium/state_trackers/vdpau/mixer.c         | 150 ++++++++++++++++++-----<br>
>  src/gallium/state_trackers/vdpau/query.c         |   8 ++<br>
>  src/gallium/state_trackers/vdpau/vdpau_private.h |   7 ++<br>
>  3 files changed, 131 insertions(+), 34 deletions(-)<br>
>  mode change 100644 => 100755 src/gallium/state_trackers/vdpau/mixer.c<br>
>  mode change 100644 => 100755 src/gallium/state_trackers/vdpau/query.c<br>
>  mode change 100644 => 100755 src/gallium/state_trackers/vdpau/vdpau_private.h<br>
><br>
</span>Please don't add the execute bit on source files.<br>
<span class=""><br>
</span></blockquote><div>Sorry for this, I'll take care of this in the next version.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">> @@ -660,6 +691,54 @@ vlVdpVideoMixerSetFeatureEnables(VdpVideoMixer mixer,<br>
>           vlVdpVideoMixerUpdateBicubicFilter(vmixer);<br>
>           break;<br>
><br>
> +      case VDP_VIDEO_MIXER_FEATURE_HIGH_QUALITY_SCALING_L2:<br>
</span>[...]<br>
<span class="">> +      case VDP_VIDEO_MIXER_FEATURE_HIGH_QUALITY_SCALING_L9:<br>
> +         vmixer->lanczos.enabled = feature_enables[i];<br>
> +         vmixer->lanczos.size = 9;<br>
> +         vlVdpVideoMixerUpdateLanczosFilter(vmixer);<br>
> +         break;<br>
> +<br>
</span>Considering that libvdpau cannot break its ABI the above is simply:<br>
<br>
      case VDP_VIDEO_MIXER_FEATURE_HIGH_QUALITY_SCALING_L2:<br>
      case VDP_VIDEO_MIXER_FEATURE_HIGH_QUALITY_SCALING_L3:<br>
      case VDP_VIDEO_MIXER_FEATURE_HIGH_QUALITY_SCALING_L4:<br>
      case VDP_VIDEO_MIXER_FEATURE_HIGH_QUALITY_SCALING_L5:<br>
      case VDP_VIDEO_MIXER_FEATURE_HIGH_QUALITY_SCALING_L6:<br>
      case VDP_VIDEO_MIXER_FEATURE_HIGH_QUALITY_SCALING_L7:<br>
      case VDP_VIDEO_MIXER_FEATURE_HIGH_QUALITY_SCALING_L8:<br>
      case VDP_VIDEO_MIXER_FEATURE_HIGH_QUALITY_SCALING_L9:<br>
<span class="">         vmixer->lanczos.enabled = feature_enables[i];<br>
</span>         vmixer->lanczos.size = features[i] -<br>
VDP_VIDEO_MIXER_FEATURE_HIGH_QUALITY_SCALING_L1 + 1;<br>
         vlVdpVideoMixerUpdateLanczosFilter(vmixer);<br>
         break;<br>
<br></blockquote><div>A much better approach. Thanks.</div><div> </div><div>Regards,</div><div>Nayan.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Regards,<br>
Emil<br>
</blockquote></div><br></div></div></div>