<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""> <div><blockquote type="cite" class=""><div class="">On Jul 26, 2016, at 14:37, Marek Olšák <<a href="mailto:maraeo@gmail.com" class="">maraeo@gmail.com</a>> wrote:</div> <div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Sat, Jul 23, 2016 at 4:07 PM, Nicolai Hähnle <<a href="mailto:nhaehnle@gmail.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">nhaehnle@gmail.com</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">> wrote:<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">On 22.07.2016 12:08, Michel Dänzer wrote: <blockquote type="cite" class=""> On 21.07.2016 18:17, Matt Arsenault wrote: <blockquote type="cite" class=""><blockquote type="cite" class=""> On Jul 21, 2016, at 01:03, Michel Dänzer <<a href="mailto:michel@daenzer.net" class="">michel@daenzer.net</a> <<a href="mailto:michel@daenzer.net" class="">mailto:michel@daenzer.net</a>>> wrote: On 21.07.2016 00:04, Michel Dänzer wrote: <blockquote type="cite" class=""> On 15.07.2016 05:15, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: <blockquote type="cite" class=""> Module: Mesa Branch: master Commit: f84e9d749fbb6da73a60fb70e6725db773c9b8f8 URL: <a href="http://cgit.freedesktop.org/mesa/mesa/commit/?id=f84e9d749fbb6da73a60fb70e6725db773c9b8f8" class="">http://cgit.freedesktop.org/mesa/mesa/commit/?id=f84e9d749fbb6da73a60fb70e6725db773c9b8f8</a> Author: Marek Olšák <marek.olsak@amd.com <mailto:marek.olsak@amd.com>> Date: Thu Jul 14 22:07:46 2016 +0200 Revert "radeon/llvm: Use alloca instructions for larger arrays" This reverts commit 513fccdfb68e6a71180e21827f071617c93fd09b. Bioshock Infinite hangs with that. </blockquote> Unfortunately, this change caused the piglit test shaders@glsl-fs-vec4-indexing-temp-dst-in-loop (and possibly others) to hang my Kaveri. Any ideas for how we can get out of this conundrum? </blockquote> The hang was introduced by LLVM SVN r275934 ("AMDGPU: Expand register indexing pseudos in custom inserter"). The good/bad (without/with r275934) shader dumps and the GALLIUM_DDEBUG=800 dump corresponding to the hang are attached. BTW, even with Marek's change above reverted, I still see some piglit regressions compared to last week, but I'm not sure if those are all related to the same LLVM change. -- Earthling Michel Dänzer | <a href="http://www.amd.com" class="">http://www.amd.com</a> <<a href="http://www.amd.com/" class="">http://www.amd.com/</a>> Libre software enthusiast | Mesa and X developer <glsl-fs-vec4-indexing-temp-dst-in-loop.bad><glsl-fs-vec4-indexing-temp-dst-in-loop.good><shader_runner_3339_00000000.txt> </blockquote> This fixes the verifier error in it: <a href="https://reviews.llvm.org/D22616" class="">https://reviews.llvm.org/D22616</a> </blockquote> This seems to fix the hang, thanks! <blockquote type="cite" class="">This fixes another issue which may be related: <a href="https://reviews.llvm.org/D22556" class="">https://reviews.llvm.org/D22556</a> </blockquote> Even with that applied as well, there are still piglit regressions compared to early last week, see the attached dumps (look for "LLVM triggered Diagnostic Handler:"). </blockquote> Looks like the "rewrite undef" part of the Two Address Instruction Pass also needs to be adjusted -- I've attached a bugpoint-reduced test case. Also, the hang that motivated the original revert in Mesa should be fixed with <a href="https://reviews.llvm.org/D22673" class="">https://reviews.llvm.org/D22673</a> (and the related <a href="https://reviews.llvm.org/D22675" class="">https://reviews.llvm.org/D22675</a> is also needed for correctness, though probably not for fixing the hang). </blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">FYI, I've reverted the revert.<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Marek</div></blockquote></div> <div class=""> </div><div class="">It might be nice if this could be an option, since this was probably the main stressor of the register indexing code</div><div class=""> </div><div class="">-Matt</div><div class=""> </div></body></html>