On Jul 26, 2016 6:49 PM, "Matt Turner" <<a href="mailto:mattst88@gmail.com">mattst88@gmail.com</a>> wrote: > > On Tue, Jul 26, 2016 at 3:11 PM, Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote: > > --- > > src/mesa/drivers/dri/i965/Makefile.sources | 2 +- > > src/mesa/drivers/dri/i965/blorp_blit.c | 1662 ++++++++++++++++++++++++++ > > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 1662 -------------------------- > > 3 files changed, 1663 insertions(+), 1663 deletions(-) > > create mode 100644 src/mesa/drivers/dri/i965/blorp_blit.c > > delete mode 100644 src/mesa/drivers/dri/i965/brw_blorp_blit.cpp > > Same comment about the other rename patches: what's the point of > dropping the "brw_"? Eventually, these are going to move to src/intel/blorp. When they do, the blorp prefix will be sufficient. At the moment, it makes it clear that they're is little to nothing brw about them (hence the distinction between brw_blorp.c and blorp.c in patch 25) and avoids the annoying dependency issues of renaming a fine from .c to .cpp. --Jason