On Jul 28, 2016 2:41 AM, "Pohjolainen, Topi" <<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.com</a>> wrote: > > On Tue, Jul 26, 2016 at 03:02:16PM -0700, Jason Ekstrand wrote: > > The sampling hardware can handle them ok. It just looks at the tiling to > > determine whether it's the new gen9 1-D layout or the old one. The render > > hardware isn't so smart. > > To clarify, this is not needed at this point but prepares for the upcoming > patches (i.e, prevents regression there)? Yup. When we start using the actual surf with min lod and stay layer, 1-D depth surfaces become a bit of a problem. > > --- > > src/mesa/drivers/dri/i965/brw_blorp.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c > > index d9b5554..2cf0f99 100644 > > --- a/src/mesa/drivers/dri/i965/brw_blorp.c > > +++ b/src/mesa/drivers/dri/i965/brw_blorp.c > > @@ -371,6 +371,12 @@ brw_blorp_emit_surface_state(struct brw_context *brw, > > > > struct isl_surf surf = surface->surf; > > > > + if (surf.dim == ISL_SURF_DIM_1D && > > + surf.dim_layout == ISL_DIM_LAYOUT_GEN4_2D) { > > + assert(surf.logical_level0_px.height == 1); > > + surf.dim = ISL_SURF_DIM_2D; > > + } > > + > > union isl_color_value clear_color = { .u32 = { 0, 0, 0, 0 } }; > > > > const struct isl_surf *aux_surf = NULL; > > -- > > 2.5.0.400.gff86faf > > > > _______________________________________________ > > mesa-dev mailing list > > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> > > <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a>