<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 28, 2016 at 11:58 AM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Please fix gen7 while you're at it. It probably needs the exact same change. With that,</p></blockquote><div><span style="font-family:verdana,sans-serif">gen7 needs multisample support before we can test sample shading. I</span><br></div><div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small;display:inline">talked to Nanley about it and now working on fixing gen7 multisampling.</div></div><div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small;display:inline">I'll add sample shading bits after that.</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<p dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></p><div class="HOEnZb"><div class="h5">
<div class="gmail_extra"><br><div class="gmail_quote">On Jul 28, 2016 1:31 PM, "Anuj Phogat" <<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We should use the persample_dispatch variable in prog_data.<br>
<br>
Fixes all (~60) the DEQP sample shading tests. Many tests exited with<br>
VK_ERROR_OUT_OF_DEVICE_MEMORY without this patch.<br>
<br>
V2: Use the shader key bits set in brw_compile_fs (Jason)<br>
<br>
Cc: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>><br>
Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>><br>
---<br>
src/intel/vulkan/gen8_pipeline.c | 5 +----<br>
1 file changed, 1 insertion(+), 4 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/gen8_pipeline.c b/src/intel/vulkan/gen8_pipeline.c<br>
index cc10d3a..67ffca6 100644<br>
--- a/src/intel/vulkan/gen8_pipeline.c<br>
+++ b/src/intel/vulkan/gen8_pipeline.c<br>
@@ -365,16 +365,13 @@ genX(graphics_pipeline_create)(<br>
wm_prog_data->dispatch_grf_start_reg_2;<br>
}<br>
<br>
- bool per_sample_ps = pCreateInfo->pMultisampleState &&<br>
- pCreateInfo->pMultisampleState->sampleShadingEnable;<br>
-<br>
anv_batch_emit(&pipeline->batch, GENX(3DSTATE_PS_EXTRA), ps) {<br>
ps.PixelShaderValid = true;<br>
ps.PixelShaderKillsPixel = wm_prog_data->uses_kill;<br>
ps.PixelShaderComputedDepthMode = wm_prog_data->computed_depth_mode;<br>
ps.AttributeEnable = wm_prog_data->num_varying_inputs > 0;<br>
ps.oMaskPresenttoRenderTarget = wm_prog_data->uses_omask;<br>
- ps.PixelShaderIsPerSample = per_sample_ps;<br>
+ ps.PixelShaderIsPerSample = wm_prog_data->persample_dispatch;<br>
ps.PixelShaderUsesSourceDepth = wm_prog_data->uses_src_depth;<br>
ps.PixelShaderUsesSourceW = wm_prog_data->uses_src_w;<br>
#if GEN_GEN >= 9<br>
--<br>
2.5.5<br>
<br>
</blockquote></div></div>
</div></div></blockquote></div><br></div></div>