<p dir="ltr">On Aug 1, 2016 12:35 PM, "Kenneth Graunke" <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> wrote:<br>
><br>
> One less set of enums.  s/BRW_SURFACEFORMAT/ISL_FORMAT/g plus<br>
> some captialization fixes for ASTC formats.</p>
<p dir="ltr">I really like this change but I'm a bit concerned with conflicting with all of the blorp changes I have in flight.</p>
<p dir="ltr">> Signed-off-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>><br>
> ---<br>
>  src/mesa/drivers/dri/i965/brw_binding_tables.c    |   2 +-<br>
>  src/mesa/drivers/dri/i965/brw_blorp.c             |  12 +-<br>
>  src/mesa/drivers/dri/i965/brw_blorp.h             |   2 +-<br>
>  src/mesa/drivers/dri/i965/brw_blorp_blit.cpp      |   2 +-<br>
>  src/mesa/drivers/dri/i965/brw_defines.h           | 247 ---------------<br>
>  src/mesa/drivers/dri/i965/brw_draw_upload.c       | 224 ++++++-------<br>
>  src/mesa/drivers/dri/i965/brw_surface_formats.c   | 366 +++++++++++-----------<br>
>  src/mesa/drivers/dri/i965/brw_wm_surface_state.c  |  48 +--<br>
>  src/mesa/drivers/dri/i965/gen6_blorp.c            |   6 +-<br>
>  src/mesa/drivers/dri/i965/gen7_cs_state.c         |   2 +-<br>
>  src/mesa/drivers/dri/i965/gen7_wm_surface_state.c |  10 +-<br>
>  src/mesa/drivers/dri/i965/gen8_draw_upload.c      |  14 +-<br>
>  src/mesa/drivers/dri/i965/gen8_surface_state.c    |   2 +-<br>
>  13 files changed, 345 insertions(+), 592 deletions(-)<br>
><br>
> diff --git a/src/mesa/drivers/dri/i965/brw_binding_tables.c b/src/mesa/drivers/dri/i965/brw_binding_tables.c<br>
> index 9ca841a..7a33002 100644<br>
> --- a/src/mesa/drivers/dri/i965/brw_binding_tables.c<br>
> +++ b/src/mesa/drivers/dri/i965/brw_binding_tables.c<br>
> @@ -103,7 +103,7 @@ brw_upload_binding_table(struct brw_context *brw,<br>
>           brw_emit_buffer_surface_state(<br>
>              brw, &stage_state->surf_offset[<br>
>                      prog_data->binding_table.shader_time_start],<br>
> -            brw-><a href="http://shader_time.bo">shader_time.bo</a>, 0, BRW_SURFACEFORMAT_RAW,<br>
> +            brw-><a href="http://shader_time.bo">shader_time.bo</a>, 0, ISL_FORMAT_RAW,<br>
>              brw->shader_time.bo->size, 1, true);<br>
>        }<br>
>        /* When RS is enabled use hw-binding table uploads, otherwise fallback to<br>
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c<br>
> index 282a5b2..c93d40e 100644<br>
> --- a/src/mesa/drivers/dri/i965/brw_blorp.c<br>
> +++ b/src/mesa/drivers/dri/i965/brw_blorp.c<br>
> @@ -75,11 +75,11 @@ brw_blorp_surface_info_init(struct brw_context *brw,<br>
>         * program swizzle the coordinates.<br>
>         */<br>
>        info->map_stencil_as_y_tiled = true;<br>
> -      info->brw_surfaceformat = brw->gen >= 8 ? BRW_SURFACEFORMAT_R8_UINT :<br>
> -                                                BRW_SURFACEFORMAT_R8_UNORM;<br>
> +      info->brw_surfaceformat = brw->gen >= 8 ? ISL_FORMAT_R8_UINT :<br>
> +                                                ISL_FORMAT_R8_UNORM;<br>
>        break;<br>
>     case MESA_FORMAT_Z24_UNORM_X8_UINT:<br>
> -      /* It would make sense to use BRW_SURFACEFORMAT_R24_UNORM_X8_TYPELESS<br>
> +      /* It would make sense to use ISL_FORMAT_R24_UNORM_X8_TYPELESS<br>
>         * here, but unfortunately it isn't supported as a render target, which<br>
>         * would prevent us from blitting to 24-bit depth.<br>
>         *<br>
> @@ -89,13 +89,13 @@ brw_blorp_surface_info_init(struct brw_context *brw,<br>
>         * pattern as long as we copy the right amount of data, so just map it<br>
>         * as 8-bit BGRA.<br>
>         */<br>
> -      info->brw_surfaceformat = BRW_SURFACEFORMAT_B8G8R8A8_UNORM;<br>
> +      info->brw_surfaceformat = ISL_FORMAT_B8G8R8A8_UNORM;<br>
>        break;<br>
>     case MESA_FORMAT_Z_FLOAT32:<br>
> -      info->brw_surfaceformat = BRW_SURFACEFORMAT_R32_FLOAT;<br>
> +      info->brw_surfaceformat = ISL_FORMAT_R32_FLOAT;<br>
>        break;<br>
>     case MESA_FORMAT_Z_UNORM16:<br>
> -      info->brw_surfaceformat = BRW_SURFACEFORMAT_R16_UNORM;<br>
> +      info->brw_surfaceformat = ISL_FORMAT_R16_UNORM;<br>
>        break;<br>
>     default: {<br>
>        if (is_render_target) {<br>
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp.h b/src/mesa/drivers/dri/i965/brw_blorp.h<br>
> index beef90e..7318690 100644<br>
> --- a/src/mesa/drivers/dri/i965/brw_blorp.h<br>
> +++ b/src/mesa/drivers/dri/i965/brw_blorp.h<br>
> @@ -141,7 +141,7 @@ struct brw_blorp_surface_info<br>
><br>
>     /**<br>
>      * Format that should be used when setting up the surface state for this<br>
> -    * surface.  Should correspond to one of the BRW_SURFACEFORMAT_* enums.<br>
> +    * surface.  Should correspond to one of the ISL_FORMAT_* enums.<br>
>      */<br>
>     uint32_t brw_surfaceformat;<br>
><br>
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp<br>
> index a54680e..a1efbb8 100644<br>
> --- a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp<br>
> +++ b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp<br>
> @@ -1695,7 +1695,7 @@ brw_blorp_blit_miptrees(struct brw_context *brw,<br>
>     if (brw->gen == 6 &&<br>
>         params.src.num_samples > 1 && params.dst.num_samples <= 1 &&<br>
>         src_mt->format == dst_mt->format &&<br>
> -       params.dst.brw_surfaceformat == BRW_SURFACEFORMAT_R32_FLOAT) {<br>
> +       params.dst.brw_surfaceformat == ISL_FORMAT_R32_FLOAT) {<br>
>        params.src.brw_surfaceformat = params.dst.brw_surfaceformat;<br>
>     }<br>
><br>
> diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h<br>
> index 2814fa7..67a00ef 100644<br>
> --- a/src/mesa/drivers/dri/i965/brw_defines.h<br>
> +++ b/src/mesa/drivers/dri/i965/brw_defines.h<br>
> @@ -296,255 +296,8 @@<br>
>  #define BRW_SURFACE_WRITEDISABLE_R_SHIFT       16<br>
>  #define BRW_SURFACE_WRITEDISABLE_A_SHIFT       17<br>
><br>
> -#define BRW_SURFACEFORMAT_R32G32B32A32_FLOAT             0x000<br>
> -#define BRW_SURFACEFORMAT_R32G32B32A32_SINT              0x001<br>
> -#define BRW_SURFACEFORMAT_R32G32B32A32_UINT              0x002<br>
> -#define BRW_SURFACEFORMAT_R32G32B32A32_UNORM             0x003<br>
> -#define BRW_SURFACEFORMAT_R32G32B32A32_SNORM             0x004<br>
> -#define BRW_SURFACEFORMAT_R64G64_FLOAT                   0x005<br>
> -#define BRW_SURFACEFORMAT_R32G32B32X32_FLOAT             0x006<br>
> -#define BRW_SURFACEFORMAT_R32G32B32A32_SSCALED           0x007<br>
> -#define BRW_SURFACEFORMAT_R32G32B32A32_USCALED           0x008<br>
> -#define BRW_SURFACEFORMAT_R32G32B32A32_SFIXED            0x020<br>
> -#define BRW_SURFACEFORMAT_R64G64_PASSTHRU                0x021<br>
> -#define BRW_SURFACEFORMAT_R32G32B32_FLOAT                0x040<br>
> -#define BRW_SURFACEFORMAT_R32G32B32_SINT                 0x041<br>
> -#define BRW_SURFACEFORMAT_R32G32B32_UINT                 0x042<br>
> -#define BRW_SURFACEFORMAT_R32G32B32_UNORM                0x043<br>
> -#define BRW_SURFACEFORMAT_R32G32B32_SNORM                0x044<br>
> -#define BRW_SURFACEFORMAT_R32G32B32_SSCALED              0x045<br>
> -#define BRW_SURFACEFORMAT_R32G32B32_USCALED              0x046<br>
> -#define BRW_SURFACEFORMAT_R32G32B32_SFIXED               0x050<br>
> -#define BRW_SURFACEFORMAT_R16G16B16A16_UNORM             0x080<br>
> -#define BRW_SURFACEFORMAT_R16G16B16A16_SNORM             0x081<br>
> -#define BRW_SURFACEFORMAT_R16G16B16A16_SINT              0x082<br>
> -#define BRW_SURFACEFORMAT_R16G16B16A16_UINT              0x083<br>
> -#define BRW_SURFACEFORMAT_R16G16B16A16_FLOAT             0x084<br>
> -#define BRW_SURFACEFORMAT_R32G32_FLOAT                   0x085<br>
> -#define BRW_SURFACEFORMAT_R32G32_SINT                    0x086<br>
> -#define BRW_SURFACEFORMAT_R32G32_UINT                    0x087<br>
> -#define BRW_SURFACEFORMAT_R32_FLOAT_X8X24_TYPELESS       0x088<br>
> -#define BRW_SURFACEFORMAT_X32_TYPELESS_G8X24_UINT        0x089<br>
> -#define BRW_SURFACEFORMAT_L32A32_FLOAT                   0x08A<br>
> -#define BRW_SURFACEFORMAT_R32G32_UNORM                   0x08B<br>
> -#define BRW_SURFACEFORMAT_R32G32_SNORM                   0x08C<br>
> -#define BRW_SURFACEFORMAT_R64_FLOAT                      0x08D<br>
> -#define BRW_SURFACEFORMAT_R16G16B16X16_UNORM             0x08E<br>
> -#define BRW_SURFACEFORMAT_R16G16B16X16_FLOAT             0x08F<br>
> -#define BRW_SURFACEFORMAT_A32X32_FLOAT                   0x090<br>
> -#define BRW_SURFACEFORMAT_L32X32_FLOAT                   0x091<br>
> -#define BRW_SURFACEFORMAT_I32X32_FLOAT                   0x092<br>
> -#define BRW_SURFACEFORMAT_R16G16B16A16_SSCALED           0x093<br>
> -#define BRW_SURFACEFORMAT_R16G16B16A16_USCALED           0x094<br>
> -#define BRW_SURFACEFORMAT_R32G32_SSCALED                 0x095<br>
> -#define BRW_SURFACEFORMAT_R32G32_USCALED                 0x096<br>
> -#define BRW_SURFACEFORMAT_R32G32_FLOAT_LD                0x097<br>
> -#define BRW_SURFACEFORMAT_R32G32_SFIXED                  0x0A0<br>
> -#define BRW_SURFACEFORMAT_R64_PASSTHRU                   0x0A1<br>
> -#define BRW_SURFACEFORMAT_B8G8R8A8_UNORM                 0x0C0<br>
> -#define BRW_SURFACEFORMAT_B8G8R8A8_UNORM_SRGB            0x0C1<br>
> -#define BRW_SURFACEFORMAT_R10G10B10A2_UNORM              0x0C2<br>
> -#define BRW_SURFACEFORMAT_R10G10B10A2_UNORM_SRGB         0x0C3<br>
> -#define BRW_SURFACEFORMAT_R10G10B10A2_UINT               0x0C4<br>
> -#define BRW_SURFACEFORMAT_R10G10B10_SNORM_A2_UNORM       0x0C5<br>
> -#define BRW_SURFACEFORMAT_R8G8B8A8_UNORM                 0x0C7<br>
> -#define BRW_SURFACEFORMAT_R8G8B8A8_UNORM_SRGB            0x0C8<br>
> -#define BRW_SURFACEFORMAT_R8G8B8A8_SNORM                 0x0C9<br>
> -#define BRW_SURFACEFORMAT_R8G8B8A8_SINT                  0x0CA<br>
> -#define BRW_SURFACEFORMAT_R8G8B8A8_UINT                  0x0CB<br>
> -#define BRW_SURFACEFORMAT_R16G16_UNORM                   0x0CC<br>
> -#define BRW_SURFACEFORMAT_R16G16_SNORM                   0x0CD<br>
> -#define BRW_SURFACEFORMAT_R16G16_SINT                    0x0CE<br>
> -#define BRW_SURFACEFORMAT_R16G16_UINT                    0x0CF<br>
> -#define BRW_SURFACEFORMAT_R16G16_FLOAT                   0x0D0<br>
> -#define BRW_SURFACEFORMAT_B10G10R10A2_UNORM              0x0D1<br>
> -#define BRW_SURFACEFORMAT_B10G10R10A2_UNORM_SRGB         0x0D2<br>
> -#define BRW_SURFACEFORMAT_R11G11B10_FLOAT                0x0D3<br>
> -#define BRW_SURFACEFORMAT_R32_SINT                       0x0D6<br>
> -#define BRW_SURFACEFORMAT_R32_UINT                       0x0D7<br>
> -#define BRW_SURFACEFORMAT_R32_FLOAT                      0x0D8<br>
> -#define BRW_SURFACEFORMAT_R24_UNORM_X8_TYPELESS          0x0D9<br>
> -#define BRW_SURFACEFORMAT_X24_TYPELESS_G8_UINT           0x0DA<br>
> -#define BRW_SURFACEFORMAT_L16A16_UNORM                   0x0DF<br>
> -#define BRW_SURFACEFORMAT_I24X8_UNORM                    0x0E0<br>
> -#define BRW_SURFACEFORMAT_L24X8_UNORM                    0x0E1<br>
> -#define BRW_SURFACEFORMAT_A24X8_UNORM                    0x0E2<br>
> -#define BRW_SURFACEFORMAT_I32_FLOAT                      0x0E3<br>
> -#define BRW_SURFACEFORMAT_L32_FLOAT                      0x0E4<br>
> -#define BRW_SURFACEFORMAT_A32_FLOAT                      0x0E5<br>
> -#define BRW_SURFACEFORMAT_B8G8R8X8_UNORM                 0x0E9<br>
> -#define BRW_SURFACEFORMAT_B8G8R8X8_UNORM_SRGB            0x0EA<br>
> -#define BRW_SURFACEFORMAT_R8G8B8X8_UNORM                 0x0EB<br>
> -#define BRW_SURFACEFORMAT_R8G8B8X8_UNORM_SRGB            0x0EC<br>
> -#define BRW_SURFACEFORMAT_R9G9B9E5_SHAREDEXP             0x0ED<br>
> -#define BRW_SURFACEFORMAT_B10G10R10X2_UNORM              0x0EE<br>
> -#define BRW_SURFACEFORMAT_L16A16_FLOAT                   0x0F0<br>
> -#define BRW_SURFACEFORMAT_R32_UNORM                      0x0F1<br>
> -#define BRW_SURFACEFORMAT_R32_SNORM                      0x0F2<br>
> -#define BRW_SURFACEFORMAT_R10G10B10X2_USCALED            0x0F3<br>
> -#define BRW_SURFACEFORMAT_R8G8B8A8_SSCALED               0x0F4<br>
> -#define BRW_SURFACEFORMAT_R8G8B8A8_USCALED               0x0F5<br>
> -#define BRW_SURFACEFORMAT_R16G16_SSCALED                 0x0F6<br>
> -#define BRW_SURFACEFORMAT_R16G16_USCALED                 0x0F7<br>
> -#define BRW_SURFACEFORMAT_R32_SSCALED                    0x0F8<br>
> -#define BRW_SURFACEFORMAT_R32_USCALED                    0x0F9<br>
> -#define BRW_SURFACEFORMAT_B5G6R5_UNORM                   0x100<br>
> -#define BRW_SURFACEFORMAT_B5G6R5_UNORM_SRGB              0x101<br>
> -#define BRW_SURFACEFORMAT_B5G5R5A1_UNORM                 0x102<br>
> -#define BRW_SURFACEFORMAT_B5G5R5A1_UNORM_SRGB            0x103<br>
> -#define BRW_SURFACEFORMAT_B4G4R4A4_UNORM                 0x104<br>
> -#define BRW_SURFACEFORMAT_B4G4R4A4_UNORM_SRGB            0x105<br>
> -#define BRW_SURFACEFORMAT_R8G8_UNORM                     0x106<br>
> -#define BRW_SURFACEFORMAT_R8G8_SNORM                     0x107<br>
> -#define BRW_SURFACEFORMAT_R8G8_SINT                      0x108<br>
> -#define BRW_SURFACEFORMAT_R8G8_UINT                      0x109<br>
> -#define BRW_SURFACEFORMAT_R16_UNORM                      0x10A<br>
> -#define BRW_SURFACEFORMAT_R16_SNORM                      0x10B<br>
> -#define BRW_SURFACEFORMAT_R16_SINT                       0x10C<br>
> -#define BRW_SURFACEFORMAT_R16_UINT                       0x10D<br>
> -#define BRW_SURFACEFORMAT_R16_FLOAT                      0x10E<br>
> -#define BRW_SURFACEFORMAT_A8P8_UNORM_PALETTE0            0x10F<br>
> -#define BRW_SURFACEFORMAT_A8P8_UNORM_PALETTE1            0x110<br>
> -#define BRW_SURFACEFORMAT_I16_UNORM                      0x111<br>
> -#define BRW_SURFACEFORMAT_L16_UNORM                      0x112<br>
> -#define BRW_SURFACEFORMAT_A16_UNORM                      0x113<br>
> -#define BRW_SURFACEFORMAT_L8A8_UNORM                     0x114<br>
> -#define BRW_SURFACEFORMAT_I16_FLOAT                      0x115<br>
> -#define BRW_SURFACEFORMAT_L16_FLOAT                      0x116<br>
> -#define BRW_SURFACEFORMAT_A16_FLOAT                      0x117<br>
> -#define BRW_SURFACEFORMAT_L8A8_UNORM_SRGB                0x118<br>
> -#define BRW_SURFACEFORMAT_R5G5_SNORM_B6_UNORM            0x119<br>
> -#define BRW_SURFACEFORMAT_B5G5R5X1_UNORM                 0x11A<br>
> -#define BRW_SURFACEFORMAT_B5G5R5X1_UNORM_SRGB            0x11B<br>
> -#define BRW_SURFACEFORMAT_R8G8_SSCALED                   0x11C<br>
> -#define BRW_SURFACEFORMAT_R8G8_USCALED                   0x11D<br>
> -#define BRW_SURFACEFORMAT_R16_SSCALED                    0x11E<br>
> -#define BRW_SURFACEFORMAT_R16_USCALED                    0x11F<br>
> -#define BRW_SURFACEFORMAT_P8A8_UNORM_PALETTE0            0x122<br>
> -#define BRW_SURFACEFORMAT_P8A8_UNORM_PALETTE1            0x123<br>
> -#define BRW_SURFACEFORMAT_A1B5G5R5_UNORM                 0x124<br>
> -#define BRW_SURFACEFORMAT_A4B4G4R4_UNORM                 0x125<br>
> -#define BRW_SURFACEFORMAT_L8A8_UINT                      0x126<br>
> -#define BRW_SURFACEFORMAT_L8A8_SINT                      0x127<br>
> -#define BRW_SURFACEFORMAT_R8_UNORM                       0x140<br>
> -#define BRW_SURFACEFORMAT_R8_SNORM                       0x141<br>
> -#define BRW_SURFACEFORMAT_R8_SINT                        0x142<br>
> -#define BRW_SURFACEFORMAT_R8_UINT                        0x143<br>
> -#define BRW_SURFACEFORMAT_A8_UNORM                       0x144<br>
> -#define BRW_SURFACEFORMAT_I8_UNORM                       0x145<br>
> -#define BRW_SURFACEFORMAT_L8_UNORM                       0x146<br>
> -#define BRW_SURFACEFORMAT_P4A4_UNORM                     0x147<br>
> -#define BRW_SURFACEFORMAT_A4P4_UNORM                     0x148<br>
> -#define BRW_SURFACEFORMAT_R8_SSCALED                     0x149<br>
> -#define BRW_SURFACEFORMAT_R8_USCALED                     0x14A<br>
> -#define BRW_SURFACEFORMAT_P8_UNORM_PALETTE0              0x14B<br>
> -#define BRW_SURFACEFORMAT_L8_UNORM_SRGB                  0x14C<br>
> -#define BRW_SURFACEFORMAT_P8_UNORM_PALETTE1              0x14D<br>
> -#define BRW_SURFACEFORMAT_P4A4_UNORM_PALETTE1            0x14E<br>
> -#define BRW_SURFACEFORMAT_A4P4_UNORM_PALETTE1            0x14F<br>
> -#define BRW_SURFACEFORMAT_Y8_SNORM                       0x150<br>
> -#define BRW_SURFACEFORMAT_L8_UINT                        0x152<br>
> -#define BRW_SURFACEFORMAT_L8_SINT                        0x153<br>
> -#define BRW_SURFACEFORMAT_I8_UINT                        0x154<br>
> -#define BRW_SURFACEFORMAT_I8_SINT                        0x155<br>
> -#define BRW_SURFACEFORMAT_DXT1_RGB_SRGB                  0x180<br>
> -#define BRW_SURFACEFORMAT_R1_UINT                        0x181<br>
> -#define BRW_SURFACEFORMAT_YCRCB_NORMAL                   0x182<br>
> -#define BRW_SURFACEFORMAT_YCRCB_SWAPUVY                  0x183<br>
> -#define BRW_SURFACEFORMAT_P2_UNORM_PALETTE0              0x184<br>
> -#define BRW_SURFACEFORMAT_P2_UNORM_PALETTE1              0x185<br>
> -#define BRW_SURFACEFORMAT_BC1_UNORM                      0x186<br>
> -#define BRW_SURFACEFORMAT_BC2_UNORM                      0x187<br>
> -#define BRW_SURFACEFORMAT_BC3_UNORM                      0x188<br>
> -#define BRW_SURFACEFORMAT_BC4_UNORM                      0x189<br>
> -#define BRW_SURFACEFORMAT_BC5_UNORM                      0x18A<br>
> -#define BRW_SURFACEFORMAT_BC1_UNORM_SRGB                 0x18B<br>
> -#define BRW_SURFACEFORMAT_BC2_UNORM_SRGB                 0x18C<br>
> -#define BRW_SURFACEFORMAT_BC3_UNORM_SRGB                 0x18D<br>
> -#define BRW_SURFACEFORMAT_MONO8                          0x18E<br>
> -#define BRW_SURFACEFORMAT_YCRCB_SWAPUV                   0x18F<br>
> -#define BRW_SURFACEFORMAT_YCRCB_SWAPY                    0x190<br>
> -#define BRW_SURFACEFORMAT_DXT1_RGB                       0x191<br>
> -#define BRW_SURFACEFORMAT_FXT1                           0x192<br>
> -#define BRW_SURFACEFORMAT_R8G8B8_UNORM                   0x193<br>
> -#define BRW_SURFACEFORMAT_R8G8B8_SNORM                   0x194<br>
> -#define BRW_SURFACEFORMAT_R8G8B8_SSCALED                 0x195<br>
> -#define BRW_SURFACEFORMAT_R8G8B8_USCALED                 0x196<br>
> -#define BRW_SURFACEFORMAT_R64G64B64A64_FLOAT             0x197<br>
> -#define BRW_SURFACEFORMAT_R64G64B64_FLOAT                0x198<br>
> -#define BRW_SURFACEFORMAT_BC4_SNORM                      0x199<br>
> -#define BRW_SURFACEFORMAT_BC5_SNORM                      0x19A<br>
> -#define BRW_SURFACEFORMAT_R16G16B16_FLOAT                0x19B<br>
> -#define BRW_SURFACEFORMAT_R16G16B16_UNORM                0x19C<br>
> -#define BRW_SURFACEFORMAT_R16G16B16_SNORM                0x19D<br>
> -#define BRW_SURFACEFORMAT_R16G16B16_SSCALED              0x19E<br>
> -#define BRW_SURFACEFORMAT_R16G16B16_USCALED              0x19F<br>
> -#define BRW_SURFACEFORMAT_BC6H_SF16                      0x1A1<br>
> -#define BRW_SURFACEFORMAT_BC7_UNORM                      0x1A2<br>
> -#define BRW_SURFACEFORMAT_BC7_UNORM_SRGB                 0x1A3<br>
> -#define BRW_SURFACEFORMAT_BC6H_UF16                      0x1A4<br>
> -#define BRW_SURFACEFORMAT_PLANAR_420_8                   0x1A5<br>
> -#define BRW_SURFACEFORMAT_R8G8B8_UNORM_SRGB              0x1A8<br>
> -#define BRW_SURFACEFORMAT_ETC1_RGB8                      0x1A9<br>
> -#define BRW_SURFACEFORMAT_ETC2_RGB8                      0x1AA<br>
> -#define BRW_SURFACEFORMAT_EAC_R11                        0x1AB<br>
> -#define BRW_SURFACEFORMAT_EAC_RG11                       0x1AC<br>
> -#define BRW_SURFACEFORMAT_EAC_SIGNED_R11                 0x1AD<br>
> -#define BRW_SURFACEFORMAT_EAC_SIGNED_RG11                0x1AE<br>
> -#define BRW_SURFACEFORMAT_ETC2_SRGB8                     0x1AF<br>
> -#define BRW_SURFACEFORMAT_R16G16B16_UINT                 0x1B0<br>
> -#define BRW_SURFACEFORMAT_R16G16B16_SINT                 0x1B1<br>
> -#define BRW_SURFACEFORMAT_R32_SFIXED                     0x1B2<br>
> -#define BRW_SURFACEFORMAT_R10G10B10A2_SNORM              0x1B3<br>
> -#define BRW_SURFACEFORMAT_R10G10B10A2_USCALED            0x1B4<br>
> -#define BRW_SURFACEFORMAT_R10G10B10A2_SSCALED            0x1B5<br>
> -#define BRW_SURFACEFORMAT_R10G10B10A2_SINT               0x1B6<br>
> -#define BRW_SURFACEFORMAT_B10G10R10A2_SNORM              0x1B7<br>
> -#define BRW_SURFACEFORMAT_B10G10R10A2_USCALED            0x1B8<br>
> -#define BRW_SURFACEFORMAT_B10G10R10A2_SSCALED            0x1B9<br>
> -#define BRW_SURFACEFORMAT_B10G10R10A2_UINT               0x1BA<br>
> -#define BRW_SURFACEFORMAT_B10G10R10A2_SINT               0x1BB<br>
> -#define BRW_SURFACEFORMAT_R64G64B64A64_PASSTHRU          0x1BC<br>
> -#define BRW_SURFACEFORMAT_R64G64B64_PASSTHRU             0x1BD<br>
> -#define BRW_SURFACEFORMAT_ETC2_RGB8_PTA                  0x1C0<br>
> -#define BRW_SURFACEFORMAT_ETC2_SRGB8_PTA                 0x1C1<br>
> -#define BRW_SURFACEFORMAT_ETC2_EAC_RGBA8                 0x1C2<br>
> -#define BRW_SURFACEFORMAT_ETC2_EAC_SRGB8_A8              0x1C3<br>
> -#define BRW_SURFACEFORMAT_R8G8B8_UINT                    0x1C8<br>
> -#define BRW_SURFACEFORMAT_R8G8B8_SINT                    0x1C9<br>
> -#define BRW_SURFACEFORMAT_RAW                            0x1FF<br>
> -<br>
>  #define GEN9_SURFACE_ASTC_HDR_FORMAT_BIT                 0x100<br>
><br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_4x4_U8sRGB         0x200<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_5x4_U8sRGB         0x208<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_5x5_U8sRGB         0x209<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_6x5_U8sRGB         0x211<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_6x6_U8sRGB         0x212<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_8x5_U8sRGB         0x221<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_8x6_U8sRGB         0x222<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_8x8_U8sRGB         0x224<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_10x5_U8sRGB        0x231<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_10x6_U8sRGB        0x232<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_10x8_U8sRGB        0x234<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_10x10_U8sRGB       0x236<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_12x10_U8sRGB       0x23E<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_12x12_U8sRGB       0x23F<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_4x4_FLT16          0x240<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_5x4_FLT16          0x248<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_5x5_FLT16          0x249<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_6x5_FLT16          0x251<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_6x6_FLT16          0x252<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_8x5_FLT16          0x261<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_8x6_FLT16          0x262<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_8x8_FLT16          0x264<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_10x5_FLT16         0x271<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_10x6_FLT16         0x272<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_10x8_FLT16         0x274<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_10x10_FLT16        0x276<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_12x10_FLT16        0x27E<br>
> -#define BRW_SURFACEFORMAT_ASTC_LDR_2D_12x12_FLT16        0x27F<br>
> -<br>
>  #define BRW_SURFACE_FORMAT_SHIFT       18<br>
>  #define BRW_SURFACE_FORMAT_MASK                INTEL_MASK(26, 18)<br>
><br>
> diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c b/src/mesa/drivers/dri/i965/brw_draw_upload.c<br>
> index fdb1b35..6b950a5 100644<br>
> --- a/src/mesa/drivers/dri/i965/brw_draw_upload.c<br>
> +++ b/src/mesa/drivers/dri/i965/brw_draw_upload.c<br>
> @@ -39,186 +39,186 @@<br>
><br>
>  static const GLuint double_types_float[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R64_FLOAT,<br>
> -   BRW_SURFACEFORMAT_R64G64_FLOAT,<br>
> -   BRW_SURFACEFORMAT_R64G64B64_FLOAT,<br>
> -   BRW_SURFACEFORMAT_R64G64B64A64_FLOAT<br>
> +   ISL_FORMAT_R64_FLOAT,<br>
> +   ISL_FORMAT_R64G64_FLOAT,<br>
> +   ISL_FORMAT_R64G64B64_FLOAT,<br>
> +   ISL_FORMAT_R64G64B64A64_FLOAT<br>
>  };<br>
><br>
>  static const GLuint double_types_passthru[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R64_PASSTHRU,<br>
> -   BRW_SURFACEFORMAT_R64G64_PASSTHRU,<br>
> -   BRW_SURFACEFORMAT_R64G64B64_PASSTHRU,<br>
> -   BRW_SURFACEFORMAT_R64G64B64A64_PASSTHRU<br>
> +   ISL_FORMAT_R64_PASSTHRU,<br>
> +   ISL_FORMAT_R64G64_PASSTHRU,<br>
> +   ISL_FORMAT_R64G64B64_PASSTHRU,<br>
> +   ISL_FORMAT_R64G64B64A64_PASSTHRU<br>
>  };<br>
><br>
>  static const GLuint float_types[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R32_FLOAT,<br>
> -   BRW_SURFACEFORMAT_R32G32_FLOAT,<br>
> -   BRW_SURFACEFORMAT_R32G32B32_FLOAT,<br>
> -   BRW_SURFACEFORMAT_R32G32B32A32_FLOAT<br>
> +   ISL_FORMAT_R32_FLOAT,<br>
> +   ISL_FORMAT_R32G32_FLOAT,<br>
> +   ISL_FORMAT_R32G32B32_FLOAT,<br>
> +   ISL_FORMAT_R32G32B32A32_FLOAT<br>
>  };<br>
><br>
>  static const GLuint half_float_types[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R16_FLOAT,<br>
> -   BRW_SURFACEFORMAT_R16G16_FLOAT,<br>
> -   BRW_SURFACEFORMAT_R16G16B16_FLOAT,<br>
> -   BRW_SURFACEFORMAT_R16G16B16A16_FLOAT<br>
> +   ISL_FORMAT_R16_FLOAT,<br>
> +   ISL_FORMAT_R16G16_FLOAT,<br>
> +   ISL_FORMAT_R16G16B16_FLOAT,<br>
> +   ISL_FORMAT_R16G16B16A16_FLOAT<br>
>  };<br>
><br>
>  static const GLuint fixed_point_types[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R32_SFIXED,<br>
> -   BRW_SURFACEFORMAT_R32G32_SFIXED,<br>
> -   BRW_SURFACEFORMAT_R32G32B32_SFIXED,<br>
> -   BRW_SURFACEFORMAT_R32G32B32A32_SFIXED,<br>
> +   ISL_FORMAT_R32_SFIXED,<br>
> +   ISL_FORMAT_R32G32_SFIXED,<br>
> +   ISL_FORMAT_R32G32B32_SFIXED,<br>
> +   ISL_FORMAT_R32G32B32A32_SFIXED,<br>
>  };<br>
><br>
>  static const GLuint uint_types_direct[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R32_UINT,<br>
> -   BRW_SURFACEFORMAT_R32G32_UINT,<br>
> -   BRW_SURFACEFORMAT_R32G32B32_UINT,<br>
> -   BRW_SURFACEFORMAT_R32G32B32A32_UINT<br>
> +   ISL_FORMAT_R32_UINT,<br>
> +   ISL_FORMAT_R32G32_UINT,<br>
> +   ISL_FORMAT_R32G32B32_UINT,<br>
> +   ISL_FORMAT_R32G32B32A32_UINT<br>
>  };<br>
><br>
>  static const GLuint uint_types_norm[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R32_UNORM,<br>
> -   BRW_SURFACEFORMAT_R32G32_UNORM,<br>
> -   BRW_SURFACEFORMAT_R32G32B32_UNORM,<br>
> -   BRW_SURFACEFORMAT_R32G32B32A32_UNORM<br>
> +   ISL_FORMAT_R32_UNORM,<br>
> +   ISL_FORMAT_R32G32_UNORM,<br>
> +   ISL_FORMAT_R32G32B32_UNORM,<br>
> +   ISL_FORMAT_R32G32B32A32_UNORM<br>
>  };<br>
><br>
>  static const GLuint uint_types_scale[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R32_USCALED,<br>
> -   BRW_SURFACEFORMAT_R32G32_USCALED,<br>
> -   BRW_SURFACEFORMAT_R32G32B32_USCALED,<br>
> -   BRW_SURFACEFORMAT_R32G32B32A32_USCALED<br>
> +   ISL_FORMAT_R32_USCALED,<br>
> +   ISL_FORMAT_R32G32_USCALED,<br>
> +   ISL_FORMAT_R32G32B32_USCALED,<br>
> +   ISL_FORMAT_R32G32B32A32_USCALED<br>
>  };<br>
><br>
>  static const GLuint int_types_direct[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R32_SINT,<br>
> -   BRW_SURFACEFORMAT_R32G32_SINT,<br>
> -   BRW_SURFACEFORMAT_R32G32B32_SINT,<br>
> -   BRW_SURFACEFORMAT_R32G32B32A32_SINT<br>
> +   ISL_FORMAT_R32_SINT,<br>
> +   ISL_FORMAT_R32G32_SINT,<br>
> +   ISL_FORMAT_R32G32B32_SINT,<br>
> +   ISL_FORMAT_R32G32B32A32_SINT<br>
>  };<br>
><br>
>  static const GLuint int_types_norm[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R32_SNORM,<br>
> -   BRW_SURFACEFORMAT_R32G32_SNORM,<br>
> -   BRW_SURFACEFORMAT_R32G32B32_SNORM,<br>
> -   BRW_SURFACEFORMAT_R32G32B32A32_SNORM<br>
> +   ISL_FORMAT_R32_SNORM,<br>
> +   ISL_FORMAT_R32G32_SNORM,<br>
> +   ISL_FORMAT_R32G32B32_SNORM,<br>
> +   ISL_FORMAT_R32G32B32A32_SNORM<br>
>  };<br>
><br>
>  static const GLuint int_types_scale[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R32_SSCALED,<br>
> -   BRW_SURFACEFORMAT_R32G32_SSCALED,<br>
> -   BRW_SURFACEFORMAT_R32G32B32_SSCALED,<br>
> -   BRW_SURFACEFORMAT_R32G32B32A32_SSCALED<br>
> +   ISL_FORMAT_R32_SSCALED,<br>
> +   ISL_FORMAT_R32G32_SSCALED,<br>
> +   ISL_FORMAT_R32G32B32_SSCALED,<br>
> +   ISL_FORMAT_R32G32B32A32_SSCALED<br>
>  };<br>
><br>
>  static const GLuint ushort_types_direct[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R16_UINT,<br>
> -   BRW_SURFACEFORMAT_R16G16_UINT,<br>
> -   BRW_SURFACEFORMAT_R16G16B16_UINT,<br>
> -   BRW_SURFACEFORMAT_R16G16B16A16_UINT<br>
> +   ISL_FORMAT_R16_UINT,<br>
> +   ISL_FORMAT_R16G16_UINT,<br>
> +   ISL_FORMAT_R16G16B16_UINT,<br>
> +   ISL_FORMAT_R16G16B16A16_UINT<br>
>  };<br>
><br>
>  static const GLuint ushort_types_norm[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R16_UNORM,<br>
> -   BRW_SURFACEFORMAT_R16G16_UNORM,<br>
> -   BRW_SURFACEFORMAT_R16G16B16_UNORM,<br>
> -   BRW_SURFACEFORMAT_R16G16B16A16_UNORM<br>
> +   ISL_FORMAT_R16_UNORM,<br>
> +   ISL_FORMAT_R16G16_UNORM,<br>
> +   ISL_FORMAT_R16G16B16_UNORM,<br>
> +   ISL_FORMAT_R16G16B16A16_UNORM<br>
>  };<br>
><br>
>  static const GLuint ushort_types_scale[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R16_USCALED,<br>
> -   BRW_SURFACEFORMAT_R16G16_USCALED,<br>
> -   BRW_SURFACEFORMAT_R16G16B16_USCALED,<br>
> -   BRW_SURFACEFORMAT_R16G16B16A16_USCALED<br>
> +   ISL_FORMAT_R16_USCALED,<br>
> +   ISL_FORMAT_R16G16_USCALED,<br>
> +   ISL_FORMAT_R16G16B16_USCALED,<br>
> +   ISL_FORMAT_R16G16B16A16_USCALED<br>
>  };<br>
><br>
>  static const GLuint short_types_direct[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R16_SINT,<br>
> -   BRW_SURFACEFORMAT_R16G16_SINT,<br>
> -   BRW_SURFACEFORMAT_R16G16B16_SINT,<br>
> -   BRW_SURFACEFORMAT_R16G16B16A16_SINT<br>
> +   ISL_FORMAT_R16_SINT,<br>
> +   ISL_FORMAT_R16G16_SINT,<br>
> +   ISL_FORMAT_R16G16B16_SINT,<br>
> +   ISL_FORMAT_R16G16B16A16_SINT<br>
>  };<br>
><br>
>  static const GLuint short_types_norm[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R16_SNORM,<br>
> -   BRW_SURFACEFORMAT_R16G16_SNORM,<br>
> -   BRW_SURFACEFORMAT_R16G16B16_SNORM,<br>
> -   BRW_SURFACEFORMAT_R16G16B16A16_SNORM<br>
> +   ISL_FORMAT_R16_SNORM,<br>
> +   ISL_FORMAT_R16G16_SNORM,<br>
> +   ISL_FORMAT_R16G16B16_SNORM,<br>
> +   ISL_FORMAT_R16G16B16A16_SNORM<br>
>  };<br>
><br>
>  static const GLuint short_types_scale[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R16_SSCALED,<br>
> -   BRW_SURFACEFORMAT_R16G16_SSCALED,<br>
> -   BRW_SURFACEFORMAT_R16G16B16_SSCALED,<br>
> -   BRW_SURFACEFORMAT_R16G16B16A16_SSCALED<br>
> +   ISL_FORMAT_R16_SSCALED,<br>
> +   ISL_FORMAT_R16G16_SSCALED,<br>
> +   ISL_FORMAT_R16G16B16_SSCALED,<br>
> +   ISL_FORMAT_R16G16B16A16_SSCALED<br>
>  };<br>
><br>
>  static const GLuint ubyte_types_direct[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R8_UINT,<br>
> -   BRW_SURFACEFORMAT_R8G8_UINT,<br>
> -   BRW_SURFACEFORMAT_R8G8B8_UINT,<br>
> -   BRW_SURFACEFORMAT_R8G8B8A8_UINT<br>
> +   ISL_FORMAT_R8_UINT,<br>
> +   ISL_FORMAT_R8G8_UINT,<br>
> +   ISL_FORMAT_R8G8B8_UINT,<br>
> +   ISL_FORMAT_R8G8B8A8_UINT<br>
>  };<br>
><br>
>  static const GLuint ubyte_types_norm[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R8_UNORM,<br>
> -   BRW_SURFACEFORMAT_R8G8_UNORM,<br>
> -   BRW_SURFACEFORMAT_R8G8B8_UNORM,<br>
> -   BRW_SURFACEFORMAT_R8G8B8A8_UNORM<br>
> +   ISL_FORMAT_R8_UNORM,<br>
> +   ISL_FORMAT_R8G8_UNORM,<br>
> +   ISL_FORMAT_R8G8B8_UNORM,<br>
> +   ISL_FORMAT_R8G8B8A8_UNORM<br>
>  };<br>
><br>
>  static const GLuint ubyte_types_scale[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R8_USCALED,<br>
> -   BRW_SURFACEFORMAT_R8G8_USCALED,<br>
> -   BRW_SURFACEFORMAT_R8G8B8_USCALED,<br>
> -   BRW_SURFACEFORMAT_R8G8B8A8_USCALED<br>
> +   ISL_FORMAT_R8_USCALED,<br>
> +   ISL_FORMAT_R8G8_USCALED,<br>
> +   ISL_FORMAT_R8G8B8_USCALED,<br>
> +   ISL_FORMAT_R8G8B8A8_USCALED<br>
>  };<br>
><br>
>  static const GLuint byte_types_direct[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R8_SINT,<br>
> -   BRW_SURFACEFORMAT_R8G8_SINT,<br>
> -   BRW_SURFACEFORMAT_R8G8B8_SINT,<br>
> -   BRW_SURFACEFORMAT_R8G8B8A8_SINT<br>
> +   ISL_FORMAT_R8_SINT,<br>
> +   ISL_FORMAT_R8G8_SINT,<br>
> +   ISL_FORMAT_R8G8B8_SINT,<br>
> +   ISL_FORMAT_R8G8B8A8_SINT<br>
>  };<br>
><br>
>  static const GLuint byte_types_norm[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R8_SNORM,<br>
> -   BRW_SURFACEFORMAT_R8G8_SNORM,<br>
> -   BRW_SURFACEFORMAT_R8G8B8_SNORM,<br>
> -   BRW_SURFACEFORMAT_R8G8B8A8_SNORM<br>
> +   ISL_FORMAT_R8_SNORM,<br>
> +   ISL_FORMAT_R8G8_SNORM,<br>
> +   ISL_FORMAT_R8G8B8_SNORM,<br>
> +   ISL_FORMAT_R8G8B8A8_SNORM<br>
>  };<br>
><br>
>  static const GLuint byte_types_scale[5] = {<br>
>     0,<br>
> -   BRW_SURFACEFORMAT_R8_SSCALED,<br>
> -   BRW_SURFACEFORMAT_R8G8_SSCALED,<br>
> -   BRW_SURFACEFORMAT_R8G8B8_SSCALED,<br>
> -   BRW_SURFACEFORMAT_R8G8B8A8_SSCALED<br>
> +   ISL_FORMAT_R8_SSCALED,<br>
> +   ISL_FORMAT_R8G8_SSCALED,<br>
> +   ISL_FORMAT_R8G8B8_SSCALED,<br>
> +   ISL_FORMAT_R8G8B8A8_SSCALED<br>
>  };<br>
><br>
>  static GLuint<br>
> @@ -284,7 +284,7 @@ brw_get_vertex_surface_type(struct brw_context *brw,<br>
>        default: unreachable("not reached");<br>
>        }<br>
>     } else if (glarray->Type == GL_UNSIGNED_INT_10F_11F_11F_REV) {<br>
> -      return BRW_SURFACEFORMAT_R11G11B10_FLOAT;<br>
> +      return ISL_FORMAT_R11G11B10_FLOAT;<br>
>     } else if (glarray->Normalized) {<br>
>        switch (glarray->Type) {<br>
>        case GL_DOUBLE: return double_types(brw, size, glarray->Doubles);<br>
> @@ -303,7 +303,7 @@ brw_get_vertex_surface_type(struct brw_context *brw,<br>
>           if (glarray->Format == GL_BGRA) {<br>
>              /* See GL_EXT_vertex_array_bgra */<br>
>              assert(size == 4);<br>
> -            return BRW_SURFACEFORMAT_B8G8R8A8_UNORM;<br>
> +            return ISL_FORMAT_B8G8R8A8_UNORM;<br>
>           }<br>
>           else {<br>
>              return ubyte_types_norm[size];<br>
> @@ -325,18 +325,18 @@ brw_get_vertex_surface_type(struct brw_context *brw,<br>
>           assert(size == 4);<br>
>           if (brw->gen >= 8 || brw->is_haswell) {<br>
>              return glarray->Format == GL_BGRA<br>
> -               ? BRW_SURFACEFORMAT_B10G10R10A2_SNORM<br>
> -               : BRW_SURFACEFORMAT_R10G10B10A2_SNORM;<br>
> +               ? ISL_FORMAT_B10G10R10A2_SNORM<br>
> +               : ISL_FORMAT_R10G10B10A2_SNORM;<br>
>           }<br>
> -         return BRW_SURFACEFORMAT_R10G10B10A2_UINT;<br>
> +         return ISL_FORMAT_R10G10B10A2_UINT;<br>
>        case GL_UNSIGNED_INT_2_10_10_10_REV:<br>
>           assert(size == 4);<br>
>           if (brw->gen >= 8 || brw->is_haswell) {<br>
>              return glarray->Format == GL_BGRA<br>
> -               ? BRW_SURFACEFORMAT_B10G10R10A2_UNORM<br>
> -               : BRW_SURFACEFORMAT_R10G10B10A2_UNORM;<br>
> +               ? ISL_FORMAT_B10G10R10A2_UNORM<br>
> +               : ISL_FORMAT_R10G10B10A2_UNORM;<br>
>           }<br>
> -         return BRW_SURFACEFORMAT_R10G10B10A2_UINT;<br>
> +         return ISL_FORMAT_R10G10B10A2_UINT;<br>
>        default: unreachable("not reached");<br>
>        }<br>
>     }<br>
> @@ -350,18 +350,18 @@ brw_get_vertex_surface_type(struct brw_context *brw,<br>
>           assert(size == 4);<br>
>           if (brw->gen >= 8 || brw->is_haswell) {<br>
>              return glarray->Format == GL_BGRA<br>
> -               ? BRW_SURFACEFORMAT_B10G10R10A2_SSCALED<br>
> -               : BRW_SURFACEFORMAT_R10G10B10A2_SSCALED;<br>
> +               ? ISL_FORMAT_B10G10R10A2_SSCALED<br>
> +               : ISL_FORMAT_R10G10B10A2_SSCALED;<br>
>           }<br>
> -         return BRW_SURFACEFORMAT_R10G10B10A2_UINT;<br>
> +         return ISL_FORMAT_R10G10B10A2_UINT;<br>
>        } else if (glarray->Type == GL_UNSIGNED_INT_2_10_10_10_REV) {<br>
>           assert(size == 4);<br>
>           if (brw->gen >= 8 || brw->is_haswell) {<br>
>              return glarray->Format == GL_BGRA<br>
> -               ? BRW_SURFACEFORMAT_B10G10R10A2_USCALED<br>
> -               : BRW_SURFACEFORMAT_R10G10B10A2_USCALED;<br>
> +               ? ISL_FORMAT_B10G10R10A2_USCALED<br>
> +               : ISL_FORMAT_R10G10B10A2_USCALED;<br>
>           }<br>
> -         return BRW_SURFACEFORMAT_R10G10B10A2_UINT;<br>
> +         return ISL_FORMAT_R10G10B10A2_UINT;<br>
>        }<br>
>        assert(glarray->Format == GL_RGBA); /* sanity check */<br>
>        switch (glarray->Type) {<br>
> @@ -801,12 +801,12 @@ brw_emit_vertices(struct brw_context *brw)<br>
>        if (brw->gen >= 6) {<br>
>          OUT_BATCH((0 << GEN6_VE0_INDEX_SHIFT) |<br>
>                    GEN6_VE0_VALID |<br>
> -                  (BRW_SURFACEFORMAT_R32G32B32A32_FLOAT << BRW_VE0_FORMAT_SHIFT) |<br>
> +                  (ISL_FORMAT_R32G32B32A32_FLOAT << BRW_VE0_FORMAT_SHIFT) |<br>
>                    (0 << BRW_VE0_SRC_OFFSET_SHIFT));<br>
>        } else {<br>
>          OUT_BATCH((0 << BRW_VE0_INDEX_SHIFT) |<br>
>                    BRW_VE0_VALID |<br>
> -                  (BRW_SURFACEFORMAT_R32G32B32A32_FLOAT << BRW_VE0_FORMAT_SHIFT) |<br>
> +                  (ISL_FORMAT_R32G32B32A32_FLOAT << BRW_VE0_FORMAT_SHIFT) |<br>
>                    (0 << BRW_VE0_SRC_OFFSET_SHIFT));<br>
>        }<br>
>        OUT_BATCH((BRW_VE1_COMPONENT_STORE_0 << BRW_VE1_COMPONENT_0_SHIFT) |<br>
> @@ -965,11 +965,11 @@ brw_emit_vertices(struct brw_context *brw)<br>
>        if (brw->gen >= 6) {<br>
>           dw0 |= GEN6_VE0_VALID |<br>
>                  brw->vb.nr_buffers << GEN6_VE0_INDEX_SHIFT |<br>
> -                BRW_SURFACEFORMAT_R32G32_UINT << BRW_VE0_FORMAT_SHIFT;<br>
> +                ISL_FORMAT_R32G32_UINT << BRW_VE0_FORMAT_SHIFT;<br>
>        } else {<br>
>           dw0 |= BRW_VE0_VALID |<br>
>                  brw->vb.nr_buffers << BRW_VE0_INDEX_SHIFT |<br>
> -                BRW_SURFACEFORMAT_R32G32_UINT << BRW_VE0_FORMAT_SHIFT;<br>
> +                ISL_FORMAT_R32G32_UINT << BRW_VE0_FORMAT_SHIFT;<br>
>          dw1 |= (i * 4) << BRW_VE1_DST_OFFSET_SHIFT;<br>
>        }<br>
><br>
> @@ -992,11 +992,11 @@ brw_emit_vertices(struct brw_context *brw)<br>
>        if (brw->gen >= 6) {<br>
>           dw0 |= GEN6_VE0_VALID |<br>
>                  ((brw->vb.nr_buffers + 1) << GEN6_VE0_INDEX_SHIFT) |<br>
> -                (BRW_SURFACEFORMAT_R32_UINT << BRW_VE0_FORMAT_SHIFT);<br>
> +                (ISL_FORMAT_R32_UINT << BRW_VE0_FORMAT_SHIFT);<br>
>        } else {<br>
>           dw0 |= BRW_VE0_VALID |<br>
>                  ((brw->vb.nr_buffers + 1) << BRW_VE0_INDEX_SHIFT) |<br>
> -                (BRW_SURFACEFORMAT_R32_UINT << BRW_VE0_FORMAT_SHIFT);<br>
> +                (ISL_FORMAT_R32_UINT << BRW_VE0_FORMAT_SHIFT);<br>
><br>
>          dw1 |= (i * 4) << BRW_VE1_DST_OFFSET_SHIFT;<br>
>        }<br>
> diff --git a/src/mesa/drivers/dri/i965/brw_surface_formats.c b/src/mesa/drivers/dri/i965/brw_surface_formats.c<br>
> index 2543f4b..4d0f522 100644<br>
> --- a/src/mesa/drivers/dri/i965/brw_surface_formats.c<br>
> +++ b/src/mesa/drivers/dri/i965/brw_surface_formats.c<br>
> @@ -34,94 +34,94 @@ brw_format_for_mesa_format(mesa_format mesa_format)<br>
>     /* This table is ordered according to the enum ordering in formats.h.  We do<br>
>      * expect that enum to be extended without our explicit initialization<br>
>      * staying in sync, so we initialize to 0 even though<br>
> -    * BRW_SURFACEFORMAT_R32G32B32A32_FLOAT happens to also be 0.<br>
> +    * ISL_FORMAT_R32G32B32A32_FLOAT happens to also be 0.<br>
>      */<br>
>     static const uint32_t table[MESA_FORMAT_COUNT] =</p>
<p dir="ltr">enum isl_format</p>
<p dir="ltr">There are a number of other places where we store a BRW_SURFACEFORMAT in a uint32_t or uint16_t and we really should be using an enum isl_format.  I'm sure we'll miss a few but we should at least try...</p>
<p dir="ltr">>     {<br>
>        [MESA_FORMAT_A8B8G8R8_UNORM] = 0,<br>
> -      [MESA_FORMAT_R8G8B8A8_UNORM] = BRW_SURFACEFORMAT_R8G8B8A8_UNORM,<br>
> -      [MESA_FORMAT_B8G8R8A8_UNORM] = BRW_SURFACEFORMAT_B8G8R8A8_UNORM,<br>
> +      [MESA_FORMAT_R8G8B8A8_UNORM] = ISL_FORMAT_R8G8B8A8_UNORM,<br>
> +      [MESA_FORMAT_B8G8R8A8_UNORM] = ISL_FORMAT_B8G8R8A8_UNORM,<br>
>        [MESA_FORMAT_A8R8G8B8_UNORM] = 0,<br>
>        [MESA_FORMAT_X8B8G8R8_UNORM] = 0,<br>
> -      [MESA_FORMAT_R8G8B8X8_UNORM] = BRW_SURFACEFORMAT_R8G8B8X8_UNORM,<br>
> -      [MESA_FORMAT_B8G8R8X8_UNORM] = BRW_SURFACEFORMAT_B8G8R8X8_UNORM,<br>
> +      [MESA_FORMAT_R8G8B8X8_UNORM] = ISL_FORMAT_R8G8B8X8_UNORM,<br>
> +      [MESA_FORMAT_B8G8R8X8_UNORM] = ISL_FORMAT_B8G8R8X8_UNORM,<br>
>        [MESA_FORMAT_X8R8G8B8_UNORM] = 0,<br>
>        [MESA_FORMAT_BGR_UNORM8] = 0,<br>
> -      [MESA_FORMAT_RGB_UNORM8] = BRW_SURFACEFORMAT_R8G8B8_UNORM,<br>
> -      [MESA_FORMAT_B5G6R5_UNORM] = BRW_SURFACEFORMAT_B5G6R5_UNORM,<br>
> +      [MESA_FORMAT_RGB_UNORM8] = ISL_FORMAT_R8G8B8_UNORM,<br>
> +      [MESA_FORMAT_B5G6R5_UNORM] = ISL_FORMAT_B5G6R5_UNORM,<br>
>        [MESA_FORMAT_R5G6B5_UNORM] = 0,<br>
> -      [MESA_FORMAT_B4G4R4A4_UNORM] = BRW_SURFACEFORMAT_B4G4R4A4_UNORM,<br>
> +      [MESA_FORMAT_B4G4R4A4_UNORM] = ISL_FORMAT_B4G4R4A4_UNORM,<br>
>        [MESA_FORMAT_A4R4G4B4_UNORM] = 0,<br>
>        [MESA_FORMAT_A1B5G5R5_UNORM] = 0,<br>
> -      [MESA_FORMAT_B5G5R5A1_UNORM] = BRW_SURFACEFORMAT_B5G5R5A1_UNORM,<br>
> +      [MESA_FORMAT_B5G5R5A1_UNORM] = ISL_FORMAT_B5G5R5A1_UNORM,<br>
>        [MESA_FORMAT_A1R5G5B5_UNORM] = 0,<br>
>        [MESA_FORMAT_L4A4_UNORM] = 0,<br>
> -      [MESA_FORMAT_L8A8_UNORM] = BRW_SURFACEFORMAT_L8A8_UNORM,<br>
> +      [MESA_FORMAT_L8A8_UNORM] = ISL_FORMAT_L8A8_UNORM,<br>
>        [MESA_FORMAT_A8L8_UNORM] = 0,<br>
> -      [MESA_FORMAT_L16A16_UNORM] = BRW_SURFACEFORMAT_L16A16_UNORM,<br>
> +      [MESA_FORMAT_L16A16_UNORM] = ISL_FORMAT_L16A16_UNORM,<br>
>        [MESA_FORMAT_A16L16_UNORM] = 0,<br>
>        [MESA_FORMAT_B2G3R3_UNORM] = 0,<br>
> -      [MESA_FORMAT_A_UNORM8] = BRW_SURFACEFORMAT_A8_UNORM,<br>
> -      [MESA_FORMAT_A_UNORM16] = BRW_SURFACEFORMAT_A16_UNORM,<br>
> -      [MESA_FORMAT_L_UNORM8] = BRW_SURFACEFORMAT_L8_UNORM,<br>
> -      [MESA_FORMAT_L_UNORM16] = BRW_SURFACEFORMAT_L16_UNORM,<br>
> -      [MESA_FORMAT_I_UNORM8] = BRW_SURFACEFORMAT_I8_UNORM,<br>
> -      [MESA_FORMAT_I_UNORM16] = BRW_SURFACEFORMAT_I16_UNORM,<br>
> -      [MESA_FORMAT_YCBCR_REV] = BRW_SURFACEFORMAT_YCRCB_NORMAL,<br>
> -      [MESA_FORMAT_YCBCR] = BRW_SURFACEFORMAT_YCRCB_SWAPUVY,<br>
> -      [MESA_FORMAT_R_UNORM8] = BRW_SURFACEFORMAT_R8_UNORM,<br>
> -      [MESA_FORMAT_R8G8_UNORM] = BRW_SURFACEFORMAT_R8G8_UNORM,<br>
> +      [MESA_FORMAT_A_UNORM8] = ISL_FORMAT_A8_UNORM,<br>
> +      [MESA_FORMAT_A_UNORM16] = ISL_FORMAT_A16_UNORM,<br>
> +      [MESA_FORMAT_L_UNORM8] = ISL_FORMAT_L8_UNORM,<br>
> +      [MESA_FORMAT_L_UNORM16] = ISL_FORMAT_L16_UNORM,<br>
> +      [MESA_FORMAT_I_UNORM8] = ISL_FORMAT_I8_UNORM,<br>
> +      [MESA_FORMAT_I_UNORM16] = ISL_FORMAT_I16_UNORM,<br>
> +      [MESA_FORMAT_YCBCR_REV] = ISL_FORMAT_YCRCB_NORMAL,<br>
> +      [MESA_FORMAT_YCBCR] = ISL_FORMAT_YCRCB_SWAPUVY,<br>
> +      [MESA_FORMAT_R_UNORM8] = ISL_FORMAT_R8_UNORM,<br>
> +      [MESA_FORMAT_R8G8_UNORM] = ISL_FORMAT_R8G8_UNORM,<br>
>        [MESA_FORMAT_G8R8_UNORM] = 0,<br>
> -      [MESA_FORMAT_R_UNORM16] = BRW_SURFACEFORMAT_R16_UNORM,<br>
> -      [MESA_FORMAT_R16G16_UNORM] = BRW_SURFACEFORMAT_R16G16_UNORM,<br>
> +      [MESA_FORMAT_R_UNORM16] = ISL_FORMAT_R16_UNORM,<br>
> +      [MESA_FORMAT_R16G16_UNORM] = ISL_FORMAT_R16G16_UNORM,<br>
>        [MESA_FORMAT_G16R16_UNORM] = 0,<br>
> -      [MESA_FORMAT_B10G10R10A2_UNORM] = BRW_SURFACEFORMAT_B10G10R10A2_UNORM,<br>
> +      [MESA_FORMAT_B10G10R10A2_UNORM] = ISL_FORMAT_B10G10R10A2_UNORM,<br>
>        [MESA_FORMAT_S8_UINT_Z24_UNORM] = 0,<br>
>        [MESA_FORMAT_Z24_UNORM_S8_UINT] = 0,<br>
>        [MESA_FORMAT_Z_UNORM16] = 0,<br>
>        [MESA_FORMAT_Z24_UNORM_X8_UINT] = 0,<br>
>        [MESA_FORMAT_X8_UINT_Z24_UNORM] = 0,<br>
>        [MESA_FORMAT_Z_UNORM32] = 0,<br>
> -      [MESA_FORMAT_S_UINT8] = BRW_SURFACEFORMAT_R8_UINT,<br>
> +      [MESA_FORMAT_S_UINT8] = ISL_FORMAT_R8_UINT,<br>
><br>
>        [MESA_FORMAT_BGR_SRGB8] = 0,<br>
>        [MESA_FORMAT_A8B8G8R8_SRGB] = 0,<br>
> -      [MESA_FORMAT_B8G8R8A8_SRGB] = BRW_SURFACEFORMAT_B8G8R8A8_UNORM_SRGB,<br>
> +      [MESA_FORMAT_B8G8R8A8_SRGB] = ISL_FORMAT_B8G8R8A8_UNORM_SRGB,<br>
>        [MESA_FORMAT_A8R8G8B8_SRGB] = 0,<br>
> -      [MESA_FORMAT_R8G8B8A8_SRGB] = BRW_SURFACEFORMAT_R8G8B8A8_UNORM_SRGB,<br>
> +      [MESA_FORMAT_R8G8B8A8_SRGB] = ISL_FORMAT_R8G8B8A8_UNORM_SRGB,<br>
>        [MESA_FORMAT_X8R8G8B8_SRGB] = 0,<br>
> -      [MESA_FORMAT_B8G8R8X8_SRGB] = BRW_SURFACEFORMAT_B8G8R8X8_UNORM_SRGB,<br>
> -      [MESA_FORMAT_L_SRGB8] = BRW_SURFACEFORMAT_L8_UNORM_SRGB,<br>
> -      [MESA_FORMAT_L8A8_SRGB] = BRW_SURFACEFORMAT_L8A8_UNORM_SRGB,<br>
> +      [MESA_FORMAT_B8G8R8X8_SRGB] = ISL_FORMAT_B8G8R8X8_UNORM_SRGB,<br>
> +      [MESA_FORMAT_L_SRGB8] = ISL_FORMAT_L8_UNORM_SRGB,<br>
> +      [MESA_FORMAT_L8A8_SRGB] = ISL_FORMAT_L8A8_UNORM_SRGB,<br>
>        [MESA_FORMAT_A8L8_SRGB] = 0,<br>
> -      [MESA_FORMAT_SRGB_DXT1] = BRW_SURFACEFORMAT_DXT1_RGB_SRGB,<br>
> -      [MESA_FORMAT_SRGBA_DXT1] = BRW_SURFACEFORMAT_BC1_UNORM_SRGB,<br>
> -      [MESA_FORMAT_SRGBA_DXT3] = BRW_SURFACEFORMAT_BC2_UNORM_SRGB,<br>
> -      [MESA_FORMAT_SRGBA_DXT5] = BRW_SURFACEFORMAT_BC3_UNORM_SRGB,<br>
> -<br>
> -      [MESA_FORMAT_RGB_FXT1] = BRW_SURFACEFORMAT_FXT1,<br>
> -      [MESA_FORMAT_RGBA_FXT1] = BRW_SURFACEFORMAT_FXT1,<br>
> -      [MESA_FORMAT_RGB_DXT1] = BRW_SURFACEFORMAT_DXT1_RGB,<br>
> -      [MESA_FORMAT_RGBA_DXT1] = BRW_SURFACEFORMAT_BC1_UNORM,<br>
> -      [MESA_FORMAT_RGBA_DXT3] = BRW_SURFACEFORMAT_BC2_UNORM,<br>
> -      [MESA_FORMAT_RGBA_DXT5] = BRW_SURFACEFORMAT_BC3_UNORM,<br>
> -<br>
> -      [MESA_FORMAT_RGBA_FLOAT32] = BRW_SURFACEFORMAT_R32G32B32A32_FLOAT,<br>
> -      [MESA_FORMAT_RGBA_FLOAT16] = BRW_SURFACEFORMAT_R16G16B16A16_FLOAT,<br>
> -      [MESA_FORMAT_RGB_FLOAT32] = BRW_SURFACEFORMAT_R32G32B32_FLOAT,<br>
> +      [MESA_FORMAT_SRGB_DXT1] = ISL_FORMAT_DXT1_RGB_SRGB,<br>
> +      [MESA_FORMAT_SRGBA_DXT1] = ISL_FORMAT_BC1_UNORM_SRGB,<br>
> +      [MESA_FORMAT_SRGBA_DXT3] = ISL_FORMAT_BC2_UNORM_SRGB,<br>
> +      [MESA_FORMAT_SRGBA_DXT5] = ISL_FORMAT_BC3_UNORM_SRGB,<br>
> +<br>
> +      [MESA_FORMAT_RGB_FXT1] = ISL_FORMAT_FXT1,<br>
> +      [MESA_FORMAT_RGBA_FXT1] = ISL_FORMAT_FXT1,<br>
> +      [MESA_FORMAT_RGB_DXT1] = ISL_FORMAT_DXT1_RGB,<br>
> +      [MESA_FORMAT_RGBA_DXT1] = ISL_FORMAT_BC1_UNORM,<br>
> +      [MESA_FORMAT_RGBA_DXT3] = ISL_FORMAT_BC2_UNORM,<br>
> +      [MESA_FORMAT_RGBA_DXT5] = ISL_FORMAT_BC3_UNORM,<br>
> +<br>
> +      [MESA_FORMAT_RGBA_FLOAT32] = ISL_FORMAT_R32G32B32A32_FLOAT,<br>
> +      [MESA_FORMAT_RGBA_FLOAT16] = ISL_FORMAT_R16G16B16A16_FLOAT,<br>
> +      [MESA_FORMAT_RGB_FLOAT32] = ISL_FORMAT_R32G32B32_FLOAT,<br>
>        [MESA_FORMAT_RGB_FLOAT16] = 0,<br>
> -      [MESA_FORMAT_A_FLOAT32] = BRW_SURFACEFORMAT_A32_FLOAT,<br>
> -      [MESA_FORMAT_A_FLOAT16] = BRW_SURFACEFORMAT_A16_FLOAT,<br>
> -      [MESA_FORMAT_L_FLOAT32] = BRW_SURFACEFORMAT_L32_FLOAT,<br>
> -      [MESA_FORMAT_L_FLOAT16] = BRW_SURFACEFORMAT_L16_FLOAT,<br>
> -      [MESA_FORMAT_LA_FLOAT32] = BRW_SURFACEFORMAT_L32A32_FLOAT,<br>
> -      [MESA_FORMAT_LA_FLOAT16] = BRW_SURFACEFORMAT_L16A16_FLOAT,<br>
> -      [MESA_FORMAT_I_FLOAT32] = BRW_SURFACEFORMAT_I32_FLOAT,<br>
> -      [MESA_FORMAT_I_FLOAT16] = BRW_SURFACEFORMAT_I16_FLOAT,<br>
> -      [MESA_FORMAT_R_FLOAT32] = BRW_SURFACEFORMAT_R32_FLOAT,<br>
> -      [MESA_FORMAT_R_FLOAT16] = BRW_SURFACEFORMAT_R16_FLOAT,<br>
> -      [MESA_FORMAT_RG_FLOAT32] = BRW_SURFACEFORMAT_R32G32_FLOAT,<br>
> -      [MESA_FORMAT_RG_FLOAT16] = BRW_SURFACEFORMAT_R16G16_FLOAT,<br>
> +      [MESA_FORMAT_A_FLOAT32] = ISL_FORMAT_A32_FLOAT,<br>
> +      [MESA_FORMAT_A_FLOAT16] = ISL_FORMAT_A16_FLOAT,<br>
> +      [MESA_FORMAT_L_FLOAT32] = ISL_FORMAT_L32_FLOAT,<br>
> +      [MESA_FORMAT_L_FLOAT16] = ISL_FORMAT_L16_FLOAT,<br>
> +      [MESA_FORMAT_LA_FLOAT32] = ISL_FORMAT_L32A32_FLOAT,<br>
> +      [MESA_FORMAT_LA_FLOAT16] = ISL_FORMAT_L16A16_FLOAT,<br>
> +      [MESA_FORMAT_I_FLOAT32] = ISL_FORMAT_I32_FLOAT,<br>
> +      [MESA_FORMAT_I_FLOAT16] = ISL_FORMAT_I16_FLOAT,<br>
> +      [MESA_FORMAT_R_FLOAT32] = ISL_FORMAT_R32_FLOAT,<br>
> +      [MESA_FORMAT_R_FLOAT16] = ISL_FORMAT_R16_FLOAT,<br>
> +      [MESA_FORMAT_RG_FLOAT32] = ISL_FORMAT_R32G32_FLOAT,<br>
> +      [MESA_FORMAT_RG_FLOAT16] = ISL_FORMAT_R16G16_FLOAT,<br>
><br>
>        [MESA_FORMAT_A_UINT8] = 0,<br>
>        [MESA_FORMAT_A_UINT16] = 0,<br>
> @@ -151,98 +151,98 @@ brw_format_for_mesa_format(mesa_format mesa_format)<br>
>        [MESA_FORMAT_LA_SINT16] = 0,<br>
>        [MESA_FORMAT_LA_SINT32] = 0,<br>
><br>
> -      [MESA_FORMAT_R_SINT8] = BRW_SURFACEFORMAT_R8_SINT,<br>
> -      [MESA_FORMAT_RG_SINT8] = BRW_SURFACEFORMAT_R8G8_SINT,<br>
> -      [MESA_FORMAT_RGB_SINT8] = BRW_SURFACEFORMAT_R8G8B8_SINT,<br>
> -      [MESA_FORMAT_RGBA_SINT8] = BRW_SURFACEFORMAT_R8G8B8A8_SINT,<br>
> -      [MESA_FORMAT_R_SINT16] = BRW_SURFACEFORMAT_R16_SINT,<br>
> -      [MESA_FORMAT_RG_SINT16] = BRW_SURFACEFORMAT_R16G16_SINT,<br>
> -      [MESA_FORMAT_RGB_SINT16] = BRW_SURFACEFORMAT_R16G16B16_SINT,<br>
> -      [MESA_FORMAT_RGBA_SINT16] = BRW_SURFACEFORMAT_R16G16B16A16_SINT,<br>
> -      [MESA_FORMAT_R_SINT32] = BRW_SURFACEFORMAT_R32_SINT,<br>
> -      [MESA_FORMAT_RG_SINT32] = BRW_SURFACEFORMAT_R32G32_SINT,<br>
> -      [MESA_FORMAT_RGB_SINT32] = BRW_SURFACEFORMAT_R32G32B32_SINT,<br>
> -      [MESA_FORMAT_RGBA_SINT32] = BRW_SURFACEFORMAT_R32G32B32A32_SINT,<br>
> -<br>
> -      [MESA_FORMAT_R_UINT8] = BRW_SURFACEFORMAT_R8_UINT,<br>
> -      [MESA_FORMAT_RG_UINT8] = BRW_SURFACEFORMAT_R8G8_UINT,<br>
> -      [MESA_FORMAT_RGB_UINT8] = BRW_SURFACEFORMAT_R8G8B8_UINT,<br>
> -      [MESA_FORMAT_RGBA_UINT8] = BRW_SURFACEFORMAT_R8G8B8A8_UINT,<br>
> -      [MESA_FORMAT_R_UINT16] = BRW_SURFACEFORMAT_R16_UINT,<br>
> -      [MESA_FORMAT_RG_UINT16] = BRW_SURFACEFORMAT_R16G16_UINT,<br>
> -      [MESA_FORMAT_RGB_UINT16] = BRW_SURFACEFORMAT_R16G16B16_UINT,<br>
> -      [MESA_FORMAT_RGBA_UINT16] = BRW_SURFACEFORMAT_R16G16B16A16_UINT,<br>
> -      [MESA_FORMAT_R_UINT32] = BRW_SURFACEFORMAT_R32_UINT,<br>
> -      [MESA_FORMAT_RG_UINT32] = BRW_SURFACEFORMAT_R32G32_UINT,<br>
> -      [MESA_FORMAT_RGB_UINT32] = BRW_SURFACEFORMAT_R32G32B32_UINT,<br>
> -      [MESA_FORMAT_RGBA_UINT32] = BRW_SURFACEFORMAT_R32G32B32A32_UINT,<br>
> -<br>
> -      [MESA_FORMAT_R_SNORM8] = BRW_SURFACEFORMAT_R8_SNORM,<br>
> -      [MESA_FORMAT_R8G8_SNORM] = BRW_SURFACEFORMAT_R8G8_SNORM,<br>
> +      [MESA_FORMAT_R_SINT8] = ISL_FORMAT_R8_SINT,<br>
> +      [MESA_FORMAT_RG_SINT8] = ISL_FORMAT_R8G8_SINT,<br>
> +      [MESA_FORMAT_RGB_SINT8] = ISL_FORMAT_R8G8B8_SINT,<br>
> +      [MESA_FORMAT_RGBA_SINT8] = ISL_FORMAT_R8G8B8A8_SINT,<br>
> +      [MESA_FORMAT_R_SINT16] = ISL_FORMAT_R16_SINT,<br>
> +      [MESA_FORMAT_RG_SINT16] = ISL_FORMAT_R16G16_SINT,<br>
> +      [MESA_FORMAT_RGB_SINT16] = ISL_FORMAT_R16G16B16_SINT,<br>
> +      [MESA_FORMAT_RGBA_SINT16] = ISL_FORMAT_R16G16B16A16_SINT,<br>
> +      [MESA_FORMAT_R_SINT32] = ISL_FORMAT_R32_SINT,<br>
> +      [MESA_FORMAT_RG_SINT32] = ISL_FORMAT_R32G32_SINT,<br>
> +      [MESA_FORMAT_RGB_SINT32] = ISL_FORMAT_R32G32B32_SINT,<br>
> +      [MESA_FORMAT_RGBA_SINT32] = ISL_FORMAT_R32G32B32A32_SINT,<br>
> +<br>
> +      [MESA_FORMAT_R_UINT8] = ISL_FORMAT_R8_UINT,<br>
> +      [MESA_FORMAT_RG_UINT8] = ISL_FORMAT_R8G8_UINT,<br>
> +      [MESA_FORMAT_RGB_UINT8] = ISL_FORMAT_R8G8B8_UINT,<br>
> +      [MESA_FORMAT_RGBA_UINT8] = ISL_FORMAT_R8G8B8A8_UINT,<br>
> +      [MESA_FORMAT_R_UINT16] = ISL_FORMAT_R16_UINT,<br>
> +      [MESA_FORMAT_RG_UINT16] = ISL_FORMAT_R16G16_UINT,<br>
> +      [MESA_FORMAT_RGB_UINT16] = ISL_FORMAT_R16G16B16_UINT,<br>
> +      [MESA_FORMAT_RGBA_UINT16] = ISL_FORMAT_R16G16B16A16_UINT,<br>
> +      [MESA_FORMAT_R_UINT32] = ISL_FORMAT_R32_UINT,<br>
> +      [MESA_FORMAT_RG_UINT32] = ISL_FORMAT_R32G32_UINT,<br>
> +      [MESA_FORMAT_RGB_UINT32] = ISL_FORMAT_R32G32B32_UINT,<br>
> +      [MESA_FORMAT_RGBA_UINT32] = ISL_FORMAT_R32G32B32A32_UINT,<br>
> +<br>
> +      [MESA_FORMAT_R_SNORM8] = ISL_FORMAT_R8_SNORM,<br>
> +      [MESA_FORMAT_R8G8_SNORM] = ISL_FORMAT_R8G8_SNORM,<br>
>        [MESA_FORMAT_X8B8G8R8_SNORM] = 0,<br>
>        [MESA_FORMAT_A8B8G8R8_SNORM] = 0,<br>
> -      [MESA_FORMAT_R8G8B8A8_SNORM] = BRW_SURFACEFORMAT_R8G8B8A8_SNORM,<br>
> -      [MESA_FORMAT_R_SNORM16] = BRW_SURFACEFORMAT_R16_SNORM,<br>
> -      [MESA_FORMAT_R16G16_SNORM] = BRW_SURFACEFORMAT_R16G16_SNORM,<br>
> -      [MESA_FORMAT_RGB_SNORM16] = BRW_SURFACEFORMAT_R16G16B16_SNORM,<br>
> -      [MESA_FORMAT_RGBA_SNORM16] = BRW_SURFACEFORMAT_R16G16B16A16_SNORM,<br>
> -      [MESA_FORMAT_RGBA_UNORM16] = BRW_SURFACEFORMAT_R16G16B16A16_UNORM,<br>
> -<br>
> -      [MESA_FORMAT_R_RGTC1_UNORM] = BRW_SURFACEFORMAT_BC4_UNORM,<br>
> -      [MESA_FORMAT_R_RGTC1_SNORM] = BRW_SURFACEFORMAT_BC4_SNORM,<br>
> -      [MESA_FORMAT_RG_RGTC2_UNORM] = BRW_SURFACEFORMAT_BC5_UNORM,<br>
> -      [MESA_FORMAT_RG_RGTC2_SNORM] = BRW_SURFACEFORMAT_BC5_SNORM,<br>
> +      [MESA_FORMAT_R8G8B8A8_SNORM] = ISL_FORMAT_R8G8B8A8_SNORM,<br>
> +      [MESA_FORMAT_R_SNORM16] = ISL_FORMAT_R16_SNORM,<br>
> +      [MESA_FORMAT_R16G16_SNORM] = ISL_FORMAT_R16G16_SNORM,<br>
> +      [MESA_FORMAT_RGB_SNORM16] = ISL_FORMAT_R16G16B16_SNORM,<br>
> +      [MESA_FORMAT_RGBA_SNORM16] = ISL_FORMAT_R16G16B16A16_SNORM,<br>
> +      [MESA_FORMAT_RGBA_UNORM16] = ISL_FORMAT_R16G16B16A16_UNORM,<br>
> +<br>
> +      [MESA_FORMAT_R_RGTC1_UNORM] = ISL_FORMAT_BC4_UNORM,<br>
> +      [MESA_FORMAT_R_RGTC1_SNORM] = ISL_FORMAT_BC4_SNORM,<br>
> +      [MESA_FORMAT_RG_RGTC2_UNORM] = ISL_FORMAT_BC5_UNORM,<br>
> +      [MESA_FORMAT_RG_RGTC2_SNORM] = ISL_FORMAT_BC5_SNORM,<br>
><br>
>        [MESA_FORMAT_L_LATC1_UNORM] = 0,<br>
>        [MESA_FORMAT_L_LATC1_SNORM] = 0,<br>
>        [MESA_FORMAT_LA_LATC2_UNORM] = 0,<br>
>        [MESA_FORMAT_LA_LATC2_SNORM] = 0,<br>
><br>
> -      [MESA_FORMAT_ETC1_RGB8] = BRW_SURFACEFORMAT_ETC1_RGB8,<br>
> -      [MESA_FORMAT_ETC2_RGB8] = BRW_SURFACEFORMAT_ETC2_RGB8,<br>
> -      [MESA_FORMAT_ETC2_SRGB8] = BRW_SURFACEFORMAT_ETC2_SRGB8,<br>
> -      [MESA_FORMAT_ETC2_RGBA8_EAC] = BRW_SURFACEFORMAT_ETC2_EAC_RGBA8,<br>
> -      [MESA_FORMAT_ETC2_SRGB8_ALPHA8_EAC] = BRW_SURFACEFORMAT_ETC2_EAC_SRGB8_A8,<br>
> -      [MESA_FORMAT_ETC2_R11_EAC] = BRW_SURFACEFORMAT_EAC_R11,<br>
> -      [MESA_FORMAT_ETC2_RG11_EAC] = BRW_SURFACEFORMAT_EAC_RG11,<br>
> -      [MESA_FORMAT_ETC2_SIGNED_R11_EAC] = BRW_SURFACEFORMAT_EAC_SIGNED_R11,<br>
> -      [MESA_FORMAT_ETC2_SIGNED_RG11_EAC] = BRW_SURFACEFORMAT_EAC_SIGNED_RG11,<br>
> -      [MESA_FORMAT_ETC2_RGB8_PUNCHTHROUGH_ALPHA1] = BRW_SURFACEFORMAT_ETC2_RGB8_PTA,<br>
> -      [MESA_FORMAT_ETC2_SRGB8_PUNCHTHROUGH_ALPHA1] = BRW_SURFACEFORMAT_ETC2_SRGB8_PTA,<br>
> -<br>
> -      [MESA_FORMAT_BPTC_RGBA_UNORM] = BRW_SURFACEFORMAT_BC7_UNORM,<br>
> -      [MESA_FORMAT_BPTC_SRGB_ALPHA_UNORM] = BRW_SURFACEFORMAT_BC7_UNORM_SRGB,<br>
> -      [MESA_FORMAT_BPTC_RGB_SIGNED_FLOAT] = BRW_SURFACEFORMAT_BC6H_SF16,<br>
> -      [MESA_FORMAT_BPTC_RGB_UNSIGNED_FLOAT] = BRW_SURFACEFORMAT_BC6H_UF16,<br>
> -<br>
> -      [MESA_FORMAT_RGBA_ASTC_4x4]           = BRW_SURFACEFORMAT_ASTC_LDR_2D_4x4_FLT16,<br>
> -      [MESA_FORMAT_RGBA_ASTC_5x4]           = BRW_SURFACEFORMAT_ASTC_LDR_2D_5x4_FLT16,<br>
> -      [MESA_FORMAT_RGBA_ASTC_5x5]           = BRW_SURFACEFORMAT_ASTC_LDR_2D_5x5_FLT16,<br>
> -      [MESA_FORMAT_RGBA_ASTC_6x5]           = BRW_SURFACEFORMAT_ASTC_LDR_2D_6x5_FLT16,<br>
> -      [MESA_FORMAT_RGBA_ASTC_6x6]           = BRW_SURFACEFORMAT_ASTC_LDR_2D_6x6_FLT16,<br>
> -      [MESA_FORMAT_RGBA_ASTC_8x5]           = BRW_SURFACEFORMAT_ASTC_LDR_2D_8x5_FLT16,<br>
> -      [MESA_FORMAT_RGBA_ASTC_8x6]           = BRW_SURFACEFORMAT_ASTC_LDR_2D_8x6_FLT16,<br>
> -      [MESA_FORMAT_RGBA_ASTC_8x8]           = BRW_SURFACEFORMAT_ASTC_LDR_2D_8x8_FLT16,<br>
> -      [MESA_FORMAT_RGBA_ASTC_10x5]          = BRW_SURFACEFORMAT_ASTC_LDR_2D_10x5_FLT16,<br>
> -      [MESA_FORMAT_RGBA_ASTC_10x6]          = BRW_SURFACEFORMAT_ASTC_LDR_2D_10x6_FLT16,<br>
> -      [MESA_FORMAT_RGBA_ASTC_10x8]          = BRW_SURFACEFORMAT_ASTC_LDR_2D_10x8_FLT16,<br>
> -      [MESA_FORMAT_RGBA_ASTC_10x10]         = BRW_SURFACEFORMAT_ASTC_LDR_2D_10x10_FLT16,<br>
> -      [MESA_FORMAT_RGBA_ASTC_12x10]         = BRW_SURFACEFORMAT_ASTC_LDR_2D_12x10_FLT16,<br>
> -      [MESA_FORMAT_RGBA_ASTC_12x12]         = BRW_SURFACEFORMAT_ASTC_LDR_2D_12x12_FLT16,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_4x4]   = BRW_SURFACEFORMAT_ASTC_LDR_2D_4x4_U8sRGB,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_5x4]   = BRW_SURFACEFORMAT_ASTC_LDR_2D_5x4_U8sRGB,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_5x5]   = BRW_SURFACEFORMAT_ASTC_LDR_2D_5x5_U8sRGB,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_6x5]   = BRW_SURFACEFORMAT_ASTC_LDR_2D_6x5_U8sRGB,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_6x6]   = BRW_SURFACEFORMAT_ASTC_LDR_2D_6x6_U8sRGB,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_8x5]   = BRW_SURFACEFORMAT_ASTC_LDR_2D_8x5_U8sRGB,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_8x6]   = BRW_SURFACEFORMAT_ASTC_LDR_2D_8x6_U8sRGB,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_8x8]   = BRW_SURFACEFORMAT_ASTC_LDR_2D_8x8_U8sRGB,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_10x5]  = BRW_SURFACEFORMAT_ASTC_LDR_2D_10x5_U8sRGB,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_10x6]  = BRW_SURFACEFORMAT_ASTC_LDR_2D_10x6_U8sRGB,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_10x8]  = BRW_SURFACEFORMAT_ASTC_LDR_2D_10x8_U8sRGB,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_10x10] = BRW_SURFACEFORMAT_ASTC_LDR_2D_10x10_U8sRGB,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_12x10] = BRW_SURFACEFORMAT_ASTC_LDR_2D_12x10_U8sRGB,<br>
> -      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_12x12] = BRW_SURFACEFORMAT_ASTC_LDR_2D_12x12_U8sRGB,<br>
> +      [MESA_FORMAT_ETC1_RGB8] = ISL_FORMAT_ETC1_RGB8,<br>
> +      [MESA_FORMAT_ETC2_RGB8] = ISL_FORMAT_ETC2_RGB8,<br>
> +      [MESA_FORMAT_ETC2_SRGB8] = ISL_FORMAT_ETC2_SRGB8,<br>
> +      [MESA_FORMAT_ETC2_RGBA8_EAC] = ISL_FORMAT_ETC2_EAC_RGBA8,<br>
> +      [MESA_FORMAT_ETC2_SRGB8_ALPHA8_EAC] = ISL_FORMAT_ETC2_EAC_SRGB8_A8,<br>
> +      [MESA_FORMAT_ETC2_R11_EAC] = ISL_FORMAT_EAC_R11,<br>
> +      [MESA_FORMAT_ETC2_RG11_EAC] = ISL_FORMAT_EAC_RG11,<br>
> +      [MESA_FORMAT_ETC2_SIGNED_R11_EAC] = ISL_FORMAT_EAC_SIGNED_R11,<br>
> +      [MESA_FORMAT_ETC2_SIGNED_RG11_EAC] = ISL_FORMAT_EAC_SIGNED_RG11,<br>
> +      [MESA_FORMAT_ETC2_RGB8_PUNCHTHROUGH_ALPHA1] = ISL_FORMAT_ETC2_RGB8_PTA,<br>
> +      [MESA_FORMAT_ETC2_SRGB8_PUNCHTHROUGH_ALPHA1] = ISL_FORMAT_ETC2_SRGB8_PTA,<br>
> +<br>
> +      [MESA_FORMAT_BPTC_RGBA_UNORM] = ISL_FORMAT_BC7_UNORM,<br>
> +      [MESA_FORMAT_BPTC_SRGB_ALPHA_UNORM] = ISL_FORMAT_BC7_UNORM_SRGB,<br>
> +      [MESA_FORMAT_BPTC_RGB_SIGNED_FLOAT] = ISL_FORMAT_BC6H_SF16,<br>
> +      [MESA_FORMAT_BPTC_RGB_UNSIGNED_FLOAT] = ISL_FORMAT_BC6H_UF16,<br>
> +<br>
> +      [MESA_FORMAT_RGBA_ASTC_4x4]           = ISL_FORMAT_ASTC_LDR_2D_4X4_FLT16,<br>
> +      [MESA_FORMAT_RGBA_ASTC_5x4]           = ISL_FORMAT_ASTC_LDR_2D_5X4_FLT16,<br>
> +      [MESA_FORMAT_RGBA_ASTC_5x5]           = ISL_FORMAT_ASTC_LDR_2D_5X5_FLT16,<br>
> +      [MESA_FORMAT_RGBA_ASTC_6x5]           = ISL_FORMAT_ASTC_LDR_2D_6X5_FLT16,<br>
> +      [MESA_FORMAT_RGBA_ASTC_6x6]           = ISL_FORMAT_ASTC_LDR_2D_6X6_FLT16,<br>
> +      [MESA_FORMAT_RGBA_ASTC_8x5]           = ISL_FORMAT_ASTC_LDR_2D_8X5_FLT16,<br>
> +      [MESA_FORMAT_RGBA_ASTC_8x6]           = ISL_FORMAT_ASTC_LDR_2D_8X6_FLT16,<br>
> +      [MESA_FORMAT_RGBA_ASTC_8x8]           = ISL_FORMAT_ASTC_LDR_2D_8X8_FLT16,<br>
> +      [MESA_FORMAT_RGBA_ASTC_10x5]          = ISL_FORMAT_ASTC_LDR_2D_10X5_FLT16,<br>
> +      [MESA_FORMAT_RGBA_ASTC_10x6]          = ISL_FORMAT_ASTC_LDR_2D_10X6_FLT16,<br>
> +      [MESA_FORMAT_RGBA_ASTC_10x8]          = ISL_FORMAT_ASTC_LDR_2D_10X8_FLT16,<br>
> +      [MESA_FORMAT_RGBA_ASTC_10x10]         = ISL_FORMAT_ASTC_LDR_2D_10X10_FLT16,<br>
> +      [MESA_FORMAT_RGBA_ASTC_12x10]         = ISL_FORMAT_ASTC_LDR_2D_12X10_FLT16,<br>
> +      [MESA_FORMAT_RGBA_ASTC_12x12]         = ISL_FORMAT_ASTC_LDR_2D_12X12_FLT16,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_4x4]   = ISL_FORMAT_ASTC_LDR_2D_4X4_U8SRGB,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_5x4]   = ISL_FORMAT_ASTC_LDR_2D_5X4_U8SRGB,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_5x5]   = ISL_FORMAT_ASTC_LDR_2D_5X5_U8SRGB,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_6x5]   = ISL_FORMAT_ASTC_LDR_2D_6X5_U8SRGB,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_6x6]   = ISL_FORMAT_ASTC_LDR_2D_6X6_U8SRGB,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_8x5]   = ISL_FORMAT_ASTC_LDR_2D_8X5_U8SRGB,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_8x6]   = ISL_FORMAT_ASTC_LDR_2D_8X6_U8SRGB,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_8x8]   = ISL_FORMAT_ASTC_LDR_2D_8X8_U8SRGB,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_10x5]  = ISL_FORMAT_ASTC_LDR_2D_10X5_U8SRGB,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_10x6]  = ISL_FORMAT_ASTC_LDR_2D_10X6_U8SRGB,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_10x8]  = ISL_FORMAT_ASTC_LDR_2D_10X8_U8SRGB,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_10x10] = ISL_FORMAT_ASTC_LDR_2D_10X10_U8SRGB,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_12x10] = ISL_FORMAT_ASTC_LDR_2D_12X10_U8SRGB,<br>
> +      [MESA_FORMAT_SRGB8_ALPHA8_ASTC_12x12] = ISL_FORMAT_ASTC_LDR_2D_12X12_U8SRGB,<br>
><br>
>        [MESA_FORMAT_A_SNORM8] = 0,<br>
>        [MESA_FORMAT_L_SNORM8] = 0,<br>
> @@ -254,30 +254,30 @@ brw_format_for_mesa_format(mesa_format mesa_format)<br>
>        [MESA_FORMAT_LA_SNORM16] = 0,<br>
>        [MESA_FORMAT_I_SNORM16] = 0,<br>
><br>
> -      [MESA_FORMAT_R9G9B9E5_FLOAT] = BRW_SURFACEFORMAT_R9G9B9E5_SHAREDEXP,<br>
> -      [MESA_FORMAT_R11G11B10_FLOAT] = BRW_SURFACEFORMAT_R11G11B10_FLOAT,<br>
> +      [MESA_FORMAT_R9G9B9E5_FLOAT] = ISL_FORMAT_R9G9B9E5_SHAREDEXP,<br>
> +      [MESA_FORMAT_R11G11B10_FLOAT] = ISL_FORMAT_R11G11B10_FLOAT,<br>
><br>
>        [MESA_FORMAT_Z_FLOAT32] = 0,<br>
>        [MESA_FORMAT_Z32_FLOAT_S8X24_UINT] = 0,<br>
><br>
> -      [MESA_FORMAT_R10G10B10A2_UNORM] = BRW_SURFACEFORMAT_R10G10B10A2_UNORM,<br>
> -      [MESA_FORMAT_B10G10R10A2_UINT] = BRW_SURFACEFORMAT_B10G10R10A2_UINT,<br>
> -      [MESA_FORMAT_R10G10B10A2_UINT] = BRW_SURFACEFORMAT_R10G10B10A2_UINT,<br>
> +      [MESA_FORMAT_R10G10B10A2_UNORM] = ISL_FORMAT_R10G10B10A2_UNORM,<br>
> +      [MESA_FORMAT_B10G10R10A2_UINT] = ISL_FORMAT_B10G10R10A2_UINT,<br>
> +      [MESA_FORMAT_R10G10B10A2_UINT] = ISL_FORMAT_R10G10B10A2_UINT,<br>
><br>
>        [MESA_FORMAT_B4G4R4X4_UNORM] = 0,<br>
> -      [MESA_FORMAT_B5G5R5X1_UNORM] = BRW_SURFACEFORMAT_B5G5R5X1_UNORM,<br>
> +      [MESA_FORMAT_B5G5R5X1_UNORM] = ISL_FORMAT_B5G5R5X1_UNORM,<br>
>        [MESA_FORMAT_R8G8B8X8_SNORM] = 0,<br>
> -      [MESA_FORMAT_R8G8B8X8_SRGB] = BRW_SURFACEFORMAT_R8G8B8X8_UNORM_SRGB,<br>
> +      [MESA_FORMAT_R8G8B8X8_SRGB] = ISL_FORMAT_R8G8B8X8_UNORM_SRGB,<br>
>        [MESA_FORMAT_X8B8G8R8_SRGB] = 0,<br>
>        [MESA_FORMAT_RGBX_UINT8] = 0,<br>
>        [MESA_FORMAT_RGBX_SINT8] = 0,<br>
> -      [MESA_FORMAT_B10G10R10X2_UNORM] = BRW_SURFACEFORMAT_B10G10R10X2_UNORM,<br>
> -      [MESA_FORMAT_RGBX_UNORM16] = BRW_SURFACEFORMAT_R16G16B16X16_UNORM,<br>
> +      [MESA_FORMAT_B10G10R10X2_UNORM] = ISL_FORMAT_B10G10R10X2_UNORM,<br>
> +      [MESA_FORMAT_RGBX_UNORM16] = ISL_FORMAT_R16G16B16X16_UNORM,<br>
>        [MESA_FORMAT_RGBX_SNORM16] = 0,<br>
> -      [MESA_FORMAT_RGBX_FLOAT16] = BRW_SURFACEFORMAT_R16G16B16X16_FLOAT,<br>
> +      [MESA_FORMAT_RGBX_FLOAT16] = ISL_FORMAT_R16G16B16X16_FLOAT,<br>
>        [MESA_FORMAT_RGBX_UINT16] = 0,<br>
>        [MESA_FORMAT_RGBX_SINT16] = 0,<br>
> -      [MESA_FORMAT_RGBX_FLOAT32] = BRW_SURFACEFORMAT_R32G32B32X32_FLOAT,<br>
> +      [MESA_FORMAT_RGBX_FLOAT32] = ISL_FORMAT_R32G32B32X32_FLOAT,<br>
>        [MESA_FORMAT_RGBX_UINT32] = 0,<br>
>        [MESA_FORMAT_RGBX_SINT32] = 0,<br>
>     };<br>
> @@ -305,7 +305,7 @@ brw_init_surface_formats(struct brw_context *brw)<br>
><br>
>        render = texture = brw_format_for_mesa_format(format);<br>
><br>
> -      /* The value of BRW_SURFACEFORMAT_R32G32B32A32_FLOAT is 0, so don't skip<br>
> +      /* The value of ISL_FORMAT_R32G32B32A32_FLOAT is 0, so don't skip<br>
>         * it.<br>
>         */<br>
>        if (texture == 0 && format != MESA_FORMAT_RGBA_FLOAT32)<br>
> @@ -323,29 +323,29 @@ brw_init_surface_formats(struct brw_context *brw)<br>
>           * channel into R, which is to say that we just treat them as<br>
>           * GL_RED.<br>
>           */<br>
> -      case BRW_SURFACEFORMAT_I32_FLOAT:<br>
> -      case BRW_SURFACEFORMAT_L32_FLOAT:<br>
> -        render = BRW_SURFACEFORMAT_R32_FLOAT;<br>
> +      case ISL_FORMAT_I32_FLOAT:<br>
> +      case ISL_FORMAT_L32_FLOAT:<br>
> +        render = ISL_FORMAT_R32_FLOAT;<br>
>          break;<br>
> -      case BRW_SURFACEFORMAT_I16_FLOAT:<br>
> -      case BRW_SURFACEFORMAT_L16_FLOAT:<br>
> -        render = BRW_SURFACEFORMAT_R16_FLOAT;<br>
> +      case ISL_FORMAT_I16_FLOAT:<br>
> +      case ISL_FORMAT_L16_FLOAT:<br>
> +        render = ISL_FORMAT_R16_FLOAT;<br>
>          break;<br>
> -      case BRW_SURFACEFORMAT_I8_UNORM:<br>
> -      case BRW_SURFACEFORMAT_L8_UNORM:<br>
> -         render = BRW_SURFACEFORMAT_R8_UNORM;<br>
> +      case ISL_FORMAT_I8_UNORM:<br>
> +      case ISL_FORMAT_L8_UNORM:<br>
> +         render = ISL_FORMAT_R8_UNORM;<br>
>           break;<br>
> -      case BRW_SURFACEFORMAT_I16_UNORM:<br>
> -      case BRW_SURFACEFORMAT_L16_UNORM:<br>
> -         render = BRW_SURFACEFORMAT_R16_UNORM;<br>
> +      case ISL_FORMAT_I16_UNORM:<br>
> +      case ISL_FORMAT_L16_UNORM:<br>
> +         render = ISL_FORMAT_R16_UNORM;<br>
>           break;<br>
> -      case BRW_SURFACEFORMAT_R16G16B16X16_UNORM:<br>
> -         render = BRW_SURFACEFORMAT_R16G16B16A16_UNORM;<br>
> +      case ISL_FORMAT_R16G16B16X16_UNORM:<br>
> +         render = ISL_FORMAT_R16G16B16A16_UNORM;<br>
>           break;<br>
> -      case BRW_SURFACEFORMAT_R16G16B16X16_FLOAT:<br>
> -         render = BRW_SURFACEFORMAT_R16G16B16A16_FLOAT;<br>
> +      case ISL_FORMAT_R16G16B16X16_FLOAT:<br>
> +         render = ISL_FORMAT_R16G16B16A16_FLOAT;<br>
>           break;<br>
> -      case BRW_SURFACEFORMAT_B8G8R8X8_UNORM:<br>
> +      case ISL_FORMAT_B8G8R8X8_UNORM:<br>
>          /* XRGB is handled as ARGB because the chips in this family<br>
>           * cannot render to XRGB targets.  This means that we have to<br>
>           * mask writes to alpha (ala glColorMask) and reconfigure the<br>
> @@ -354,17 +354,17 @@ brw_init_surface_formats(struct brw_context *brw)<br>
>           * used. On Gen8+ BGRX is actually allowed (but not RGBX).<br>
>           */<br>
>           if (!isl_format_supports_rendering(devinfo, texture))<br>
> -            render = BRW_SURFACEFORMAT_B8G8R8A8_UNORM;<br>
> +            render = ISL_FORMAT_B8G8R8A8_UNORM;<br>
>          break;<br>
> -      case BRW_SURFACEFORMAT_B8G8R8X8_UNORM_SRGB:<br>
> +      case ISL_FORMAT_B8G8R8X8_UNORM_SRGB:<br>
>           if (!isl_format_supports_rendering(devinfo, texture))<br>
> -            render = BRW_SURFACEFORMAT_B8G8R8A8_UNORM_SRGB;<br>
> +            render = ISL_FORMAT_B8G8R8A8_UNORM_SRGB;<br>
>           break;<br>
> -      case BRW_SURFACEFORMAT_R8G8B8X8_UNORM:<br>
> -         render = BRW_SURFACEFORMAT_R8G8B8A8_UNORM;<br>
> +      case ISL_FORMAT_R8G8B8X8_UNORM:<br>
> +         render = ISL_FORMAT_R8G8B8A8_UNORM;<br>
>           break;<br>
> -      case BRW_SURFACEFORMAT_R8G8B8X8_UNORM_SRGB:<br>
> -         render = BRW_SURFACEFORMAT_R8G8B8A8_UNORM_SRGB;<br>
> +      case ISL_FORMAT_R8G8B8X8_UNORM_SRGB:<br>
> +         render = ISL_FORMAT_R8G8B8A8_UNORM_SRGB;<br>
>           break;<br>
>        }<br>
><br>
> @@ -513,23 +513,23 @@ translate_tex_format(struct brw_context *brw,<br>
>     switch( mesa_format ) {<br>
><br>
>     case MESA_FORMAT_Z_UNORM16:<br>
> -      return BRW_SURFACEFORMAT_R16_UNORM;<br>
> +      return ISL_FORMAT_R16_UNORM;<br>
><br>
>     case MESA_FORMAT_Z24_UNORM_S8_UINT:<br>
>     case MESA_FORMAT_Z24_UNORM_X8_UINT:<br>
> -      return BRW_SURFACEFORMAT_R24_UNORM_X8_TYPELESS;<br>
> +      return ISL_FORMAT_R24_UNORM_X8_TYPELESS;<br>
><br>
>     case MESA_FORMAT_Z_FLOAT32:<br>
> -      return BRW_SURFACEFORMAT_R32_FLOAT;<br>
> +      return ISL_FORMAT_R32_FLOAT;<br>
><br>
>     case MESA_FORMAT_Z32_FLOAT_S8X24_UINT:<br>
> -      return BRW_SURFACEFORMAT_R32_FLOAT_X8X24_TYPELESS;<br>
> +      return ISL_FORMAT_R32_FLOAT_X8X24_TYPELESS;<br>
><br>
>     case MESA_FORMAT_RGBA_FLOAT32:<br>
> -      /* The value of this BRW_SURFACEFORMAT is 0, which tricks the<br>
> +      /* The value of this ISL_FORMAT is 0, which tricks the<br>
>         * assertion below.<br>
>         */<br>
> -      return BRW_SURFACEFORMAT_R32G32B32A32_FLOAT;<br>
> +      return ISL_FORMAT_R32G32B32A32_FLOAT;<br>
><br>
>     case MESA_FORMAT_SRGB_DXT1:<br>
>        if (brw->gen == 4 && !brw->is_g4x) {<br>
> diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c<br>
> index 9bee7dd..d83bec8 100644<br>
> --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c<br>
> +++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c<br>
> @@ -418,8 +418,8 @@ brw_update_texture_surface(struct gl_context *ctx,<br>
>        /* Implement gen6 and gen7 gather work-around */<br>
>        bool need_green_to_blue = false;<br>
>        if (for_gather) {<br>
> -         if (brw->gen == 7 && format == BRW_SURFACEFORMAT_R32G32_FLOAT) {<br>
> -            format = BRW_SURFACEFORMAT_R32G32_FLOAT_LD;<br>
> +         if (brw->gen == 7 && format == ISL_FORMAT_R32G32_FLOAT) {<br>
> +            format = ISL_FORMAT_R32G32_FLOAT_LD;<br>
>              need_green_to_blue = brw->is_haswell;<br>
>           } else if (brw->gen == 6) {<br>
>              /* Sandybridge's gather4 message is broken for integer formats.<br>
> @@ -430,19 +430,19 @@ brw_update_texture_surface(struct gl_context *ctx,<br>
>               * bits.<br>
>               */<br>
>              switch (format) {<br>
> -            case BRW_SURFACEFORMAT_R8_SINT:<br>
> -            case BRW_SURFACEFORMAT_R8_UINT:<br>
> -               format = BRW_SURFACEFORMAT_R8_UNORM;<br>
> +            case ISL_FORMAT_R8_SINT:<br>
> +            case ISL_FORMAT_R8_UINT:<br>
> +               format = ISL_FORMAT_R8_UNORM;<br>
>                 break;<br>
><br>
> -            case BRW_SURFACEFORMAT_R16_SINT:<br>
> -            case BRW_SURFACEFORMAT_R16_UINT:<br>
> -               format = BRW_SURFACEFORMAT_R16_UNORM;<br>
> +            case ISL_FORMAT_R16_SINT:<br>
> +            case ISL_FORMAT_R16_UINT:<br>
> +               format = ISL_FORMAT_R16_UNORM;<br>
>                 break;<br>
><br>
> -            case BRW_SURFACEFORMAT_R32_SINT:<br>
> -            case BRW_SURFACEFORMAT_R32_UINT:<br>
> -               format = BRW_SURFACEFORMAT_R32_FLOAT;<br>
> +            case ISL_FORMAT_R32_SINT:<br>
> +            case ISL_FORMAT_R32_UINT:<br>
> +               format = ISL_FORMAT_R32_FLOAT;<br>
>                 break;<br>
><br>
>              default:<br>
> @@ -454,7 +454,7 @@ brw_update_texture_surface(struct gl_context *ctx,<br>
>        if (obj->StencilSampling && firstImage->_BaseFormat == GL_DEPTH_STENCIL) {<br>
>           assert(brw->gen >= 8);<br>
>           mt = mt->stencil_mt;<br>
> -         format = BRW_SURFACEFORMAT_R8_UINT;<br>
> +         format = ISL_FORMAT_R8_UINT;<br>
>        }<br>
><br>
>        const int surf_index = surf_offset - &brw->wm.base.surf_offset[0];<br>
> @@ -562,7 +562,7 @@ brw_create_constant_surface(struct brw_context *brw,<br>
>                             uint32_t *out_offset)<br>
>  {<br>
>     brw_emit_buffer_surface_state(brw, out_offset, bo, offset,<br>
> -                                 BRW_SURFACEFORMAT_R32G32B32A32_FLOAT,<br>
> +                                 ISL_FORMAT_R32G32B32A32_FLOAT,<br>
>                                   size, 1, false);<br>
>  }<br>
><br>
> @@ -584,7 +584,7 @@ brw_create_buffer_surface(struct brw_context *brw,<br>
>      * with helper invocations, which cannot write to the buffer.<br>
>      */<br>
>     brw_emit_buffer_surface_state(brw, out_offset, bo, offset,<br>
> -                                 BRW_SURFACEFORMAT_RAW,<br>
> +                                 ISL_FORMAT_RAW,<br>
>                                   size, 1, true);<br>
>  }<br>
><br>
> @@ -639,16 +639,16 @@ brw_update_sol_surface(struct brw_context *brw,<br>
><br>
>     switch (num_vector_components) {<br>
>     case 1:<br>
> -      surface_format = BRW_SURFACEFORMAT_R32_FLOAT;<br>
> +      surface_format = ISL_FORMAT_R32_FLOAT;<br>
>        break;<br>
>     case 2:<br>
> -      surface_format = BRW_SURFACEFORMAT_R32G32_FLOAT;<br>
> +      surface_format = ISL_FORMAT_R32G32_FLOAT;<br>
>        break;<br>
>     case 3:<br>
> -      surface_format = BRW_SURFACEFORMAT_R32G32B32_FLOAT;<br>
> +      surface_format = ISL_FORMAT_R32G32B32_FLOAT;<br>
>        break;<br>
>     case 4:<br>
> -      surface_format = BRW_SURFACEFORMAT_R32G32B32A32_FLOAT;<br>
> +      surface_format = ISL_FORMAT_R32G32B32A32_FLOAT;<br>
>        break;<br>
>     default:<br>
>        unreachable("Invalid vector size for transform feedback output");<br>
> @@ -772,7 +772,7 @@ brw_emit_null_surface_state(struct brw_context *brw,<br>
>     }<br>
><br>
>     surf[0] = (surface_type << BRW_SURFACE_TYPE_SHIFT |<br>
> -             BRW_SURFACEFORMAT_B8G8R8A8_UNORM << BRW_SURFACE_FORMAT_SHIFT);<br>
> +             ISL_FORMAT_B8G8R8A8_UNORM << BRW_SURFACE_FORMAT_SHIFT);<br>
>     if (brw->gen < 6) {<br>
>        surf[0] |= (1 << BRW_SURFACE_WRITEDISABLE_R_SHIFT |<br>
>                   1 << BRW_SURFACE_WRITEDISABLE_G_SHIFT |<br>
> @@ -1253,7 +1253,7 @@ brw_upload_abo_surfaces(struct brw_context *brw,<br>
>              brw, intel_bo, binding->Offset, intel_bo->Base.Size - binding->Offset);<br>
><br>
>           brw_emit_buffer_surface_state(brw, &surf_offsets[i], bo,<br>
> -                                       binding->Offset, BRW_SURFACEFORMAT_RAW,<br>
> +                                       binding->Offset, ISL_FORMAT_RAW,<br>
>                                         bo->size - binding->Offset, 1, true);<br>
>        }<br>
><br>
> @@ -1355,7 +1355,7 @@ get_image_format(struct brw_context *brw, mesa_format format, GLenum access)<br>
>        /* The hardware doesn't actually support a typed format that we can use<br>
>         * so we have to fall back to untyped read/write messages.<br>
>         */<br>
> -      return BRW_SURFACEFORMAT_RAW;<br>
> +      return ISL_FORMAT_RAW;<br>
>     }<br>
>  }<br>
><br>
> @@ -1471,7 +1471,7 @@ update_image_surface(struct brw_context *brw,<br>
>        if (obj->Target == GL_TEXTURE_BUFFER) {<br>
>           struct intel_buffer_object *intel_obj =<br>
>              intel_buffer_object(obj->BufferObject);<br>
> -         const unsigned texel_size = (format == BRW_SURFACEFORMAT_RAW ? 1 :<br>
> +         const unsigned texel_size = (format == ISL_FORMAT_RAW ? 1 :<br>
>                                        _mesa_get_format_bytes(u->_ActualFormat));<br>
><br>
>           brw_emit_buffer_surface_state(<br>
> @@ -1485,7 +1485,7 @@ update_image_surface(struct brw_context *brw,<br>
>           struct intel_texture_object *intel_obj = intel_texture_object(obj);<br>
>           struct intel_mipmap_tree *mt = intel_obj->mt;<br>
><br>
> -         if (format == BRW_SURFACEFORMAT_RAW) {<br>
> +         if (format == ISL_FORMAT_RAW) {<br>
>              brw_emit_buffer_surface_state(<br>
>                 brw, surf_offset, mt->bo, mt->offset,<br>
>                 format, mt->bo->size - mt->offset, 1 /* pitch */,<br>
> @@ -1628,7 +1628,7 @@ brw_upload_cs_work_groups_surface(struct brw_context *brw)<br>
><br>
>        brw_emit_buffer_surface_state(brw, surf_offset,<br>
>                                      bo, bo_offset,<br>
> -                                    BRW_SURFACEFORMAT_RAW,<br>
> +                                    ISL_FORMAT_RAW,<br>
>                                      3 * sizeof(GLuint), 1, true);<br>
>        brw->ctx.NewDriverState |= BRW_NEW_SURFACES;<br>
>     }<br>
> diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.c b/src/mesa/drivers/dri/i965/gen6_blorp.c<br>
> index 70dc9f6..8e1da76 100644<br>
> --- a/src/mesa/drivers/dri/i965/gen6_blorp.c<br>
> +++ b/src/mesa/drivers/dri/i965/gen6_blorp.c<br>
> @@ -188,7 +188,7 @@ gen6_blorp_emit_vertices(struct brw_context *brw,<br>
>        OUT_BATCH((_3DSTATE_VERTEX_ELEMENTS << 16) | (batch_length - 2));<br>
>        /* Element 0 */<br>
>        OUT_BATCH(GEN6_VE0_VALID |<br>
> -                BRW_SURFACEFORMAT_R32G32B32A32_FLOAT << BRW_VE0_FORMAT_SHIFT |<br>
> +                ISL_FORMAT_R32G32B32A32_FLOAT << BRW_VE0_FORMAT_SHIFT |<br>
>                  0 << BRW_VE0_SRC_OFFSET_SHIFT);<br>
>        OUT_BATCH(BRW_VE1_COMPONENT_STORE_0 << BRW_VE1_COMPONENT_0_SHIFT |<br>
>                  BRW_VE1_COMPONENT_STORE_0 << BRW_VE1_COMPONENT_1_SHIFT |<br>
> @@ -196,7 +196,7 @@ gen6_blorp_emit_vertices(struct brw_context *brw,<br>
>                  BRW_VE1_COMPONENT_STORE_0 << BRW_VE1_COMPONENT_3_SHIFT);<br>
>        /* Element 1 */<br>
>        OUT_BATCH(GEN6_VE0_VALID |<br>
> -                BRW_SURFACEFORMAT_R32G32_FLOAT << BRW_VE0_FORMAT_SHIFT |<br>
> +                ISL_FORMAT_R32G32_FLOAT << BRW_VE0_FORMAT_SHIFT |<br>
>                  0 << BRW_VE0_SRC_OFFSET_SHIFT);<br>
>        OUT_BATCH(BRW_VE1_COMPONENT_STORE_SRC << BRW_VE1_COMPONENT_0_SHIFT |<br>
>                  BRW_VE1_COMPONENT_STORE_SRC << BRW_VE1_COMPONENT_1_SHIFT |<br>
> @@ -208,7 +208,7 @@ gen6_blorp_emit_vertices(struct brw_context *brw,<br>
>        /* Element 2 + i */<br>
>        OUT_BATCH(1 << GEN6_VE0_INDEX_SHIFT |<br>
>                  GEN6_VE0_VALID |<br>
> -                BRW_SURFACEFORMAT_R32G32B32A32_FLOAT << BRW_VE0_FORMAT_SHIFT |<br>
> +                ISL_FORMAT_R32G32B32A32_FLOAT << BRW_VE0_FORMAT_SHIFT |<br>
>                  (i * 4 * sizeof(float)) << BRW_VE0_SRC_OFFSET_SHIFT);<br>
>        OUT_BATCH(BRW_VE1_COMPONENT_STORE_SRC << BRW_VE1_COMPONENT_0_SHIFT |<br>
>                  BRW_VE1_COMPONENT_STORE_SRC << BRW_VE1_COMPONENT_1_SHIFT |<br>
> diff --git a/src/mesa/drivers/dri/i965/gen7_cs_state.c b/src/mesa/drivers/dri/i965/gen7_cs_state.c<br>
> index d8b0fe0..e6ee005 100644<br>
> --- a/src/mesa/drivers/dri/i965/gen7_cs_state.c<br>
> +++ b/src/mesa/drivers/dri/i965/gen7_cs_state.c<br>
> @@ -51,7 +51,7 @@ brw_upload_cs_state(struct brw_context *brw)<br>
>        brw_emit_buffer_surface_state(<br>
>           brw, &stage_state->surf_offset[<br>
>                   prog_data->binding_table.shader_time_start],<br>
> -         brw-><a href="http://shader_time.bo">shader_time.bo</a>, 0, BRW_SURFACEFORMAT_RAW,<br>
> +         brw-><a href="http://shader_time.bo">shader_time.bo</a>, 0, ISL_FORMAT_RAW,<br>
>           brw->shader_time.bo->size, 1, true);<br>
>     }<br>
><br>
> diff --git a/src/mesa/drivers/dri/i965/gen7_wm_surface_state.c b/src/mesa/drivers/dri/i965/gen7_wm_surface_state.c<br>
> index 5587a02..e30dbb3 100644<br>
> --- a/src/mesa/drivers/dri/i965/gen7_wm_surface_state.c<br>
> +++ b/src/mesa/drivers/dri/i965/gen7_wm_surface_state.c<br>
> @@ -115,10 +115,10 @@ gen7_check_surface_setup(uint32_t *surf, bool is_render_target)<br>
>     }<br>
>     if (is_multisampled) {<br>
>        switch (GET_FIELD(surf[0], BRW_SURFACE_FORMAT)) {<br>
> -      case BRW_SURFACEFORMAT_I24X8_UNORM:<br>
> -      case BRW_SURFACEFORMAT_L24X8_UNORM:<br>
> -      case BRW_SURFACEFORMAT_A24X8_UNORM:<br>
> -      case BRW_SURFACEFORMAT_R24_UNORM_X8_TYPELESS:<br>
> +      case ISL_FORMAT_I24X8_UNORM:<br>
> +      case ISL_FORMAT_L24X8_UNORM:<br>
> +      case ISL_FORMAT_A24X8_UNORM:<br>
> +      case ISL_FORMAT_R24_UNORM_X8_TYPELESS:<br>
>           assert(multisampled_surface_storage_format ==<br>
>                  GEN7_SURFACE_MSFMT_DEPTH_STENCIL);<br>
>        }<br>
> @@ -164,7 +164,7 @@ gen7_emit_null_surface_state(struct brw_context *brw,<br>
>      * "If Surface Type is SURFTYPE_NULL, this field must be TRUE."<br>
>      */<br>
>     surf[0] = BRW_SURFACE_NULL << BRW_SURFACE_TYPE_SHIFT |<br>
> -             BRW_SURFACEFORMAT_B8G8R8A8_UNORM << BRW_SURFACE_FORMAT_SHIFT |<br>
> +             ISL_FORMAT_B8G8R8A8_UNORM << BRW_SURFACE_FORMAT_SHIFT |<br>
>               GEN7_SURFACE_TILING_Y;<br>
><br>
>     surf[2] = SET_FIELD(width - 1, GEN7_SURFACE_WIDTH) |<br>
> diff --git a/src/mesa/drivers/dri/i965/gen8_draw_upload.c b/src/mesa/drivers/dri/i965/gen8_draw_upload.c<br>
> index d2c7853..ea92bf5 100644<br>
> --- a/src/mesa/drivers/dri/i965/gen8_draw_upload.c<br>
> +++ b/src/mesa/drivers/dri/i965/gen8_draw_upload.c<br>
> @@ -38,10 +38,10 @@ static bool<br>
>  is_passthru_format(uint32_t format)<br>
>  {<br>
>     switch (format) {<br>
> -   case BRW_SURFACEFORMAT_R64_PASSTHRU:<br>
> -   case BRW_SURFACEFORMAT_R64G64_PASSTHRU:<br>
> -   case BRW_SURFACEFORMAT_R64G64B64_PASSTHRU:<br>
> -   case BRW_SURFACEFORMAT_R64G64B64A64_PASSTHRU:<br>
> +   case ISL_FORMAT_R64_PASSTHRU:<br>
> +   case ISL_FORMAT_R64G64_PASSTHRU:<br>
> +   case ISL_FORMAT_R64G64B64_PASSTHRU:<br>
> +   case ISL_FORMAT_R64G64B64A64_PASSTHRU:<br>
>        return true;<br>
>     default:<br>
>        return false;<br>
> @@ -117,7 +117,7 @@ gen8_emit_vertices(struct brw_context *brw)<br>
>        OUT_BATCH((_3DSTATE_VERTEX_ELEMENTS << 16) | (3 - 2));<br>
>        OUT_BATCH((0 << GEN6_VE0_INDEX_SHIFT) |<br>
>                  GEN6_VE0_VALID |<br>
> -                (BRW_SURFACEFORMAT_R32G32B32A32_FLOAT << BRW_VE0_FORMAT_SHIFT) |<br>
> +                (ISL_FORMAT_R32G32B32A32_FLOAT << BRW_VE0_FORMAT_SHIFT) |<br>
>                  (0 << BRW_VE0_SRC_OFFSET_SHIFT));<br>
>        OUT_BATCH((BRW_VE1_COMPONENT_STORE_0 << BRW_VE1_COMPONENT_0_SHIFT) |<br>
>                  (BRW_VE1_COMPONENT_STORE_0 << BRW_VE1_COMPONENT_1_SHIFT) |<br>
> @@ -281,7 +281,7 @@ gen8_emit_vertices(struct brw_context *brw)<br>
>            brw->vs.prog_data->uses_baseinstance) {<br>
>           OUT_BATCH(GEN6_VE0_VALID |<br>
>                     brw->vb.nr_buffers << GEN6_VE0_INDEX_SHIFT |<br>
> -                   BRW_SURFACEFORMAT_R32G32_UINT << BRW_VE0_FORMAT_SHIFT);<br>
> +                   ISL_FORMAT_R32G32_UINT << BRW_VE0_FORMAT_SHIFT);<br>
>           OUT_BATCH((BRW_VE1_COMPONENT_STORE_SRC << BRW_VE1_COMPONENT_0_SHIFT) |<br>
>                     (BRW_VE1_COMPONENT_STORE_SRC << BRW_VE1_COMPONENT_1_SHIFT) |<br>
>                     (BRW_VE1_COMPONENT_STORE_0 << BRW_VE1_COMPONENT_2_SHIFT) |<br>
> @@ -298,7 +298,7 @@ gen8_emit_vertices(struct brw_context *brw)<br>
>     if (brw->vs.prog_data->uses_drawid) {<br>
>        OUT_BATCH(GEN6_VE0_VALID |<br>
>                  ((brw->vb.nr_buffers + 1) << GEN6_VE0_INDEX_SHIFT) |<br>
> -                (BRW_SURFACEFORMAT_R32_UINT << BRW_VE0_FORMAT_SHIFT));<br>
> +                (ISL_FORMAT_R32_UINT << BRW_VE0_FORMAT_SHIFT));<br>
>        OUT_BATCH((BRW_VE1_COMPONENT_STORE_SRC << BRW_VE1_COMPONENT_0_SHIFT) |<br>
>                     (BRW_VE1_COMPONENT_STORE_0 << BRW_VE1_COMPONENT_1_SHIFT) |<br>
>                     (BRW_VE1_COMPONENT_STORE_0 << BRW_VE1_COMPONENT_2_SHIFT) |<br>
> diff --git a/src/mesa/drivers/dri/i965/gen8_surface_state.c b/src/mesa/drivers/dri/i965/gen8_surface_state.c<br>
> index 08f83f3..501531d 100644<br>
> --- a/src/mesa/drivers/dri/i965/gen8_surface_state.c<br>
> +++ b/src/mesa/drivers/dri/i965/gen8_surface_state.c<br>
> @@ -71,7 +71,7 @@ gen8_emit_null_surface_state(struct brw_context *brw,<br>
>     uint32_t *surf = gen8_allocate_surface_state(brw, out_offset, -1);<br>
><br>
>     surf[0] = BRW_SURFACE_NULL << BRW_SURFACE_TYPE_SHIFT |<br>
> -             BRW_SURFACEFORMAT_B8G8R8A8_UNORM << BRW_SURFACE_FORMAT_SHIFT |<br>
> +             ISL_FORMAT_B8G8R8A8_UNORM << BRW_SURFACE_FORMAT_SHIFT |<br>
>               GEN8_SURFACE_TILING_Y;<br>
>     surf[2] = SET_FIELD(width - 1, GEN7_SURFACE_WIDTH) |<br>
>               SET_FIELD(height - 1, GEN7_SURFACE_HEIGHT);<br>
> --<br>
> 2.9.2<br>
><br>
> _______________________________________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br></p>