<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jul 31, 2016 at 12:43 AM, Pohjolainen, Topi <span dir="ltr"><<a href="mailto:topi.pohjolainen@intel.com" target="_blank">topi.pohjolainen@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Sun, Jul 31, 2016 at 10:32:33AM +0300, Pohjolainen, Topi wrote:<br>
> On Tue, Jul 26, 2016 at 03:11:06PM -0700, Jason Ekstrand wrote:<br>
> > ---<br>
> >  src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c | 3 ++-<br>
> >  1 file changed, 2 insertions(+), 1 deletion(-)<br>
> ><br>
> > diff --git a/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
> > index 8c63aa6..1911eef 100644<br>
> > --- a/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
> > +++ b/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
> > @@ -3204,7 +3204,8 @@ intel_miptree_get_aux_isl_<wbr>surf(struct brw_context *brw,<br>
> >     } else if (mt->fast_clear_state != INTEL_FAST_CLEAR_STATE_NO_MCS) {<br>
> >        *usage = ISL_AUX_USAGE_CCS_D;<br>
> >     } else {<br>
> > -      unreachable("Invalid MCS miptree");<br>
> > +      *usage = ISL_AUX_USAGE_NONE;<br>
><br>
> I'm guessing you'd like to call intel_miptree_get_aux_isl_<wbr>surf()<br>
> unconditionally in one of the following patches? After reading them quite a<br>
> bit this is still not obvious to me, and I think some rational is needed in<br>
> the commit message.<br>
<br>
</span>It looks that this is not needed until patch 13?<br></blockquote><div><br></div><div>patch 10 actually<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
><br>
> > +      return;<br>
> >     }<br>
> ><br>
> >     /* Figure out the format and tiling of the auxiliary surface */<br>
> > --<br>
> > 2.5.0.400.gff86faf<br>
> ><br>
> > ______________________________<wbr>_________________<br>
> > mesa-dev mailing list<br>
> > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> > <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div></div>