<div dir="ltr"><div>I wish we could come up with some clever way to not have to repeat the multisample positions all over the place. Unfortunately, I don't have any particularly fastastic ideas on how. We can figure that out later. Patches 1 and 2 are<br><br></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 8, 2016 at 2:57 PM, Anuj Phogat <span dir="ltr"><<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">V1: Add multisample positions (Nanley)<br>
V2: Fix 8x sample positions (Anuj)<br>
<br>
Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br>
---<br>
src/intel/vulkan/genX_<wbr>pipeline_util.h | 47 ++++++++++++++++++++++++++++++<wbr>+++++<br>
1 file changed, 47 insertions(+)<br>
<br>
diff --git a/src/intel/vulkan/genX_<wbr>pipeline_util.h b/src/intel/vulkan/genX_<wbr>pipeline_util.h<br>
index 52d386a..621edef 100644<br>
--- a/src/intel/vulkan/genX_<wbr>pipeline_util.h<br>
+++ b/src/intel/vulkan/genX_<wbr>pipeline_util.h<br>
@@ -470,6 +470,7 @@ emit_ms_state(struct anv_pipeline *pipeline,<br>
anv_batch_emit(&pipeline-><wbr>batch, GENX(3DSTATE_MULTISAMPLE), ms) {<br>
ms.NumberofMultisamples = log2_samples;<br>
<br>
+#if GEN_GEN >= 8<br>
/* The PRM says that this bit is valid only for DX9:<br>
*<br>
* SW can choose to set this bit only for DX9 API. DX10/OGL API's<br>
@@ -477,6 +478,52 @@ emit_ms_state(struct anv_pipeline *pipeline,<br>
*/<br>
ms.PixelPositionOffsetEnable = false;<br>
ms.PixelLocation = CENTER;<br>
+#else<br>
+ ms.PixelLocation = PIXLOC_CENTER;<br>
+<br>
+ switch (samples) {<br>
+ case 1:<br>
+ ms.Sample0XOffset = 0.5;<br>
+ ms.Sample0YOffset = 0.5;<br>
+ break;<br>
+ case 2:<br>
+ ms.Sample0XOffset = 0.25;<br>
+ ms.Sample0YOffset = 0.25;<br>
+ ms.Sample1XOffset = 0.75;<br>
+ ms.Sample1YOffset = 0.75;<br>
+ break;<br>
+ case 4:<br>
+ ms.Sample0XOffset = 0.375;<br>
+ ms.Sample0YOffset = 0.125;<br>
+ ms.Sample1XOffset = 0.875;<br>
+ ms.Sample1YOffset = 0.375;<br>
+ ms.Sample2XOffset = 0.125;<br>
+ ms.Sample2YOffset = 0.625;<br>
+ ms.Sample3XOffset = 0.625;<br>
+ ms.Sample3YOffset = 0.875;<br>
+ break;<br>
+ case 8:<br>
+ ms.Sample0XOffset = 0.4375;<br>
+ ms.Sample0YOffset = 0.5625;<br>
+ ms.Sample1XOffset = 0.5625;<br>
+ ms.Sample1YOffset = 0.8125;<br>
+ ms.Sample2XOffset = 0.6875;<br>
+ ms.Sample2YOffset = 0.1875;<br>
+ ms.Sample3XOffset = 0.8125;<br>
+ ms.Sample3YOffset = 0.6875;<br>
+ ms.Sample4XOffset = 0.0625;<br>
+ ms.Sample4YOffset = 0.4375;<br>
+ ms.Sample5XOffset = 0.3125;<br>
+ ms.Sample5YOffset = 0.0625;<br>
+ ms.Sample6XOffset = 0.9375;<br>
+ ms.Sample6YOffset = 0.3125;<br>
+ ms.Sample7XOffset = 0.1875;<br>
+ ms.Sample7YOffset = 0.9375;<br>
+ break;<br>
+ default:<br>
+ break;<br>
+ }<br>
+#endif<br>
}<br>
<br>
anv_batch_emit(&pipeline-><wbr>batch, GENX(3DSTATE_SAMPLE_MASK), sm) {<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.5.5<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div></div></div>