<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Aug 9, 2016 at 11:04 AM, Anuj Phogat <span dir="ltr"><<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, Aug 8, 2016 at 5:09 PM, Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote:<br>
> Does this fix any tests? If so, we should say so in the commit message.<br>
> With that updated,<br>
><br>
</span>No it doesn't. It surprised me too but it looks like cts don't have enough<br>
multisampling tests.<br></blockquote><div><br></div><div>That's an understatement.... In that case, it looks like this is a strict improvement, so go ahead with my R-B.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
> Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br>
><br>
> On Mon, Aug 8, 2016 at 2:57 PM, Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>> wrote:<br>
>><br>
>> Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br>
>> ---<br>
>> src/intel/vulkan/gen7_<wbr>pipeline.c | 16 +---------------<br>
>> 1 file changed, 1 insertion(+), 15 deletions(-)<br>
>><br>
>> diff --git a/src/intel/vulkan/gen7_<wbr>pipeline.c<br>
>> b/src/intel/vulkan/gen7_<wbr>pipeline.c<br>
>> index 5395e79..17d7ccc 100644<br>
>> --- a/src/intel/vulkan/gen7_<wbr>pipeline.c<br>
>> +++ b/src/intel/vulkan/gen7_<wbr>pipeline.c<br>
>> @@ -81,21 +81,7 @@ genX(graphics_pipeline_create)<wbr>(<br>
>> pCreateInfo-><wbr>pRasterizationState, extra);<br>
>> emit_3dstate_streamout(<wbr>pipeline, pCreateInfo-><wbr>pRasterizationState);<br>
>><br>
>> - if (pCreateInfo-><wbr>pMultisampleState &&<br>
>> - pCreateInfo-><wbr>pMultisampleState-><wbr>rasterizationSamples > 1)<br>
>> -<br>
>> anv_finishme("VK_STRUCTURE_<wbr>TYPE_PIPELINE_MULTISAMPLE_<wbr>STATE_CREATE_INFO");<br>
>> -<br>
>> - uint32_t samples = 1;<br>
>> - uint32_t log2_samples = __builtin_ffs(samples) - 1;<br>
>> -<br>
>> - anv_batch_emit(&pipeline-><wbr>batch, GENX(3DSTATE_MULTISAMPLE), ms) {<br>
>> - ms.PixelLocation = PIXLOC_CENTER;<br>
>> - ms.NumberofMultisamples = log2_samples;<br>
>> - }<br>
>> -<br>
>> - anv_batch_emit(&pipeline-><wbr>batch, GENX(3DSTATE_SAMPLE_MASK), sm) {<br>
>> - sm.SampleMask = 0xff;<br>
>> - }<br>
>> + emit_ms_state(pipeline, pCreateInfo-><wbr>pMultisampleState);<br>
>><br>
>> const struct brw_vs_prog_data *vs_prog_data =<br>
>> get_vs_prog_data(pipeline);<br>
>><br>
>> --<br>
>> 2.5.5<br>
>><br>
>> ______________________________<wbr>_________________<br>
>> mesa-dev mailing list<br>
>> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
>> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
><br>
><br>
</div></div></blockquote></div><br></div></div>