<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Aug 16, 2016 at 1:54 PM, Francisco Jerez <span dir="ltr"><<a href="mailto:currojerez@riseup.net" target="_blank">currojerez@riseup.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This may have been the reason people ran into problems with<br>
non-uniform HALT instructions and ended up using the inefficient<br>
ANY16H/ANY8H predicates instead of ANY4H or NORMAL in order to prevent<br>
non-uniform discard. The HALT instruction is able to handle<br>
non-uniform execution masks just fine.<br></blockquote><div><br></div><div>Do you know why we were setting MASK_DISABLE? Perhaps we were getting the exec size wrong before? In any case, if there's no piglig problems with patch 2, then I'll believe it works.<br><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
src/mesa/drivers/dri/i965/brw_<wbr>fs_generator.cpp | 4 ----<br>
1 file changed, 4 deletions(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/<wbr>brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/<wbr>brw_fs_generator.cpp<br>
index 647950f..22190f8 100644<br>
--- a/src/mesa/drivers/dri/i965/<wbr>brw_fs_generator.cpp<br>
+++ b/src/mesa/drivers/dri/i965/<wbr>brw_fs_generator.cpp<br>
@@ -1053,11 +1053,7 @@ fs_generator::generate_<wbr>discard_jump(fs_inst *inst)<br>
* current block (or the program).<br>
*/<br>
this->discard_halt_patches.<wbr>push_tail(new(mem_ctx) ip_record(p->nr_insn));<br>
-<br>
- brw_push_insn_state(p);<br>
- brw_set_default_mask_control(<wbr>p, BRW_MASK_DISABLE);<br>
gen6_HALT(p);<br>
- brw_pop_insn_state(p);<br>
}<br>
<br>
void<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.9.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>