<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> </head> <body> <meta content="text/html; charset=UTF-8"> <style type="text/css" style="">  </style> <div dir="ltr"> <div id="x_divtagdefaultwrapper" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif"> <p>Looks good to me.</p> <p><br> </p> <p>Reviewed-by: Neha Bhende <bhenden@vmware.com><br> </p> <p><br> </p> <div id="x_Signature"> <div id="x_divtagdefaultwrapper" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif"> <p>Regards,</p> <p>Neha<br> </p> </div> </div> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Brian Paul <brianp@vmware.com><br> <b>Sent:</b> Wednesday, August 17, 2016 7:40:13 AM<br> <b>To:</b> mesa-dev@lists.freedesktop.org<br> <b>Cc:</b> Charmaine Lee; Neha Bhende<br> <b>Subject:</b> [PATCH 2/2] svga: fix src/dst typo in can_blit_via_copy_region_vgpu10()</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">The function was always returning false because of this typo.<br> <br> Retested with piglit. There's some sRGB-related blit failures, but<br> that seems unrelated.<br> ---<br> src/gallium/drivers/svga/svga_pipe_blit.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/src/gallium/drivers/svga/svga_pipe_blit.c b/src/gallium/drivers/svga/svga_pipe_blit.c<br> index 1f6382e..9d8c4fe 100644<br> --- a/src/gallium/drivers/svga/svga_pipe_blit.c<br> +++ b/src/gallium/drivers/svga/svga_pipe_blit.c<br> @@ -223,7 +223,7 @@ can_blit_via_copy_region_vgpu10(struct svga_context *svga,<br> return false;<br> <br> stex = svga_texture(blit_info->src.resource);<br> - dtex = svga_texture(blit_info->src.resource);<br> + dtex = svga_texture(blit_info->dst.resource);<br> <br> // can't copy within one resource<br> if (stex->handle == dtex->handle)<br> -- <br> 1.9.1<br> <br> </div> </span></font> </body> </html>