<div dir="ltr"><div><div>Hi,<br><br></div>Do you have a test case?<br><br></div>Marek<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 18, 2016 at 1:44 AM, Tobias Klausmann <span dir="ltr"><<a href="mailto:tobias.johannes.klausmann@mni.thm.de" target="_blank">tobias.johannes.klausmann@mni.thm.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">OpenMW tries to upload a new surface (mouse pointer) which fails in the now<br>
guarded update_framebuffer_size() as the surface is NULL.<br>
<br>
This is not inteded as a real "fix", as it would just hide the immediate crash.<br>
<br>
So if somebody could take a look at this...<br>
<br>
Reported-by: <<a href="mailto:ovariegata@yahoo.com">ovariegata@yahoo.com</a>><br>
Signed-off-by: Tobias Klausmann <<a href="mailto:tobias.johannes.klausmann@mni.thm.de">tobias.johannes.klausmann@<wbr>mni.thm.de</a>><br>
---<br>
src/mesa/state_tracker/st_<wbr>atom_framebuffer.c | 6 ++++--<br>
1 file changed, 4 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/mesa/state_tracker/st_<wbr>atom_framebuffer.c b/src/mesa/state_tracker/st_<wbr>atom_framebuffer.c<br>
index ea41d9d..3ee4ea5 100644<br>
--- a/src/mesa/state_tracker/st_<wbr>atom_framebuffer.c<br>
+++ b/src/mesa/state_tracker/st_<wbr>atom_framebuffer.c<br>
@@ -177,8 +177,10 @@ update_framebuffer_state( struct st_context *st )<br>
/* rendering to a GL texture, may have to update surface */<br>
st_update_renderbuffer_<wbr>surface(st, strb);<br>
}<br>
- pipe_surface_reference(&<wbr>framebuffer->zsbuf, strb->surface);<br>
- update_framebuffer_size(<wbr>framebuffer, strb->surface);<br>
+ if (strb->surface) {<br>
+ pipe_surface_reference(&<wbr>framebuffer->zsbuf, strb->surface);<br>
+ update_framebuffer_size(<wbr>framebuffer, strb->surface);<br>
+ }<br>
}<br>
else {<br>
strb = st_renderbuffer(fb-><wbr>Attachment[BUFFER_STENCIL].<wbr>Renderbuffer);<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.9.2<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>