<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 19, 2016 at 3:21 AM, Tapani Pälli <span dir="ltr"><<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
On 08/19/2016 11:34 AM, Jason Ekstrand wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
<br>
On Fri, Aug 19, 2016 at 12:51 AM, Iago Toral <<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a><br></span><span class="">
<mailto:<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>>> wrote:<br>
<br>
Reviewed-by: Iago Toral Quiroga <<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a><br></span>
<mailto:<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>>><span class=""><br>
<br>
On Fri, 2016-08-19 at 10:39 +0300, Tapani Pälli wrote:<br>
> (warning: ‘surftype’ may be used uninitialized ...)<br>
><br>
> Signed-off-by: Tapani Pälli <<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a><br></span>
<mailto:<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a><wbr>>><div><div class="h5"><br>
> ---<br>
> src/mesa/drivers/dri/i965/gen6<wbr>_blorp.c | 2 ++<br>
> src/mesa/drivers/dri/i965/gen7<wbr>_blorp.c | 2 ++<br>
> 2 files changed, 4 insertions(+)<br>
><br>
> diff --git a/src/mesa/drivers/dri/i965/ge<wbr>n6_blorp.c<br>
> b/src/mesa/drivers/dri/i965/ge<wbr>n6_blorp.c<br>
> index abdcf17..6476fa6 100644<br>
> --- a/src/mesa/drivers/dri/i965/ge<wbr>n6_blorp.c<br>
> +++ b/src/mesa/drivers/dri/i965/ge<wbr>n6_blorp.c<br>
> @@ -711,6 +711,8 @@ gen6_blorp_emit_depth_stencil_<wbr>config(struct<br>
> brw_context *brw,<br>
> case ISL_SURF_DIM_3D:<br>
> surftype = BRW_SURFACE_3D;<br>
> break;<br>
> + default:<br>
> + unreachable("not reached");<br>
> }<br>
><br>
> /* 3DSTATE_DEPTH_BUFFER */<br>
> diff --git a/src/mesa/drivers/dri/i965/ge<wbr>n7_blorp.c<br>
> b/src/mesa/drivers/dri/i965/ge<wbr>n7_blorp.c<br>
> index d35d6c6..96e2b07 100644<br>
> --- a/src/mesa/drivers/dri/i965/ge<wbr>n7_blorp.c<br>
> +++ b/src/mesa/drivers/dri/i965/ge<wbr>n7_blorp.c<br>
> @@ -497,6 +497,8 @@ gen7_blorp_emit_depth_stencil_<wbr>config(struct<br>
> brw_context *brw,<br>
> case ISL_SURF_DIM_3D:<br>
> surftype = BRW_SURFACE_3D;<br>
> break;<br>
> + default:<br>
> + unreachable("not reached");<br>
> }<br>
<br>
<br>
Thanks for fixing this but I'm about to push a series that deletes all<br>
of this code and, with it, go the warnings. :)<br>
</div></div></blockquote>
<br>
ah noticed! one new warning though:<br>
<br>
genX_blorp_exec.c:132:1: warning: "/*" within comment [-Wcomment]<br>
/* 3DSTATE_URB_VS<br></blockquote><div><br></div><div>Yeah... I noticed that a few minutes ago<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
> /* 3DSTATE_DEPTH_BUFFER */<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br></span>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a> <mailto:<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedes<wbr>ktop.org</a>><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
<<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org<wbr>/mailman/listinfo/mesa-dev</a>><br>
<br>
<br>
</blockquote>
</blockquote></div><br></div></div>