<div dir="ltr">pushed<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 22, 2016 at 10:15 AM, Lionel Landwerlin <span dir="ltr"><<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>I should start to remember to put
someone in Cc...<div><div class="h5"><br>
<br>
On 13/08/16 01:30, Jason Ekstrand wrote:<br>
</div></div></div>
<blockquote type="cite"><div><div class="h5">
<div dir="ltr">
<div>Much better. Thanks!<br>
<br>
</div>
Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>><br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Aug 12, 2016 at 5:00 PM, Lionel
Landwerlin <span dir="ltr"><<a href="mailto:llandwerlin@gmail.com" target="_blank">llandwerlin@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>We let the user believe we support some transfer
formats which we don't.<br>
This can lead to crashes when actually trying to use those
formats for<br>
example on dEQP-VK.api.copy_and_blit.imag<wbr>e_to_image.*
tests.<br>
<br>
Let all formats we can render to or sample from as meta
implements transfers<br>
using attachments.<br>
<br>
Signed-off-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a><wbr>><br>
Cc: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>><br>
---<br>
</span> src/intel/vulkan/anv_formats.<wbr>c | 22
++++++----------------<br>
1 file changed, 6 insertions(+), 16 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_formats<wbr>.c
b/src/intel/vulkan/anv_formats<wbr>.c<br>
index b26e48a..b06e29b 100644<br>
--- a/src/intel/vulkan/anv_formats<wbr>.c<br>
+++ b/src/intel/vulkan/anv_formats<wbr>.c<br>
@@ -507,25 +507,15 @@ VkResult anv_GetPhysicalDeviceImageForm<wbr>atProperties(<br>
sampleCounts = isl_device_get_sample_counts(&<wbr>physical_device->isl_dev);<br>
}<br>
<br>
- if (usage & VK_IMAGE_USAGE_TRANSFER_SRC_BI<wbr>T) {<br>
- /* Meta implements transfers by sampling from the
source image. */<br>
<span>- if (!(format_feature_flags &
VK_FORMAT_FEATURE_SAMPLED_IMAG<wbr>E_BIT)) {<br>
</span>- goto unsupported;<br>
- }<br>
- }<br>
-<br>
-#if 0<br>
- if (usage & VK_IMAGE_USAGE_TRANSFER_DST_BI<wbr>T) {<br>
<span>- if (anv_format_for_vk_format(form<wbr>at)->has_stencil)
{<br>
- /* Not yet implemented because copying to a
W-tiled surface is crazy<br>
- * hard.<br>
- */<br>
- anv_finishme("support
VK_IMAGE_USAGE_TRANSFER_DST_BI<wbr>T for "<br>
- "stencil format");<br>
</span>+ if (usage & (VK_IMAGE_USAGE_TRANSFER_SRC_B<wbr>IT
|<br>
+ VK_IMAGE_USAGE_TRANSFER_DST_BI<wbr>T)) {<br>
+ /* Accept transfers on anything we can sample from or
renderer to. */<br>
<span>+ if (!(format_feature_flags
& (VK_FORMAT_FEATURE_COLOR_ATTAC<wbr>HMENT_BIT |<br>
+
VK_FORMAT_FEATURE_DEPTH_STENCI<wbr>L_ATTACHMENT_BIT |<br>
+
VK_FORMAT_FEATURE_SAMPLED_IMAG<wbr>E_BIT))) {<br>
</span>
<div>
<div> goto unsupported;<br>
}<br>
}<br>
-#endif<br>
<br>
if (usage & VK_IMAGE_USAGE_SAMPLED_BIT) {<br>
if (!(format_feature_flags &
VK_FORMAT_FEATURE_SAMPLED_IMAG<wbr>E_BIT)) {<br>
--<br>
2.8.1<br>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
</div></div><pre>______________________________<wbr>_________________
mesa-dev mailing list
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a>
</pre>
</blockquote>
<p><br>
</p>
</div>
</blockquote></div><br></div>