<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 23, 2016 at 2:18 PM, Nanley Chery <span dir="ltr"><<a href="mailto:nanleychery@gmail.com" target="_blank">nanleychery@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, Aug 23, 2016 at 02:13:26PM -0700, Jason Ekstrand wrote:<br>
> In ca2a8e56285, we updated the format table to add more formats (most of<br>
> which are new on SKL) but accidentally marked some integer formats as<br>
> filterable. You can't filter an integer format.<br>
><br>
> Signed-off-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br>
<br>
</span>This patch is<br>
<br>
Reviewed-by: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>><br></blockquote><div><br></div><div>Thanks for catching my mistake and for the quick review!<br><br></div><div>--Jason<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
> ---<br>
> src/intel/isl/isl_format.c | 16 ++++++++--------<br>
> 1 file changed, 8 insertions(+), 8 deletions(-)<br>
><br>
> diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c<br>
> index bced4ff..8507cc5 100644<br>
> --- a/src/intel/isl/isl_format.c<br>
> +++ b/src/intel/isl/isl_format.c<br>
> @@ -237,10 +237,10 @@ static const struct surface_format_info format_info[] = {<br>
> SF(45, 45, x, x, x, x, x, x, x, x, P4A4_UNORM_PALETTE1)<br>
> SF(45, 45, x, x, x, x, x, x, x, x, A4P4_UNORM_PALETTE1)<br>
> SF( x, x, x, x, x, x, x, x, x, x, Y8_UNORM)<br>
> - SF(90, 90, x, x, x, x, x, x, x, x, L8_UINT)<br>
> - SF(90, 90, x, x, x, x, x, x, x, x, L8_SINT)<br>
> - SF(90, 90, x, x, x, x, x, x, x, x, I8_UINT)<br>
> - SF(90, 90, x, x, x, x, x, x, x, x, I8_SINT)<br>
> + SF(90, x, x, x, x, x, x, x, x, x, L8_UINT)<br>
> + SF(90, x, x, x, x, x, x, x, x, x, L8_SINT)<br>
> + SF(90, x, x, x, x, x, x, x, x, x, I8_UINT)<br>
> + SF(90, x, x, x, x, x, x, x, x, x, I8_SINT)<br>
> SF(45, 45, x, x, x, x, x, x, x, x, DXT1_RGB_SRGB)<br>
> SF( Y, Y, x, x, x, x, x, x, x, x, R1_UNORM)<br>
> SF( Y, Y, x, Y, Y, x, x, x, 60, x, YCRCB_NORMAL)<br>
> @@ -287,8 +287,8 @@ static const struct surface_format_info format_info[] = {<br>
> SF(80, 80, x, x, x, x, x, x, x, x, EAC_SIGNED_R11)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, EAC_SIGNED_RG11)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ETC2_SRGB8)<br>
> - SF(90, 90, x, x, x, x, 75, x, x, x, R16G16B16_UINT)<br>
> - SF(90, 90, x, x, x, x, 75, x, x, x, R16G16B16_SINT)<br>
> + SF(90, x, x, x, x, x, 75, x, x, x, R16G16B16_UINT)<br>
> + SF(90, x, x, x, x, x, 75, x, x, x, R16G16B16_SINT)<br>
> SF( x, x, x, x, x, x, 75, x, x, x, R32_SFIXED)<br>
> SF( x, x, x, x, x, x, 75, x, x, x, R10G10B10A2_SNORM)<br>
> SF( x, x, x, x, x, x, 75, x, x, x, R10G10B10A2_USCALED)<br>
> @@ -305,8 +305,8 @@ static const struct surface_format_info format_info[] = {<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ETC2_SRGB8_PTA)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ETC2_EAC_RGBA8)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ETC2_EAC_SRGB8_A8)<br>
> - SF(90, 90, x, x, x, x, 75, x, x, x, R8G8B8_UINT)<br>
> - SF(90, 90, x, x, x, x, 75, x, x, x, R8G8B8_SINT)<br>
> + SF(90, x, x, x, x, x, 75, x, x, x, R8G8B8_UINT)<br>
> + SF(90, x, x, x, x, x, 75, x, x, x, R8G8B8_SINT)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ASTC_LDR_2D_4X4_FLT16)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ASTC_LDR_2D_5X4_FLT16)<br>
> SF(80, 80, x, x, x, x, x, x, x, x, ASTC_LDR_2D_5X5_FLT16)<br>
> --<br>
> 2.5.0.400.gff86faf<br>
><br>
</div></div>> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div></div>