<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Aug 25, 2016 at 1:10 AM, Pohjolainen, Topi <<a href="mailto:topi.pohjolainen@gmail.com" target="_blank">topi.pohjolainen@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class=""><div class="h5">On Fri, Aug 19, 2016 at 09:55:37AM -0700, Jason Ekstrand wrote: > This little patch series is even more blorp code churn. The end objective > is in patch 31 which pulls blorp into its own directory completely separate > from the i965 dri driver. > > Jason Ekstrand (31): > i965/blorp: Add a blorp_context struct and init/finish funcs > i965/blorp: Add an internal shader cache > i965/blorp/genX: Add helpers for allocating various bits of state > i965/blorp/genX: Pull emit_3dstate_multisample into a helper > i965/gen6: Refactor gen6_upload_urb > i965/blorp: Use gen6_upload_urb > i965/blorp/genX: Move emit_urb_config into another helper > i965/blorp: Add driver mocs settings to the context > i965/blorp: Pull emit_surface_state into genX_blorp_exec.c > i965/blorp: Use blorp_address in brw_blorp_surface instead of > bo+offset > i965/blorp/genX: Add a blorp_surface_reloc helper > i965/blorp: Shorten binding table index enum names > i965/blorp: Use BT_INDEX enums for setting up the binding table > i965/blorp: Add a helper for allocating binding tables and surface > states > i965/blorp/exec: Refactor to use blorp_context and a void *batch > i965/blorp: Pull the guts of blorp_exec into a driver-agnostic header > i965/blorp: Move the guts of brw_blorp_exec into genX_blorp_exec.c > i965/blorp: Add an "exec" function pointer to blorp_context > i965/meta_util: Take an isl_device in get_fast_clear_rect > i965/blorp: Take a blorp_context in compile_nir_shader > i965/blorp: Get rid of brw_context > i965/blorp: Make blorp_addres::buffer a void* > i965/blorp: Add a fast_clear_op enum > i965: Move the hiz_op enum to blorp > i965/blorp: Get rid of most brw and mesa includes > i965: Roll brw_get_ccs_resolve_rect into blorp_ccs_resolve > i965: Move get_fast_clear_rect to blorp_clear.c > i965: Move the type_size function declartaions to brw_nir.h > i965/blorp: Use isl_format_get_depth_format for setting depth formats > i965/blorp: Remove the remaining brw prefixes from the blorp.h API > i965: Move blorp into src/intel/blorp </div></div>Patches 28-31 also look good to me and are: Reviewed-by: Topi Pohjolainen <<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.com</a>> We discussed a few things offline. Among other things we agreed to add as a follow-up a word or two about the low 12 bits of aux address in patch 11 giving rational to the delta argument of blorp_surface_reloc(). In any case I think all patches are now reviewed. </blockquote><div> </div><div>I'm still missing a couple. You can find everything here: <a href="https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/blorp-vulkan">https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/blorp-vulkan</a> </div><div>In particular, a review of the first patch to flatten makefiles would be nice. </div><div>--Jason </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div class="h5"> > > <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 1 + > src/intel/Makefile.am | 2 +- > src/intel/blorp/Makefile.am | 46 + > src/intel/blorp/Makefile.sources | 7 + > src/{mesa/drivers/dri/i965 => intel/blorp}/blorp.c | 364 +++--- > src/intel/blorp/blorp.h | 144 +++ > .../drivers/dri/i965 => intel/blorp}/blorp_blit.c | 105 +- > src/intel/blorp/blorp_clear.c | 335 ++++++ > src/intel/blorp/blorp_genX_exec.h | 1129 +++++++++++++++++++ > .../drivers/dri/i965 => intel/blorp}/blorp_priv.h | 90 +- > src/mesa/drivers/dri/i965/Makefile.am | 1 + > src/mesa/drivers/dri/i965/Makefile.sources | 5 - > src/mesa/drivers/dri/i965/blorp.h | 92 -- > src/mesa/drivers/dri/i965/blorp_clear.c | 201 ---- > src/mesa/drivers/dri/i965/brw_blorp.c | 185 +++- > src/mesa/drivers/dri/i965/brw_blorp.h | 6 +- > src/mesa/drivers/dri/i965/brw_clear.c | 4 +- > src/mesa/drivers/dri/i965/brw_context.c | 7 + > src/mesa/drivers/dri/i965/brw_context.h | 8 +- > src/mesa/drivers/dri/i965/brw_meta_util.c | 158 --- > src/mesa/drivers/dri/i965/brw_meta_util.h | 12 - > src/mesa/drivers/dri/i965/brw_nir.h | 9 +- > src/mesa/drivers/dri/i965/brw_shader.h | 6 - > src/mesa/drivers/dri/i965/gen6_urb.c | 56 +- > src/mesa/drivers/dri/i965/gen8_depth_state.c | 12 +- > src/mesa/drivers/dri/i965/genX_blorp_exec.c | 1171 +++----------------- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 18 +- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 +- > src/mesa/drivers/dri/i965/intel_resolve_map.c | 2 +- > src/mesa/drivers/dri/i965/intel_resolve_map.h | 22 +- > 30 files changed, 2263 insertions(+), 1937 deletions(-) > create mode 100644 src/intel/blorp/Makefile.am > create mode 100644 src/intel/blorp/Makefile.sources > rename src/{mesa/drivers/dri/i965 => intel/blorp}/blorp.c (55%) > create mode 100644 src/intel/blorp/blorp.h > rename src/{mesa/drivers/dri/i965 => intel/blorp}/blorp_blit.c (95%) > create mode 100644 src/intel/blorp/blorp_clear.c > create mode 100644 src/intel/blorp/blorp_genX_exec.h > rename src/{mesa/drivers/dri/i965 => intel/blorp}/blorp_priv.h (82%) > delete mode 100644 src/mesa/drivers/dri/i965/blorp.h > delete mode 100644 src/mesa/drivers/dri/i965/blorp_clear.c > > -- > 2.5.0.400.gff86faf > </div></div>> _______________________________________________ > mesa-dev mailing list > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div></div>