<div dir="ltr"><div><div><div>If you wanted to be extra spiffy, you could add a discard helper to nir_builder and make it do it automatically :) </div>In any case, </div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div></div><div class="gmail_extra"> <div class="gmail_quote">On Fri, Aug 26, 2016 at 6:13 PM, Eric Anholt <<a href="mailto:eric@anholt.net" target="_blank">eric@anholt.net</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vc4 is about to start using the shader info field to set up discard handling. --- src/compiler/nir/nir_lower_bitmap.c | 2 ++ src/compiler/nir/nir_lower_clip.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/compiler/nir/nir_lower_bitmap.c b/src/compiler/nir/nir_lower_bitmap.c index bd5c30f8dc19..216bedf57403 100644 --- a/src/compiler/nir/nir_lower_bitmap.c +++ b/src/compiler/nir/nir_lower_bitmap.c @@ -107,6 +107,8 @@ lower_bitmap(nir_shader *shader, nir_builder *b, discard = nir_intrinsic_instr_create(shader, nir_intrinsic_discard_if); discard->src[0] = nir_src_for_ssa(cond); nir_builder_instr_insert(b, &discard->instr); + + shader->info.fs.uses_discard = true; } static void diff --git a/src/compiler/nir/nir_lower_clip.c b/src/compiler/nir/nir_lower_clip.c index 80db653a4286..b74e6cca39f4 100644 --- a/src/compiler/nir/nir_lower_clip.c +++ b/src/compiler/nir/nir_lower_clip.c @@ -286,6 +286,8 @@ lower_clip_fs(nir_function_impl *impl, unsigned ucp_enables, nir_intrinsic_discard_if); discard->src[0] = nir_src_for_ssa(cond); nir_builder_instr_insert(&b, &discard->instr); + + b.shader->info.fs.uses_discard = true; } } } -- 2.9.3 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>