<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 1, 2016 at 10:55 PM, Pohjolainen, Topi <span dir="ltr"><<a href="mailto:topi.pohjolainen@gmail.com" target="_blank">topi.pohjolainen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, Sep 01, 2016 at 08:40:52AM -0700, Jason Ekstrand wrote:<br>
> We're not doing layered blits yet are we? Perhaps this can wait until<br>
> then?<br>
<br>
</span>No but as previous patch stops suppressing number of layers in<br>
brw_blorp_surface_info_init() unonditionally these asserts will start to<br>
fire. This actually points a flaw in the order of patches, this will need to<br>
precede the previous.<br></blockquote><div><br></div><div>Right. I didn't think about that.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Alternative is to add signaling to brw_blorp_surface_info_init() when<br>
to suppress? I didn't like that too much. Thoughts?<span class=""><br></span></blockquote><div><br></div><div>Nope, this patch is fine. Please put the above explanation or something like it in the commit message<br><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
><br>
> On Aug 31, 2016 9:06 AM, "Topi Pohjolainen"<br>
</span>> <[1]<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.com</a><wbr>> wrote:<br>
><br>
> Signed-off-by: Topi Pohjolainen <[2]<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.com</a><wbr>><br>
<span class="">> ---<br>
> src/intel/blorp/blorp_blit.c | 3 ---<br>
> 1 file changed, 3 deletions(-)<br>
> diff --git a/src/intel/blorp/blorp_blit.c<br>
> b/src/intel/blorp/blorp_blit.c<br>
> index 170c381..026061b 100644<br>
> --- a/src/intel/blorp/blorp_blit.c<br>
> +++ b/src/intel/blorp/blorp_blit.c<br>
> @@ -1271,9 +1271,6 @@ static void<br>
> surf_convert_to_single_slice(<wbr>const struct isl_device *isl_dev,<br>
> struct brw_blorp_surface_info *info)<br>
> {<br>
> - /* This only makes sense for a single level and array slice */<br>
> - assert(info->view.levels == 1 && info->view.array_len == 1);<br>
> -<br>
> /* Just bail if we have nothing to do. */<br>
> if (info->surf.dim == ISL_SURF_DIM_2D &&<br>
> info->view.base_level == 0 && info->view.base_array_layer ==<br>
> 0 &&<br>
> --<br>
> 2.5.5<br>
> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
</span>> [3]<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.<wbr>org</a><br>
> [4]<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.<wbr>org/mailman/listinfo/mesa-dev</a><br>
><br>
> References<br>
><br>
> 1. mailto:<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.<wbr>com</a><br>
> 2. mailto:<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.<wbr>com</a><br>
> 3. mailto:<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.<wbr>freedesktop.org</a><br>
> 4. <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
<div class="HOEnZb"><div class="h5"><br>
> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
<br>
</div></div></blockquote></div><br></div></div>