<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Aug 31, 2016 at 9:56 PM, Pohjolainen, Topi <span dir="ltr"><<a href="mailto:topi.pohjolainen@gmail.com" target="_blank">topi.pohjolainen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Aug 31, 2016 at 05:41:24PM -0700, Jason Ekstrand wrote:<br> > On Wed, Aug 31, 2016 at 8:17 AM, Topi Pohjolainen<br> </span><span class="">> <[1]<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.com</a><wbr>> wrote:<br> ><br> > Otherwise once mcs buffer gets allocated without delay for<br> > lossless compression (same as we do for msaa), assert starts<br> > to fire in piglit case: tex3d. The test uses depth of one<br> > which is in fact supported even now.<br> </span>> Signed-off-by: Topi Pohjolainen <[2]<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.com</a><wbr>><br> > ---<br> > Â src/intel/isl/isl.c | 7 ++++++-<br> > Â 1 file changed, 6 insertions(+), 1 deletion(-)<br> <span class="">> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c<br> > index c4989dd..b5c4a8c 100644<br> > --- a/src/intel/isl/isl.c<br> > +++ b/src/intel/isl/isl.c<br> > @@ -1328,7 +1328,12 @@ isl_surf_get_ccs_surf(const struct isl_device<br> > *dev,<br> </span>> Â Â assert(surf->samples == 1 && surf->msaa_layout ==<br> > ISL_MSAA_LAYOUT_NONE);<br> > Â Â assert(ISL_DEV_GEN(dev) >= 7);<br> > -Â Â assert(surf->dim == ISL_SURF_DIM_2D);<br> > +Â Â if (ISL_DEV_GEN(dev) < 8) {<br> > +Â Â Â assert(surf->dim == ISL_SURF_DIM_2D);<br> > +Â Â } else {<br> > +Â Â Â assert(surf->dim == ISL_SURF_DIM_2D || surf->dim ==<br> > ISL_SURF_DIM_3D);<br> > +Â Â }<br> ><br> > What about 1D?Â Maybe we just never try to allocate 1D Y-tiled.Â<br> <br> I guess so, I can't think of any restrictions why compression or fast clear<br> itself wouldn't be supported.<span class=""><br></span></blockquote><div><br></div><div>In that case, let's just get rid of the assert entirely.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""> > Also, if it's 3D, should we assert depth == 1?<br> <br> </span>Check for the depth is just below.<br></blockquote><div><br></div><div>So it is...<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> > Â<br> ><br> > +<br> > Â Â assert(surf->logical_level0_<wbr>px.depth == 1);<br> > Â Â /* TODO: More conditions where it can fail. */<br> <span class="">> --<br> > 2.5.5<br> > ______________________________<wbr>_________________<br> > mesa-dev mailing list<br> </span>> [3]<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.<wbr>org</a><br> > [4]<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.<wbr>org/mailman/listinfo/mesa-dev</a><br> ><br> > References<br> ><br> > 1. mailto:<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.<wbr>com</a><br> > 2. mailto:<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.<wbr>com</a><br> > 3. mailto:<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.<wbr>freedesktop.org</a><br> > 4. <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br> <div class="HOEnZb"><div class="h5"><br> > ______________________________<wbr>_________________<br> > mesa-dev mailing list<br> > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br> > <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br> <br> </div></div></blockquote></div><br></div></div>