<div dir="ltr"><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div>But definitely not tested-by :-) </div><div class="gmail_extra"> <div class="gmail_quote">On Sun, Sep 4, 2016 at 7:47 PM, Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" target="_blank">imirkin@alum.mit.edu</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Found by inspection. Untested beyond compilation. Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> --- src/compiler/nir/nir_opcodes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opcodes.py b/src/compiler/nir/nir_opcodes.py index 15066c2..7045c95 100644 --- a/src/compiler/nir/nir_opcodes.py +++ b/src/compiler/nir/nir_opcodes.py @@ -257,7 +257,7 @@ unpack_4x8("unorm") unpack_2x16("half") unop_horiz("pack_uvec2_to_uint", 1, tuint32, 2, tuint32, """ -dst.x = (src0.x & 0xffff) | (src0.y >> 16); +dst.x = (src0.x & 0xffff) | (src0.y << 16); """) unop_horiz("pack_uvec4_to_uint", 1, tuint32, 4, tuint32, """ -- 2.7.3 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>