<html> <head> <meta content="text/html; charset=utf-8" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 09/07/2016 09:56 AM, Ian Romanick wrote: </div> <blockquote cite="mid:590adae7-abc9-29c2-eefb-1dd168a4ba1a@freedesktop.org" type="cite"> <pre wrap="">On 09/06/2016 03:24 PM, Kenneth Graunke wrote: </pre> <blockquote type="cite"> <pre wrap="">On Tuesday, September 6, 2016 1:04:43 PM PDT Eric Anholt wrote: </pre> <blockquote type="cite"> <pre wrap="">Kenneth Graunke <a class="moz-txt-link-rfc2396E" href="mailto:kenneth@whitecape.org"><kenneth@whitecape.org></a> writes: </pre> <blockquote type="cite"> <pre wrap="">Ian added this check in commit 259fc505454ea6a67aeacf6cdebf1398d9947759. While reviewing the rules, I found a citation which spells this out clearly, so I figured I'd send a patch to add it as a comment. Cc: <a class="moz-txt-link-abbreviated" href="mailto:idr@freedesktop.org">idr@freedesktop.org</a> Signed-off-by: Kenneth Graunke <a class="moz-txt-link-rfc2396E" href="mailto:kenneth@whitecape.org"><kenneth@whitecape.org></a> </pre> </blockquote> <pre wrap=""> Reviewed-by: Eric Anholt <a class="moz-txt-link-rfc2396E" href="mailto:eric@anholt.net"><eric@anholt.net></a> I was wondering about this change, because glmark2 is failing to compile its terrain shaders now. </pre> </blockquote> </blockquote> <pre wrap=""> Out of curiosity... is the uniform used in all the stages? </pre> <blockquote type="cite"> <pre wrap="">Really? GLBenchmark 2.7 also fails to compile: <a class="moz-txt-link-freetext" href="https://bugs.freedesktop.org/show_bug.cgi?id=97532">https://bugs.freedesktop.org/show_bug.cgi?id=97532</a> I'm beginning to doubt whether any other vendor implements this part of the spec, or if they have some variation of it. </pre> </blockquote> <pre wrap=""> I added this specifically for a dEQP test. Presumably people are passing that. dEQP-GLES31.functional.shaders.linkage.geometry.uniform.rules.type_mismatch_1. I wonder if this is only enforced in GLSL ES 3.2 shaders? I'll do some spec archaeology to see if the language changed at all over the years. Ugh. </pre> </blockquote> As mentioned in the bug 97532 GLSL ES 1.x spec seems a bit vague in this matter and talks about 'warning' (section 10 Issues). <blockquote cite="mid:590adae7-abc9-29c2-eefb-1dd168a4ba1a@freedesktop.org" type="cite"> <pre wrap=""> </pre> <blockquote type="cite"> <pre wrap="">_______________________________________________ mesa-dev mailing list <a class="moz-txt-link-abbreviated" href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </pre> </blockquote> <pre wrap=""> </pre> <fieldset class="mimeAttachmentHeader"></fieldset> <pre wrap="">_______________________________________________ mesa-dev mailing list <a class="moz-txt-link-abbreviated" href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </pre> </blockquote> </body> </html>