<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<base href="https://bugs.freedesktop.org/"><!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:937370382;
mso-list-template-ids:391939008;}
@list l0:level1
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:36.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:72.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:"Courier New";
mso-bidi-font-family:"Times New Roman";}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:108.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:144.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:180.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:216.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:252.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:288.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:324.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-CA" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi Andy,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I verified the bug. You are correct. The u and v are inversed. I checked your patch, and confirmed it fixes the issue. Patch is Reviewed-by: Boyuan Zhang <boyuan.zhang@amd.com><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thanks a lot for the help!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Boyuan<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> mesa-dev [mailto:mesa-dev-bounces@lists.freedesktop.org]
<b>On Behalf Of </b>bugzilla-daemon@freedesktop.org<br>
<b>Sent:</b> August-09-16 9:52 AM<br>
<b>To:</b> mesa-dev@lists.freedesktop.org<br>
<b>Subject:</b> [Mesa-dev] [Bug 97261] vaapi u/v wrong order since vl/util: add copy func for yv12image to nv12surface<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<table class="MsoNormalTable" border="1" cellspacing="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>Bug ID<o:p></o:p></b></p>
</td>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal"><a href="https://bugs.freedesktop.org/show_bug.cgi?id=97261" title="NEW - vaapi u/v wrong order since vl/util: add copy func for yv12image to nv12surface">97261</a>
<o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>Summary<o:p></o:p></b></p>
</td>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal">vaapi u/v wrong order since vl/util: add copy func for yv12image to nv12surface
<o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>Product<o:p></o:p></b></p>
</td>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal">Mesa <o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>Version<o:p></o:p></b></p>
</td>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal">git <o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>Hardware<o:p></o:p></b></p>
</td>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal">Other <o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>OS<o:p></o:p></b></p>
</td>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal">All <o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>Status<o:p></o:p></b></p>
</td>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal">NEW <o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>Severity<o:p></o:p></b></p>
</td>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal">normal <o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>Priority<o:p></o:p></b></p>
</td>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal">medium <o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>Component<o:p></o:p></b></p>
</td>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal">Mesa core <o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>Assignee<o:p></o:p></b></p>
</td>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal"><a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a>
<o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>Reporter<o:p></o:p></b></p>
</td>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal"><a href="mailto:adf.lists@gmail.com">adf.lists@gmail.com</a>
<o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal" align="center" style="text-align:center"><b>QA Contact<o:p></o:p></b></p>
</td>
<td style="padding:6.0pt 6.0pt 6.0pt 6.0pt">
<p class="MsoNormal"><a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a>
<o:p></o:p></p>
</td>
</tr>
</tbody>
</table>
<div>
<pre>Created <a name="attach_125638"></a><a href="attachment.cgi?id=125638" title="small test vid">attachment 125638</a> <a href="attachment.cgi?id=125638&action=edit" title="small test vid">[details]</a><o:p></o:p></pre>
<pre>small test vid<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>As noted st the time, though Boyuan said he couldn't reproduce, for me<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>vl/util: add copy func for yv12image to nv12surface<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>gets u and v for both yv12 and I420 inputs reversed whether encoding or<o:p></o:p></pre>
<pre>playing.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Both gstreamer and mpv affected.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Testing playback using attached small test vid that instantly shows the issue<o:p></o:p></pre>
<pre>either<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>VAAPI_DISABLE_INTERLACE=true mpv --vo=vaapi uvtest.mkv<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>or<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>gst-launch-1.0 filesrc location=uvtest.mkv ! matroskademux ! avdec_h264 !<o:p></o:p></pre>
<pre>vaapisink<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Of course any test that outputs nv12 works OK as it avoids the conversion.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>It seems that the new util function expects input to be yuv, but it actually<o:p></o:p></pre>
<pre>gets yvu.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>I sent a patch to the list for this -<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><a href="https://lists.freedesktop.org/archives/mesa-dev/2016-July/124695.html">https://lists.freedesktop.org/archives/mesa-dev/2016-July/124695.html</a><o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Filing bug/test to see if anyone else reproduce.<o:p></o:p></pre>
</div>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="2" width="100%" align="center">
</div>
<p class="MsoNormal">You are receiving this mail because: <o:p></o:p></p>
<ul type="disc">
<li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo1">
You are the QA Contact for the bug.<o:p></o:p></li><li class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level1 lfo1">
You are the assignee for the bug.<o:p></o:p></li></ul>
</div>
</body>
</html>