<html> <head> <meta content="text/html; charset=utf-8" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <blockquote cite="mid:5A0E318D73C83C40A09BDBBE131796D738C1132E@shsmsx102.ccr.corp.intel.com" type="cite"> <pre wrap=""> That doesn't seem good to me. With that patch, that means that since no one is implementing __DRI_IMAGE_ATTRIB_OFFSET (yes I know in a later patch you implement it for i965), then what used to work will stop working (as the queryImage will return false). You need to introduce some interface version implementation check. [****Chuanbo****] Maybe I can add more comment to git log (such as "This patch just implements egl loader side, the driver side implementation is also needed for corresponding platform"), so user can be aware of this. Introduce interface version implementation check will make mesa code more complex, because we should also add related check to other dri2 functions(dri2_****). Another solution is combining the three patches into one patch, as I did before: <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/archives/mesa-dev/2016-August/126945.html">https://lists.freedesktop.org/archives/mesa-dev/2016-August/126945.html</a> This is not as easy as this version for reviewers, but more clearer for users. Emil, what do you think? </pre> </blockquote> No, that's not ok. First i965 isn't the only one to implement the dri image interface (see the gallium one), second a new implementer doesn't have to start from the most recent version, and can choose to implement older version, which wouldn't implement your new functionnality. The code has to be something like: if (offsets) { offsets[0] = 0; if (dri2_dpy->image->base.version >= 13) <p style="white-space: pre-wrap; color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: 1; word-spacing: 0px; -webkit-text-stroke-width: 0px;"> dri2_dpy->image->queryImage(dri2_img->dri_image, __DRI_IMAGE_ATTRIB_OFFSET, offsets); <p style="white-space: pre-wrap; color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: 1; word-spacing: 0px; -webkit-text-stroke-width: 0px;">} <p style="white-space: pre-wrap; color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: 1; word-spacing: 0px; -webkit-text-stroke-width: 0px;"> <p style="white-space: pre-wrap; color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: 1; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Axel<tt> </tt> </body> </html>