<div dir="ltr"><div><div><div>It all looks fine to me. Feel free to add a </div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div>That said, my knowledge of the details of the DRI vfuncs is very limited so I'd like to see Emil or Axel sign off on it too, especially since they were the ones who had all the comments. </div>--Jason </div><div class="gmail_extra"> <div class="gmail_quote">On Mon, Sep 19, 2016 at 3:55 AM, Weng, Chuanbo <<a href="mailto:chuanbo.weng@intel.com" target="_blank">chuanbo.weng@intel.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Seems they haven't got lost, because I see these patches in the mailing-list webpage: <a href="https://lists.freedesktop.org/archives/mesa-dev/2016-September/128847.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/archives/mesa-dev/2016-September/128847.html</a> <a href="https://lists.freedesktop.org/archives/mesa-dev/2016-September/128845.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/archives/mesa-dev/2016-September/128845.html</a> <a href="https://lists.freedesktop.org/archives/mesa-dev/2016-September/128846.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/archives/mesa-dev/2016-September/128846.html</a> <a href="https://lists.freedesktop.org/archives/mesa-dev/2016-September/128844.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/archives/mesa-dev/2016-September/128844.html</a> And my gmail account also receives these patches. Thanks, Chuanbo Weng <div class="HOEnZb"><div class="h5"> -----Original Message----- From: Nicolai Hähnle [mailto:<a href="mailto:nhaehnle@gmail.com">nhaehnle@gmail.com</a>] Sent: Monday, September 19, 2016 4:53 PM To: Weng, Chuanbo <<a href="mailto:chuanbo.weng@intel.com">chuanbo.weng@intel.com</a>>; <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a>; <a href="mailto:emil.l.velikov@gmail.com">emil.l.velikov@gmail.com</a> Subject: Re: [Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding offset. Those patches got lost somehow? Maybe they weren't sent out as replies to your first email, check the git configuration for sendemail.thread or the git send-email --thread flag. Cheers, Nicolai On 18.09.2016 09:04, Weng, Chuanbo wrote: > Ping for review. Thanks. > > -----Original Message----- > From: Weng, Chuanbo > Sent: Wednesday, September 14, 2016 1:07 AM > To: <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a>; <a href="mailto:emil.l.velikov@gmail.com">emil.l.velikov@gmail.com</a> > Cc: Weng, Chuanbo <<a href="mailto:chuanbo.weng@intel.com">chuanbo.weng@intel.com</a>> > Subject: [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding offset. > > This patchset makes eglExportDMABUFImageMESA return corresponding offset of EGLImage instead of 0 on intel platfrom with classic dri driver(i965). > > v2: Add version check of __DRIimageExtension implementation in egl loader (Suggested by Axel Davy). > > v3: Don't add version check of __DRIimageExtension implementation in > egl loader. Set the offset only when queryImage() succeeds. (Suggested > by Emil > Velikov) > > Chuanbo Weng (3): > dri: add offset attribute and bump version of EGLImage extensions. > egl: return corresponding offset of EGLImage instead of 0. > i965: implement querying __DRI_IMAGE_ATTRIB_OFFSET. > > include/GL/internal/dri_interface.h | 4 +++- > src/egl/drivers/dri2/egl_dri2.c | 8 +++++++- > src/mesa/drivers/dri/i965/intel_screen.c | 9 +++++++-- > 3 files changed, 17 insertions(+), 4 deletions(-) > > -- > 1.9.1 > > _______________________________________________ > mesa-dev mailing list > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> > _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </div></div></blockquote></div> </div>