<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Am 21.09.2016 um 16:38 schrieb Andy
Furniss:<br>
</div>
<blockquote cite="mid:57E29B64.5020905@gmail.com" type="cite">Andy
Furniss wrote:
<br>
<blockquote type="cite">Andy Furniss wrote:
<br>
<blockquote type="cite">Andy Furniss wrote:
<br>
<br>
<blockquote type="cite">bz2 compressed vid showing the issue -
<br>
<br>
<a class="moz-txt-link-freetext" href="https://drive.google.com/open?id=0BxP5-S1t9VEEUE5sbUFBV20zSms">https://drive.google.com/open?id=0BxP5-S1t9VEEUE5sbUFBV20zSms</a>
<br>
</blockquote>
<br>
To be clear this is just the test rez vid I used so you can
<br>
possibly recreate the issue your self.
<br>
</blockquote>
<br>
Hmm, interesting, with bicubic, hqscaling=1 this vid behaves
<br>
differently with mplayer compared to mpv, the latter looks like
<br>
it's scaling a bit, maybe there's an off by one somewhere in mpv
<br>
code.
<br>
</blockquote>
<br>
I don't know if it's the cause, but looking for differences
between
<br>
mplayer and mpv it seems that mpv sets video mixer height so it's
<br>
divisible by 32 but mplayer doesn't. For this 720p sample it uses
736
<br>
and mplayer uses 720.
<br>
<br>
vdp_video_mixer_create(1, 1, {11}, 3, {0, 1, 2}, {1280, 736, 0},
-)
<br>
<br>
for output surfaces and render calls it uses 720.
<br>
<br>
So does the bicubic code see/use this 736 somewhere?
<br>
</blockquote>
<br>
Well that would clearly explain some differences. Are the video
input buffers rounded up to 32 as well?<br>
<br>
If not then mpv is clearly not using the interface correctly here:<br>
<blockquote type="cite">#define
VDP_VIDEO_MIXER_PARAMETER_VIDEO_SURFACE_HEIGHT
<div class="memdoc">
<p>The exact height of input video surfaces. </p>
<p>This parameter's type is uint32_t.</p>
<p>This parameter defaults to 0 if not specified, which entails
that it must be specified.</p>
<p>The application may query this parameter's supported range. </p>
</div>
<div class="memitem">
<div class="memproto">
<table class="memname">
<tbody>
<tr>
<td class="memname">#define
VDP_VIDEO_MIXER_PARAMETER_VIDEO_SURFACE_WIDTH</td>
</tr>
</tbody>
</table>
</div>
<div class="memdoc">
<p>The exact width of input video surfaces. </p>
<p>This parameter's type is uint32_t.</p>
<p>This parameter defaults to 0 if not specified, which
entails that it must be specified.</p>
<p>The application may query this parameter's supported range.
</p>
</div>
</div>
</blockquote>
<br>
Maybe we should make the checks done during rending more strict?<br>
<br>
Regards,<br>
Christian.<br>
<br>
<blockquote cite="mid:57E29B64.5020905@gmail.com" type="cite">
<br>
_______________________________________________
<br>
mesa-dev mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a>
<br>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a>
<br>
</blockquote>
<p><br>
</p>
</body>
</html>