<p dir="ltr"></p>
<p dir="ltr">On Sep 28, 2016 12:10 PM, "Anuj Phogat" <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>> wrote:<br>
><br>
> On Wed, Sep 21, 2016 at 12:49 PM, Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>> wrote:<br>
> > On Wed, Sep 21, 2016 at 11:49 AM, Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote:<br>
> >> This seems odd... When can it even happen that we have persample_dispatch<br>
> >> set in wm_surface_state and have only one sample? Does this fix a test<br>
> >> case?<br>
> >><br>
> > No, It just fixes a simulator warning. It's recommended in graphics spec<br>
> > for gen7. Also look at gen7_wm_state.c.<br>
> ><br>
> Jason, do you still have concerns about this patch?</p>
<p dir="ltr">No, not really. R-b</p>
<p dir="ltr">> >> On Sep 21, 2016 9:14 PM, "Anuj Phogat" <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>> wrote:<br>
> >>><br>
> >>> Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br>
> >>> ---<br>
> >>> src/intel/vulkan/gen7_pipeline.c | 3 ++-<br>
> >>> 1 file changed, 2 insertions(+), 1 deletion(-)<br>
> >>><br>
> >>> diff --git a/src/intel/vulkan/gen7_pipeline.c<br>
> >>> b/src/intel/vulkan/gen7_pipeline.c<br>
> >>> index 878308b..5150ef9 100644<br>
> >>> --- a/src/intel/vulkan/gen7_pipeline.c<br>
> >>> +++ b/src/intel/vulkan/gen7_pipeline.c<br>
> >>> @@ -267,7 +267,8 @@ genX(graphics_pipeline_create)(<br>
> >>><br>
> >>> wm.MultisampleRasterizationMode = samples > 1 ?<br>
> >>> MSRASTMODE_ON_PATTERN :<br>
> >>> MSRASTMODE_OFF_PIXEL;<br>
> >>> - wm.MultisampleDispatchMode =<br>
> >>> wm_prog_data->persample_dispatch ?<br>
> >>> + wm.MultisampleDispatchMode = ((samples == 1) ||<br>
> >>> + (samples > 1 &&<br>
> >>> wm_prog_data->persample_dispatch)) ?</p>
<p dir="ltr">You could simply do "samples ==1 || wm_prog_data->persample_dispatch" but I don't really care that much one way or the other.</p>
<p dir="ltr">> >>> MSDISPMODE_PERSAMPLE :<br>
> >>> MSDISPMODE_PERPIXEL;<br>
> >>> }<br>
> >>> }<br>
> >>> --<br>
> >>> 2.5.5<br>
> >>><br>
> >>> _______________________________________________<br>
> >>> mesa-dev mailing list<br>
> >>> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> >>> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br></p>