<p dir="ltr">Flyby comments...</p>
<p dir="ltr">On Sep 30, 2016 3:34 PM, "Anuj Phogat" <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>> wrote:<br>
><br>
> Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br>
> ---<br>
> src/intel/vulkan/gen7_pipeline.c | 6 ++++++<br>
> 1 file changed, 6 insertions(+)<br>
><br>
> diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c<br>
> index 8d133b6..f98aef5 100644<br>
> --- a/src/intel/vulkan/gen7_pipeline.c<br>
> +++ b/src/intel/vulkan/gen7_pipeline.c<br>
> @@ -121,6 +121,12 @@ genX(graphics_pipeline_create)(<br>
> };<br>
> vs.PerThreadScratchSpace = scratch_space(&vs_prog_data->base.base);<br>
><br>
> + vs.FloatingPointMode = vs_prog_data->base.base.use_alt_mode ?<br>
> + Alternate : IEEE754;</p>
<p dir="ltr">I'm pretty sure we only use alt mode for ARB programs do it doesn't really apply to Vulkan. Explicitly setting it to IEEE seems reasonable though.</p>
<p dir="ltr">> + vs.SamplerCount = 0;<br>
> + vs.BindingTableEntryCount =<br>
> + vs_prog_data->base.base.binding_table.size_bytes / 4;</p>
<p dir="ltr">We don't set the binding table size field in the Vulkan driver so I don't think this actually does anything. Maybe we should actually set sampler and surface state counts to something reasonable? It might have a performance impact but I don't know if we've ever measured it.</p>
<p dir="ltr">> +<br>
> vs.DispatchGRFStartRegisterforURBData =<br>
> vs_prog_data->base.base.dispatch_grf_start_reg;<br>
><br>
> --<br>
> 2.5.5<br>
><br>
> _______________________________________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br></p>