<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 21, 2016 at 10:31 PM, Kenneth Graunke <span dir="ltr"><<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">commit e07457d0aec96970a39a2dd1cb4e46<wbr>da6107eb77 removed the last use<br>
of ctx->Transform on Gen6. It looks like Gen7 never needed this, but<br></blockquote><div><br></div><div>Not so much... The mentioned commit actually contains a very nice comment specifying why NEW_TRANSFORM is needed. On gen6, some elements of prog_data->param may refer to user clip planes so we need to re-upload push constants whenever we get NEW_TRANSFORM.<br><br></div><div>Not sure what the implications are for IVB.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I copied it over when I originally ported the driver to Ivybridge.<br>
<br>
Signed-off-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>><br>
---<br>
src/mesa/drivers/dri/i965/<wbr>gen6_vs_state.c | 3 +--<br>
src/mesa/drivers/dri/i965/<wbr>gen7_vs_state.c | 2 +-<br>
2 files changed, 2 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/<wbr>gen6_vs_state.c b/src/mesa/drivers/dri/i965/<wbr>gen6_vs_state.c<br>
index 5446ef9..849fff9 100644<br>
--- a/src/mesa/drivers/dri/i965/<wbr>gen6_vs_state.c<br>
+++ b/src/mesa/drivers/dri/i965/<wbr>gen6_vs_state.c<br>
@@ -60,8 +60,7 @@ gen6_upload_vs_push_constants(<wbr>struct brw_context *brw)<br>
<br>
const struct brw_tracked_state gen6_vs_push_constants = {<br>
.dirty = {<br>
- .mesa = _NEW_PROGRAM_CONSTANTS |<br>
- _NEW_TRANSFORM,<br>
+ .mesa = _NEW_PROGRAM_CONSTANTS,<br>
.brw = BRW_NEW_BATCH |<br>
BRW_NEW_BLORP |<br>
BRW_NEW_PUSH_CONSTANT_<wbr>ALLOCATION |<br>
diff --git a/src/mesa/drivers/dri/i965/<wbr>gen7_vs_state.c b/src/mesa/drivers/dri/i965/<wbr>gen7_vs_state.c<br>
index 2715b37..7daa018 100644<br>
--- a/src/mesa/drivers/dri/i965/<wbr>gen7_vs_state.c<br>
+++ b/src/mesa/drivers/dri/i965/<wbr>gen7_vs_state.c<br>
@@ -74,7 +74,7 @@ upload_vs_state(struct brw_context *brw)<br>
<br>
const struct brw_tracked_state gen7_vs_state = {<br>
.dirty = {<br>
- .mesa = _NEW_TRANSFORM,<br>
+ .mesa = 0,<br>
.brw = BRW_NEW_BATCH |<br>
BRW_NEW_BLORP |<br>
BRW_NEW_CONTEXT |<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.10.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>