<div dir="ltr"> On Fri, Sep 30, 2016 at 5:02 PM, Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote: > On Sep 30, 2016 3:34 PM, "Anuj Phogat" <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>> wrote: >> >> Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>> >> --- >> src/intel/vulkan/gen7_pipeline.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/src/intel/vulkan/gen7_pipeline.c >> b/src/intel/vulkan/gen7_pipeline.c >> index 9411631..4bab0bc 100644 >> --- a/src/intel/vulkan/gen7_pipeline.c >> +++ b/src/intel/vulkan/gen7_pipeline.c >> @@ -243,6 +243,10 @@ genX(graphics_pipeline_create)( >> /* Haswell requires the sample mask to be set in this packet as >> well as >> * in 3DSTATE_SAMPLE_MASK; the values should match. */ >> /* _NEW_BUFFERS, _NEW_MULTISAMPLE */ >> +# if (GEN_IS_HASWELL) > > There is some code that uses this #if style but I think the "official" style > is to not indent and not use the parens. > >> + ps.SampleMask = 0xff; >> +# endif >> + ps.SamplerCount = 1; > > Of we're going to add code to set sampler count, it should be accurate. > It's probably best to drop this line and have a later patch which actually > sets it correctly. > >> } >> >> uint32_t samples = pCreateInfo->pMultisampleState ? >> -- >> 2.5.5 >> >> _______________________________________________ >> mesa-dev mailing list >> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> >> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> I sent out the V2: <a href="https://patchwork.freedesktop.org/patch/113460/">https://patchwork.freedesktop.org/patch/113460/</a></div>